Merge pull request #165 from chickensoft-games/fix/bindings

fix: allow bindings to be added and removed during bindings invocations

Author: jolexxa

.editorconfig

@@ -51,6 +51,11 @@ trim_trailing_whitespace = true
 # File Extension Settings
 ##########################################
 
+# GDScript Files
+[*.gd]
+indent_style = tab
+indent_size = 2
+
 # Visual Studio Solution Files
 [*.sln]
 indent_style = tab
@@ -91,7 +96,7 @@ end_of_line = lf
 [Makefile]
 indent_style = tab
 
-[*_Generated.cs, *.g.cs, *.generated.cs]
+[*{_Generated.cs,.g.cs,.generated.cs}]
 # Ignore a lack of documentation for generated code. Doesn't apply to builds,
 # just to viewing generation output.
 dotnet_diagnostic.CS1591.severity = none
@@ -100,7 +105,7 @@ dotnet_diagnostic.CS1591.severity = none
 # Default .NET Code Style Severities
 ##########################################
 
-[*.{cs,csx,cake,vb,vbx}]
+[*.cs]
 # Default Severity for all .NET Code Style rules below
 dotnet_analyzer_diagnostic.severity = warning
 
@@ -109,7 +114,6 @@ dotnet_analyzer_diagnostic.severity = warning
 ##########################################
 
 # .NET Style Rules
-[*.{cs,csx,cake,vb,vbx}]
 
 # "this." and "Me." qualifiers
 dotnet_style_qualification_for_field = false
@@ -122,7 +126,7 @@ dotnet_style_predefined_type_for_locals_parameters_members = true:warning
 dotnet_style_predefined_type_for_member_access = true:warning
 
 # Modifier preferences
-dotnet_style_require_accessibility_modifiers = always:warning
+dotnet_style_require_accessibility_modifiers = for_non_interface_members:warning
 csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:warning
 visual_basic_preferred_modifier_order = Partial,Default,Private,Protected,Public,Friend,NotOverridable,Overridable,MustOverride,Overloads,Overrides,MustInherit,NotInheritable,Static,Shared,Shadows,ReadOnly,WriteOnly,Dim,Const,WithEvents,Widening,Narrowing,Custom,Async:warning
 dotnet_style_readonly_field = true:warning
@@ -155,7 +159,7 @@ dotnet_style_prefer_is_null_check_over_reference_equality_method = true:warning
 
 # File header preferences
 # Keep operators at end of line when wrapping.
-dotnet_style_operator_placement_when_wrapping = end_of_line:warning
+dotnet_style_operator_placement_when_wrapping = end_of_line
 csharp_style_prefer_null_check_over_type_check = true:warning
 
 # Code block preferences
@@ -164,7 +168,7 @@ csharp_prefer_simple_using_statement = true:suggestion
 dotnet_diagnostic.IDE0063.severity = suggestion
 
 # C# Style Rules
-[*.{cs,csx,cake}]
+
 # 'var' preferences
 csharp_style_var_for_built_in_types = true:warning
 csharp_style_var_when_type_is_apparent = true:warning
@@ -195,10 +199,6 @@ csharp_style_implicit_object_creation_when_type_is_apparent = true:warning
 # "Null" checking preferences
 csharp_style_throw_expression = true:warning
 csharp_style_conditional_delegate_call = true:warning
-# Code block preferences
-csharp_prefer_braces = true:warning
-csharp_prefer_simple_using_statement = true:suggestion
-dotnet_diagnostic.IDE0063.severity = suggestion
 # 'using' directive preferences
 csharp_using_directive_placement = inside_namespace:warning
 # Modifier preferences
@@ -212,14 +212,12 @@ dotnet_code_quality.CA1822.api_surface = private
 ##########################################
 
 # .NET Unnecessary code rules
-[*.{cs,csx,cake,vb,vbx}]
 
 dotnet_code_quality_unused_parameters = non_public:suggestion
 dotnet_remove_unnecessary_suppression_exclusions = none
 dotnet_diagnostic.IDE0079.severity = warning
 
 # C# Unnecessary code rules
-[*.{cs,csx,cake}]
 
 # Chickensoft Unused Code Additions
 #
@@ -244,7 +242,6 @@ dotnet_diagnostic.RCS1213.severity = none
 csharp_style_unused_value_expression_statement_preference = discard_variable
 
 # .NET formatting rules
-[*.{cs,csx,cake,vb,vbx}]
 
 # Organize using directives
 dotnet_sort_system_directives_first = true
@@ -259,7 +256,6 @@ dotnet_style_namespace_match_folder = false
 dotnet_diagnostic.IDE0130.severity = none
 
 # C# formatting rules
-[*.{cs,csx,cake}]
 
 # Newline options
 csharp_new_line_before_open_brace = none
@@ -312,7 +308,6 @@ csharp_style_namespace_declarations = file_scoped:warning
 ##########################################
 # .NET Naming Rules
 ##########################################
-[*.{cs,csx,cake,vb,vbx}]
 
 ##########################################
 # Chickensoft Naming Conventions & Styles
@@ -347,7 +342,7 @@ dotnet_naming_rule.non_public_fields_under_camel.symbols = non_public_fields
 dotnet_naming_rule.non_public_fields_under_camel.style = camel_case_underscore_style
 dotnet_naming_symbols.non_public_fields.applicable_kinds = field
 dotnet_naming_symbols.non_public_fields.required_modifiers =
-dotnet_naming_symbols.non_public_fields.applicable_accessibilities = private,private_protected,protected,internal,protected,protected_internal
+dotnet_naming_symbols.non_public_fields.applicable_accessibilities = private,private_protected,internal,protected,protected_internal
 
 # Public fields should be PascalCase
 dotnet_naming_rule.public_fields_pascal.severity = suggestion
@@ -414,8 +409,6 @@ dotnet_naming_symbols.unspecified.applicable_accessibilities = *
 # Chickensoft Rule Overrides
 ##########################################
 
-# Allow using keywords as names
-# dotnet_diagnostic.CA1716.severity = none
 # Don't require culture info for ToString()
 dotnet_diagnostic.CA1304.severity = none
 # Don't require a string comparison for comparing strings.
@@ -433,9 +426,9 @@ dotnet_diagnostic.IDE0059.severity = none
 # Switch/case should always have a default clause. Tell that to Roslynator.
 dotnet_diagnostic.RCS1070.severity = none
 # Tell roslynator not to eat unused parameters.
-dotnet_diagnostic.RCS1163.severity = none
+dotnet_diagnostic.RCS1163.severity = suggestion
 # Tell dotnet not to remove unused parameters.
-dotnet_diagnostic.IDE0060.severity = none
+dotnet_diagnostic.IDE0060.severity = suggestion
 # Tell roslynator not to remove `partial` modifiers.
 dotnet_diagnostic.RCS1043.severity = none
 # Tell roslynator not to make classes static so aggressively.
@@ -446,10 +439,6 @@ dotnet_diagnostic.RCS1170.severity = none
 # Allow expression values to go unused, even without discard variable.
 # Otherwise, using Moq would be way too verbose.
 dotnet_diagnostic.IDE0058.severity = none
-# Don't let roslynator turn every local variable into a const.
-# If we did, we'd have to specify the types of local variables far more often,
-# and this style prefers type inference.
-dotnet_diagnostic.RCS1118.severity = none
 # Enums don't need to declare explicit values. Everyone knows they start at 0.
 dotnet_diagnostic.RCS1161.severity = none
 # Allow unconstrained type parameter to be checked for null.
@@ -460,27 +449,33 @@ dotnet_diagnostic.CA1716.severity = none
 dotnet_diagnostic.RCS1194.severity = none
 # Allow abstract types to have public constructors.
 dotnet_diagnostic.RCS1160.severity = none
-# Don't warn about unused parameters in lambdas.
-# dotnet_diagnostic.RCS1163.severity = none
 # Don't warn about unused finalizers.
 dotnet_diagnostic.RCS1106.severity = none
 dotnet_diagnostic.CA1821.severity = none
 # Allow me to write silly (but easy to read) if statements!
 dotnet_diagnostic.IDE0046.severity = none
-# Allow me to put comments where I like without turning them into doc comments.
+# Let me put comments where I like
 dotnet_diagnostic.RCS1181.severity = none
 # Results in logic errors by trying to remove lambdas.
 dotnet_diagnostic.IDE0200.severity = none
-# Don't force me to use primary constructors.
+# Allow me to use the word Collection if I want.
+dotnet_diagnostic.CA1711.severity = none
+# No primary constructors — not supported well by tooling.
 dotnet_diagnostic.IDE0290.severity = none
-# Leave me alone about string builder optimizations
-dotnet_diagnostic.RCS1197.severity = none
+# Let me write dumb if statements for readability.
+dotnet_diagnostic.IDE0046.severity = none
+# Don't make me use expression bodies for methods
+dotnet_diagnostic.IDE0022.severity = none
 # Let me have empty destructors
 dotnet_diagnostic.RCS1259.severity = none
-# Leave me alone about static members in generic types.
-dotnet_diagnostic.RCS1158.severity = none
-# Fancy collection syntax doesn't work yet for compatibility.
-dotnet_diagnostic.IDE0028.severity = none
+# DO make me populate a *switch expression*
+dotnet_diagnostic.IDE0072.severity = warning
+# Don't make me populate a *switch statement*
+dotnet_diagnostic.IDE0010.severity = none
+# Make local functions static
+dotnet_diagnostic.IDE0062.severity = warning
+# Don't make me use properties if I don't want to.
+dotnet_diagnostic.IDE0032.severity = none
 # You're wrong about redundant constructors.
 dotnet_diagnostic.RCS1074.severity = none
 # Allow me to nest ternary operators
@@ -489,4 +484,3 @@ dotnet_diagnostic.RCS1238.severity = none
 dotnet_diagnostic.RCS1241.severity = none
 # Leave me alone about "useless" overrides.
 dotnet_diagnostic.RCS1132.severity = none
-

Chickensoft.LogicBlocks.Analyzers/src/LogicBlockAttributeAnalyzer.cs

@@ -12,7 +12,7 @@ namespace Chickensoft.LogicBlocks.Analyzers;
 public class LogicBlockAttributeAnalyzer : DiagnosticAnalyzer {
   public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics {
     get;
-  } = ImmutableArray.Create(Diagnostics.MissingLogicBlockAttributeDescriptor);
+  } = [Diagnostics.MissingLogicBlockAttributeDescriptor];
 
   public override void Initialize(AnalysisContext context) {
     context.EnableConcurrentExecution();

Chickensoft.LogicBlocks.CodeFixes/src/LogicBlockAttributeCodeFix.cs

@@ -18,9 +18,7 @@ namespace Chickensoft.LogicBlocks.CodeFixes;
 public class LogicBlockAttributeCodeFixProvider : CodeFixProvider {
   public sealed override ImmutableArray<string> FixableDiagnosticIds {
     get;
-  } = ImmutableArray.Create(
-    Diagnostics.MissingLogicBlockAttributeDescriptor.Id
-  );
+  } = [Diagnostics.MissingLogicBlockAttributeDescriptor.Id];
 
   public sealed override FixAllProvider GetFixAllProvider() =>
     WellKnownFixAllProviders.BatchFixer;

Chickensoft.LogicBlocks.DiagramGenerator.Tests/test/src/models/ModelsTest.cs

@@ -29,9 +29,9 @@ public void Equality() {
         "file",
         "id",
         "name",
-        System.Array.Empty<string>().ToImmutableHashSet(),
+        [],
         new LogicBlockGraph(
-          "id", "name", "baseId", new List<LogicBlockGraph>()
+          "id", "name", "baseId", []
         ),
         new Dictionary<string, LogicBlockGraph>().ToImmutableDictionary()
       );
@@ -40,9 +40,9 @@ public void Equality() {
         "file",
         "id",
         "name",
-        System.Array.Empty<string>().ToImmutableHashSet(),
+        [],
         new LogicBlockGraph(
-          "id", "name", "baseId", new List<LogicBlockGraph>()
+          "id", "name", "baseId", []
         ),
         new Dictionary<string, LogicBlockGraph>().ToImmutableDictionary()
       );
@@ -51,9 +51,9 @@ public void Equality() {
         "file",
         "id_other",
         "name",
-        System.Array.Empty<string>().ToImmutableHashSet(),
+        [],
         new LogicBlockGraph(
-          "id", "name", "baseId", new List<LogicBlockGraph>()
+          "id", "name", "baseId", []
         ),
         new Dictionary<string, LogicBlockGraph>().ToImmutableDictionary()
       );
@@ -62,9 +62,9 @@ public void Equality() {
         "file",
         "id",
         "name_other",
-        System.Array.Empty<string>().ToImmutableHashSet(),
+        [],
         new LogicBlockGraph(
-          "id", "name", "baseId", new List<LogicBlockGraph>()
+          "id", "name", "baseId", []
         ),
         new Dictionary<string, LogicBlockGraph>().ToImmutableDictionary()
       );
@@ -73,11 +73,11 @@ public void Equality() {
         "file",
         "id",
         "name_other",
-        System.Array.Empty<string>().ToImmutableHashSet(),
+        [],
         new LogicBlockGraph(
-          "id", "name", "baseId", new List<LogicBlockGraph>() {
-            new("id", "name", "baseId", new List<LogicBlockGraph>())
-          }
+          "id", "name", "baseId", [
+            new("id", "name", "baseId", [])
+          ]
         ),
         new Dictionary<string, LogicBlockGraph>().ToImmutableDictionary()
       );

Chickensoft.LogicBlocks.DiagramGenerator.Tests/test_cases/partial_split_across_files/PartialLogic1.cs

@@ -1,4 +1,5 @@
 namespace Chickensoft.LogicBlocks.Generator.Tests;
+
 [LogicBlock(typeof(State), Diagram = true)]
 public partial class PartialLogic : LogicBlock<PartialLogic.State> {
   public override Transition GetInitialState() => To<State.A>();

Chickensoft.LogicBlocks.DiagramGenerator/src/Diagrammer.cs

@@ -73,9 +73,9 @@ public void Initialize(IncrementalGeneratorInitializationContext context) {
       });
 
     var logicBlockCandidates = context.SyntaxProvider.CreateSyntaxProvider(
-      predicate: static (SyntaxNode node, CancellationToken _) =>
+      predicate: static (node, _) =>
         IsLogicBlockCandidate(node),
-      transform: (GeneratorSyntaxContext context, CancellationToken token) =>
+      transform: (context, token) =>
         GetStateGraph(
           (ClassDeclarationSyntax)context.Node, context.SemanticModel, token
         )
@@ -94,8 +94,8 @@ public void Initialize(IncrementalGeneratorInitializationContext context) {
     context.RegisterImplementationSourceOutput(
       source: logicBlockCandidates,
       action: (
-        SourceProductionContext context,
-        GenerationData data
+        context,
+        data
       ) => {
         var disabled = data.Options.LogicBlocksDiagramGeneratorDisabled;
         if (disabled) { return; }
@@ -268,7 +268,7 @@ CancellationToken token
       );
 
       if (!subtypesByBaseType.ContainsKey(baseTypeId)) {
-        subtypesByBaseType[baseTypeId] = new List<INamedTypeSymbol>();
+        subtypesByBaseType[baseTypeId] = [];
       }
 
       subtypesByBaseType[baseTypeId].Add(subtype);
@@ -281,7 +281,7 @@ CancellationToken token
           member.Name == Constants.LOGIC_BLOCK_GET_INITIAL_STATE
       );
 
-    HashSet<string> initialStateIds = new();
+    HashSet<string> initialStateIds = [];
 
     if (
       getInitialStateMethod is IMethodSymbol initialStateMethod &&
@@ -321,7 +321,7 @@ LogicBlockGraph buildGraph(
 
       var subtypes = subtypesByBaseType.ContainsKey(typeId)
         ? subtypesByBaseType[typeId]
-        : new List<INamedTypeSymbol>();
+        : [];
 
       foreach (var subtype in subtypes) {
         graph.Children.Add(buildGraph(subtype, type));

Chickensoft.LogicBlocks.DiagramGenerator/src/models/Models.cs

@@ -28,7 +28,7 @@ public LogicBlockGraph(
     string id,
     string name,
     string baseId
-  ) : this(id, name, baseId, new()) { }
+  ) : this(id, name, baseId, []) { }
 
   /// <summary>
   /// UML-friendly identifier for the logic block graph.

Chickensoft.LogicBlocks.DiagramGenerator/src/utils/Extensions.cs

@@ -35,7 +35,7 @@ public static string Clean(this string text, string? newLine = null) {
     newLine ??= Environment.NewLine;
     var value = text.NormalizeLineEndings();
 
-    var lines = value.Split(new[] { newLine }, StringSplitOptions.None);
+    var lines = value.Split([newLine], StringSplitOptions.None);
     for (var i = 0; i < lines.Length; i++) {
       lines[i] = string.IsNullOrWhiteSpace(lines[i]) ? "" : lines[i];
     }

Chickensoft.LogicBlocks.DiagramGenerator/src/utils/SymbolExtensions.cs

@@ -1,4 +1,5 @@
 namespace Chickensoft.SourceGeneratorUtils;
+
 using System.Collections.Generic;
 using System.Linq;
 using Microsoft.CodeAnalysis;

Chickensoft.LogicBlocks.DiagramGenerator/src/visitors/OutputVisitor.cs

@@ -116,7 +116,7 @@ public override void VisitStructDeclaration(StructDeclarationSyntax node) { }
 
   private void AddOutput(string id, string name) {
     if (!_outputTypes.TryGetValue(OutputContext, out var outputs)) {
-      outputs = new HashSet<LogicBlockOutput>();
+      outputs = [];
       _outputTypes.Add(OutputContext, outputs);
     }