Merge pull request #146 from xodial/xodial/fix-state-logic-extensions

xodial · web-flow · commit 51bf405ef48c · 2025-04-07T16:38:32.000-05:00
chore: keep OnEnter/OnExit from being suggested for every type
diff --git a/Chickensoft.LogicBlocks/src/StateLogicExtensions.cs b/Chickensoft.LogicBlocks/src/StateLogicExtensions.cs
@@ -47,7 +47,7 @@ public static void OnEnter<TBaseState, TDerivedState>(
     Action<TBaseState?> handler
   )
   where TBaseState : StateBase
-  where TDerivedState : TBaseState =>
+  where TDerivedState : StateBase, TBaseState =>
     state.OnEnter<TDerivedState>((previous) => handler(previous as TBaseState));
 
   /// <summary>
@@ -91,6 +91,6 @@ public static void OnExit<TBaseState, TDerivedState>(
     Action<TBaseState?> handler
   )
   where TBaseState : StateBase
-  where TDerivedState : TBaseState =>
+  where TDerivedState : StateBase, TBaseState =>
     state.OnExit<TDerivedState>((next) => handler(next as TBaseState));
 }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public static void OnEnter<TBaseState, TDerivedState>(`
`47`	`47`	`Action<TBaseState?> handler`
`48`	`48`	`)`
`49`	`49`	`where TBaseState : StateBase`
`50`		`- where TDerivedState : TBaseState =>`
	`50`	`+ where TDerivedState : StateBase, TBaseState =>`
`51`	`51`	`state.OnEnter<TDerivedState>((previous) => handler(previous as TBaseState));`
`52`	`52`
`53`	`53`	`/// <summary>`
`@@ -91,6 +91,6 @@ public static void OnExit<TBaseState, TDerivedState>(`
`91`	`91`	`Action<TBaseState?> handler`
`92`	`92`	`)`
`93`	`93`	`where TBaseState : StateBase`
`94`		`- where TDerivedState : TBaseState =>`
	`94`	`+ where TDerivedState : StateBase, TBaseState =>`
`95`	`95`	`state.OnExit<TDerivedState>((next) => handler(next as TBaseState));`
`96`	`96`	`}`