Skip to content

Commit fd0465b

Browse files
committed
chromed versions fix
1 parent 651b8c8 commit fd0465b

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

commands/chrome-system-check.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ echo ${LARAVELCHROMEDRIVER}
1515
php /usr/bin/dusk-versions-check.php ${SYSTEMCHROME} ${SYSTEMCHROMEDRIVER} ${LARAVELCHROMEDRIVER} 1
1616
COMPATIBLE=$(php /usr/bin/dusk-versions-check.php ${SYSTEMCHROME} ${SYSTEMCHROMEDRIVER} ${LARAVELCHROMEDRIVER} 0)
1717
if [[ "$COMPATIBLE" != "OK" ]]; then
18-
printf "${GREEN}Starting system Chromedriver (${SYSTEMCHROMEDRIVER}).\n"
19-
source start-system-chromedriver
20-
else
2118
printf "${GREEN}Starting compatible (project) Chromedriver (${LARAVELCHROMEDRIVER}).${NC}\n"
2219
source start-project-chromedriver
20+
else
21+
printf "${GREEN}Starting system Chromedriver (${SYSTEMCHROMEDRIVER}).\n"
22+
source start-system-chromedriver
2323
fi
2424
printf "${NC}"

commands/dusk-versions-check.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
$system_chrome = $argv[1];
88
$system_chromedriver = $argv[2];
99
$laravel_chromedriver = $argv[3];
10-
$print_info_only = $argv[4];
10+
$print_info_only = @$argv[4];
1111

1212
$compatible = FALSE;
1313
if ($system_chromedriver == $laravel_chromedriver) {
@@ -26,6 +26,7 @@
2626
print $yellow."You can use both Chromedriver shipped with Laravel (".$laravel_chromedriver.") or system Chromeriver (".$system_chromedriver.")".PHP_EOL;
2727
print $yellow."Your project Chromedriver will be automatically started in this case.".PHP_EOL;
2828
print $yellow."If you want to explicitly run system Chromedriver please add the following command to your .gitlab-yml:".PHP_EOL;
29+
print $yellow."- stop-chromedriver".PHP_EOL;
2930
print $yellow."- start-system-chromedriver".PHP_EOL;
3031

3132
} else {

0 commit comments

Comments
 (0)