[Bug] Jogging with keyboard causes page to scroll

[iceboundflame]

On http://chilipeppr.com/jarret and /grbl, I noticed that if the window is larger than the page dimensions, jogging with the keyboard scrolls the page, which is kind of jarring. Can we lock the page scroll and capture the arrow keypresses when the jog command is active?

[chilipeppr]

Give it a try, but the way I solve it is by making sure no widgets are off
the page by collapsing unneeded ones.

On Thu, Jun 16, 2016 at 12:45 AM, David Liu notifications@github.com
wrote:

On http://chilipeppr.com/jarret and /grbl, I noticed that if the window
is larger than the page dimensions, jogging with the keyboard scrolls the
page, which is kind of jarring. Can we lock the page scroll and capture the
arrow keypresses when the jog command is active?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6, or mute the thread
https://github.com/notifications/unsubscribe/AHidbVrYwTMOyzlYvOLOw7IXiraTaLzAks5qMP8egaJpZM4I3HEH
.

[cheton]

How about preventing default browser action when the Axes widget is getting focused? For example:

window.addEventListener('keydown', function(e) { // arrow keys
    if([37, 38, 39, 40].indexOf(e.keyCode) > -1) {
        e.preventDefault();
    }
}, false);

[chilipeppr]

That's a great idea. Would it be possible for you to fork the github, make
change, and then do pull request?

On Wed, Jun 22, 2016 at 4:32 AM, Cheton Wu notifications@github.com wrote:

How about preventing default browser action when the Axes widget is
getting focused? For example:

window.addEventListener('keydown', function(e) { // arrow keys
if([37, 38, 39, 40].indexOf(e.keyCode) > -1) {
e.preventDefault();
}
}, false);

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#6 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHidbfW9eH3M-iyaAnRcpdASiNg7ocqJks5qOR1pgaJpZM4I3HEH
.

[cheton]

Sure! I can create a PR once I confirmed it works from my side. :)