ECI: throw on invalid encoding ID

codemasher · codemasher · commit 16534f605cf1 · 2023-07-13T18:34:14.000+02:00
diff --git a/src/Data/ECI.php b/src/Data/ECI.php
@@ -65,6 +65,7 @@ public function getLengthInBits():int{
 	 * Writes an ECI designator to the bitbuffer
 	 *
 	 * @inheritDoc
+	 * @throws \chillerlan\QRCode\Data\QRCodeDataException
 	 */
 	public function write(BitBuffer $bitBuffer, int $versionNumber):QRDataModeInterface{
 		$bitBuffer->put(self::DATAMODE, 4);
@@ -78,6 +79,9 @@ public function write(BitBuffer $bitBuffer, int $versionNumber):QRDataModeInterf
 		elseif($this->encoding < 1000000){
 			$bitBuffer->put(($this->encoding | 0xC00000), 24);
 		}
+		else{
+			throw new QRCodeDataException('invalid ECI ID');
+		}
 
 		return $this;
 	}

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@ public function getLengthInBits():int{`
`65`	`65`	`* Writes an ECI designator to the bitbuffer`
`66`	`66`	`*`
`67`	`67`	`* @inheritDoc`
	`68`	`+ * @throws \chillerlan\QRCode\Data\QRCodeDataException`
`68`	`69`	`*/`
`69`	`70`	`public function write(BitBuffer $bitBuffer, int $versionNumber):QRDataModeInterface{`
`70`	`71`	`$bitBuffer->put(self::DATAMODE, 4);`
`@@ -78,6 +79,9 @@ public function write(BitBuffer $bitBuffer, int $versionNumber):QRDataModeInterf`
`78`	`79`	`elseif($this->encoding < 1000000){`
`79`	`80`	`$bitBuffer->put(($this->encoding \| 0xC00000), 24);`
`80`	`81`	`}`
	`82`	`+ else{`
	`83`	`+ throw new QRCodeDataException('invalid ECI ID');`
	`84`	`+ }`
`81`	`85`
`82`	`86`	`return $this;`
`83`	`87`	`}`