Skip to content

Commit 6209776

Browse files
committed
🚒
1 parent 2cfc3e7 commit 6209776

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
- name: "Install PHP"
2626
uses: shivammathur/setup-php@v2
2727
with:
28-
php-version: "7.2"
28+
php-version: "7.4"
2929
coverage: none
3030
tools: pecl
3131
extensions: ast, gd, imagick, json, mbstring
@@ -46,7 +46,7 @@ jobs:
4646
matrix:
4747
os:
4848
- ubuntu-latest
49-
- windows-latest
49+
# - windows-latest
5050
php-version:
5151
- "7.2"
5252
- "7.3"

tests/Output/QRImageTest.php

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
namespace chillerlan\QRCodeTest\Output;
1414

1515
use chillerlan\QRCode\{QRCode, Output\QRImage};
16+
use const PHP_MAJOR_VERSION;
1617

1718
class QRImageTest extends QROutputTestAbstract{
1819

@@ -63,7 +64,14 @@ public function testOutputGetResource():void{
6364

6465
$this->setOutputInterface();
6566

66-
$this::assertIsResource($this->outputInterface->dump());
67+
$data = $this->outputInterface->dump();
68+
69+
if(PHP_MAJOR_VERSION >= 8){
70+
$this::assertInstanceOf('\\GdImage', $data);
71+
}
72+
else{
73+
$this::assertIsResource($data);
74+
}
6775
}
6876

6977
}

0 commit comments

Comments
 (0)