💄

Author: codemasher

src/Data/QRMatrix.php

@@ -578,9 +578,8 @@ public function setLogoSpace(int $width, int $height = null, int $startX = null,
 		$startY = ((($startY !== null) ? $startY : ($length - $height) / 2) + $qz);
 
 		// clear the space
-		foreach($this->matrix as $y => $row){
-			/** @SuppressWarnings(PHPMD.UnusedLocalVariable) */
-			foreach($row as $x => $val){
+		for($y = 0; $y < $this->moduleCount; $y++){
+			for($x = 0; $x < $this->moduleCount; $x++){
 				// out of bounds, skip
 				if($x < $start || $y < $start ||$x >= $end || $y >= $end){
 					continue;

src/Decoder/Binarizer.php

@@ -204,16 +204,12 @@ private function getHistogramBlackMatrix(int $width, int $height):BitMatrix{
 	 * @see http://groups.google.com/group/zxing/browse_thread/thread/d06efa2c35a7ddc0
 	 */
 	private function calculateBlackPoints(int $subWidth, int $subHeight, int $width, int $height):array{
-		$blackPoints = array_fill(0, $subHeight, 0);
-
-		/** @SuppressWarnings(PHPMD.UnusedLocalVariable) */
-		foreach($blackPoints as $key => $point){
-			$blackPoints[$key] = array_fill(0, $subWidth, 0);
-		}
+		$blackPoints = [];
 
 		for($y = 0; $y < $subHeight; $y++){
-			$yoffset    = ($y << self::BLOCK_SIZE_POWER);
-			$maxYOffset = ($height - self::BLOCK_SIZE);
+			$yoffset         = ($y << self::BLOCK_SIZE_POWER);
+			$maxYOffset      = ($height - self::BLOCK_SIZE);
+			$blackPoints[$y] = [];
 
 			if($yoffset > $maxYOffset){
 				$yoffset = $maxYOffset;