QRCode::isByte(): string "0" fails with empty()

codemasher · codemasher · commit de3dd9a48044 · 2022-07-25T11:04:58.000+02:00
diff --git a/src/QRCode.php b/src/QRCode.php
@@ -307,7 +307,7 @@ public function isKanji(string $string):bool{
 	 * a dummy
 	 */
 	public function isByte(string $data):bool{
-		return !empty($data);
+		return $data !== '';
 	}
 
 }
diff --git a/tests/QRCodeTest.php b/tests/QRCodeTest.php
@@ -74,6 +74,7 @@ public function testIsKanji():void{
 	public function testIsByte():void{
 		$this::assertTrue($this->qrcode->isByte("\x01\x02\x03"));
 		$this::assertTrue($this->qrcode->isByte('            ')); // not empty!
+		$this::assertTrue($this->qrcode->isByte('0'));
 
 		$this::assertFalse($this->qrcode->isByte(''));
 	}

Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,7 @@ public function isKanji(string $string):bool{`
`307`	`307`	`* a dummy`
`308`	`308`	`*/`
`309`	`309`	`public function isByte(string $data):bool{`
`310`		`- return !empty($data);`
	`310`	`+ return $data !== '';`
`311`	`311`	`}`
`312`	`312`
`313`	`313`	`}`
Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ public function testIsKanji():void{`
`74`	`74`	`public function testIsByte():void{`
`75`	`75`	`$this::assertTrue($this->qrcode->isByte("\x01\x02\x03"));`
`76`	`76`	`$this::assertTrue($this->qrcode->isByte(' ')); // not empty!`
	`77`	`+ $this::assertTrue($this->qrcode->isByte('0'));`
`77`	`78`
`78`	`79`	`$this::assertFalse($this->qrcode->isByte(''));`
`79`	`80`	`}`