phpstan ignore by php version

Author: codemasher

.github/workflows/ci.yml

@@ -58,8 +58,8 @@ jobs:
       - name: "Run phan"
         run: php vendor/bin/phan --target-php-version=${{ matrix.php-version }}
 
-#      - name: "Run PHPStan"
-#        run: php vendor/bin/phpstan
+      - name: "Run PHPStan"
+        run: php vendor/bin/phpstan
 
 
   build-docs:

.phpstan/baseline-lt-8.4.neon

@@ -0,0 +1,34 @@
+parameters:
+	excludePaths:
+		- ../tests/PropertyHooksContainer.php
+
+	ignoreErrors:
+		-
+			rawMessage: Access to constant Get on an unknown class PropertyHookType.
+			identifier: class.notFound
+			count: 1
+			path: ../src/SettingsContainerAbstract.php
+
+		-
+			rawMessage: Access to constant Set on an unknown class PropertyHookType.
+			identifier: class.notFound
+			count: 1
+			path: ../src/SettingsContainerAbstract.php
+
+		-
+			rawMessage: 'Call to an undefined method ReflectionProperty::getRawValue().'
+			identifier: method.notFound
+			count: 2
+			path: ../src/SettingsContainerAbstract.php
+
+		-
+			rawMessage: 'Call to an undefined method ReflectionProperty::hasHook().'
+			identifier: method.notFound
+			count: 2
+			path: ../src/SettingsContainerAbstract.php
+
+		-
+			rawMessage: 'Call to an undefined method ReflectionProperty::setRawValue().'
+			identifier: method.notFound
+			count: 1
+			path: ../src/SettingsContainerAbstract.php

.phpstan/ignore-by-php-version.php

@@ -0,0 +1,18 @@
+<?php
+// see: https://github.com/phpstan/phpstan/issues/7843
+
+declare(strict_types = 1);
+
+$includes = [];
+
+if(PHP_VERSION_ID < 80400){
+	$includes[] = __DIR__.'/baseline-lt-8.4.neon';
+}
+
+$config                             = [];
+$config['includes']                 = $includes;
+$config['parameters']['phpVersion'] = PHP_VERSION_ID;
+
+return $config;
+
+

phpstan-baseline.neon

@@ -1,31 +1,79 @@
 parameters:
 	ignoreErrors:
 		-
-			rawMessage: Access to constant Get on an unknown class PropertyHookType.
-			identifier: class.notFound
+			rawMessage: Access to an undefined property chillerlan\SettingsTest\TestContainer::$foo.
+			identifier: property.notFound
 			count: 1
-			path: src/SettingsContainerAbstract.php
+			path: tests/ContainerTest.php
 
 		-
-			rawMessage: Access to constant Set on an unknown class PropertyHookType.
-			identifier: class.notFound
+			rawMessage: Access to private property chillerlan\SettingsTest\TestContainer::$test3.
+			identifier: property.private
+			count: 6
+			path: tests/ContainerTest.php
+
+		-
+			rawMessage: 'Call to static method PHPUnit\Framework\Assert::assertFalse() with true will always evaluate to false.'
+			identifier: staticMethod.impossibleType
 			count: 1
-			path: src/SettingsContainerAbstract.php
+			path: tests/ContainerTest.php
 
 		-
-			rawMessage: 'Call to an undefined method ReflectionProperty::getRawValue().'
-			identifier: method.notFound
-			count: 2
-			path: src/SettingsContainerAbstract.php
+			rawMessage: 'Call to static method PHPUnit\Framework\Assert::assertFalse() with true will always evaluate to true.'
+			identifier: staticMethod.alreadyNarrowedType
+			count: 1
+			path: tests/ContainerTest.php
+
+		-
+			rawMessage: 'Call to static method PHPUnit\Framework\Assert::assertNull() with string will always evaluate to false.'
+			identifier: staticMethod.impossibleType
+			count: 3
+			path: tests/ContainerTest.php
 
 		-
-			rawMessage: 'Call to an undefined method ReflectionProperty::hasHook().'
-			identifier: method.notFound
+			rawMessage: 'Call to static method PHPUnit\Framework\Assert::assertTrue() with true will always evaluate to true.'
+			identifier: staticMethod.alreadyNarrowedType
+			count: 1
+			path: tests/ContainerTest.php
+
+		-
+			rawMessage: 'Property chillerlan\SettingsTest\TestContainer::$test1 (string) in isset() is not nullable.'
+			identifier: isset.property
 			count: 2
-			path: src/SettingsContainerAbstract.php
+			path: tests/ContainerTest.php
+
+		-
+			rawMessage: 'Property chillerlan\SettingsTest\TestContainer::$test3 (string) in isset() is not nullable.'
+			identifier: isset.property
+			count: 1
+			path: tests/ContainerTest.php
+
+		-
+			rawMessage: Access to protected property chillerlan\SettingsTest\PropertyHooksContainer::$test1.
+			identifier: property.protected
+			count: 4
+			path: tests/PropertyHooksTest.php
+
+		-
+			rawMessage: Access to protected property chillerlan\SettingsTest\PropertyHooksContainer::$test2.
+			identifier: property.protected
+			count: 4
+			path: tests/PropertyHooksTest.php
+
+		-
+			rawMessage: Access to protected property chillerlan\SettingsTest\PropertyHooksContainer::$test3.
+			identifier: property.protected
+			count: 5
+			path: tests/PropertyHooksTest.php
+
+		-
+			rawMessage: Access to protected property chillerlan\SettingsTest\PropertyHooksContainer::$test4.
+			identifier: property.protected
+			count: 5
+			path: tests/PropertyHooksTest.php
 
 		-
-			rawMessage: 'Call to an undefined method ReflectionProperty::setRawValue().'
-			identifier: method.notFound
+			rawMessage: 'Property chillerlan\SettingsTest\TestContainer::$test3 is never read, only written.'
+			identifier: property.onlyWritten
 			count: 1
-			path: src/SettingsContainerAbstract.php
+			path: tests/TestContainer.php

phpstan.dist.neon

@@ -11,6 +11,7 @@ parameters:
 	treatPhpDocTypesAsCertain: false
 
 includes:
+	- .phpstan/ignore-by-php-version.php
 	- phpstan-baseline.neon
 	- vendor/phpstan/phpstan/conf/bleedingEdge.neon
 	- vendor/phpstan/phpstan-deprecation-rules/rules.neon