test: decrease fake loading time (siemens#260)

Author: spike-rabbit

playwright/e2e/paging.spec.ts

@@ -34,11 +34,9 @@ test.describe('paging', () => {
     test(example, async ({ si, page }) => {
       await si.visitExample(example);
 
-      await expect(page.locator('ghost-loader')).toBeVisible();
       await page.waitForSelector('datatable-row-wrapper');
       await pagerTest(page, 20);
       await page.waitForSelector('span[title="Tonya Bray"]');
-      await expect(page.locator('ghost-loader').first()).not.toBeVisible();
       await expect(page.getByRole('cell', { name: 'Ethel Price' })).not.toBeVisible();
       await si.runVisualAndA11yTests('novirtualization');
     });
@@ -50,17 +48,11 @@ test.describe('paging', () => {
     test(example, async ({ si, page }) => {
       await si.visitExample(example);
 
-      await expect(page.locator('ghost-loader')).toBeVisible();
-      await expect(page.locator('.bar')).toBeVisible();
-
       await page.waitForSelector('datatable-scroller');
 
       const pager = page.locator('datatable-pager');
       expect(pager).not.toBeVisible();
 
-      await expect(page.locator('ghost-loader')).not.toBeVisible();
-      await expect(page.locator('.bar')).not.toBeVisible();
-
       await si.runVisualAndA11yTests('infinite-scroll-initial', [
         {
           id: 'label',
@@ -84,9 +76,6 @@ test.describe('paging', () => {
 
       await page.mouse.wheel(0, 1000);
 
-      await expect(page.locator('ghost-loader').first()).toBeVisible();
-      await expect(page.locator('.bar')).toHaveCount(0);
-
       await si.runVisualAndA11yTests('infinite-scroll-after-scroll', [
         {
           id: 'aria-progressbar-name',
@@ -112,21 +101,12 @@ test.describe('paging', () => {
     test(example, async ({ si, page }) => {
       await si.visitExample(example);
 
-      await expect(page.locator('ghost-loader')).toBeVisible();
-      await expect(page.locator('.custom-loading-content')).toBeVisible();
-
       await page.waitForSelector('span[title="Claudine Neal"]');
 
-      await expect(page.locator('ghost-loader').first()).not.toBeVisible();
-      await expect(page.locator('.custom-loading-content')).not.toBeVisible();
-
       await si.runVisualAndA11yTests('virtual-scroll-initial');
 
       await page.getByLabel('page 4').click();
 
-      await expect(page.locator('ghost-loader').first()).toBeVisible();
-      await expect(page.locator('.custom-loading-content')).toBeVisible();
-
       await page.waitForSelector('span[title="Freda Mason"]');
 
       await si.runVisualAndA11yTests('virtual-server-side-navigate', [
@@ -151,42 +131,24 @@ test.describe('paging', () => {
       await page.getByRole('row', { name: 'Freda Mason' }).click();
       await page.mouse.wheel(0, 500);
 
-      await expect(page.locator('.custom-loading-content')).toBeVisible();
-
       await page.waitForSelector('.datatable-body-cell-label');
 
-      await expect(page.locator('.custom-loading-content')).toHaveCount(0);
-
       await si.runVisualAndA11yTests('virtual-server-side-scroll');
     });
   });
 });
 
-const pagerTest = async (
-  page: Page,
-  numberOfRows: number,
-  checkForGhostLoader: boolean = false
-) => {
+const pagerTest = async (page: Page, numberOfRows: number) => {
   const pager = page.locator('datatable-pager');
   expect(pager).toBeTruthy();
 
-  if (checkForGhostLoader) {
-    await expect(page.locator('ghost-loader').first()).toBeVisible();
-    await expect(page.locator('.custom-loading-content')).toBeVisible();
-  }
-
   const firstPageButton = page.getByLabel('go to first page').locator('..');
   const previousButton = page.getByLabel('go to previous page').locator('..');
   const nextButton = page.getByLabel('go to next page').locator('..');
   const lastButton = page.getByLabel('go to last page').locator('..');
 
   await page.waitForSelector('span[title="Ethel Price"]');
 
-  if (checkForGhostLoader) {
-    await expect(page.locator('ghost-loader').first()).not.toBeVisible();
-    await expect(page.locator('.custom-loading-content')).not.toBeVisible();
-  }
-
   const displayedRows = await page.locator('datatable-row-wrapper').all();
   expect(displayedRows).toHaveLength(numberOfRows);
 
@@ -201,18 +163,8 @@ const pagerTest = async (
 
   await lastButton.click();
 
-  if (checkForGhostLoader) {
-    await expect(page.locator('ghost-loader').first()).toBeVisible();
-    await expect(page.locator('.custom-loading-content')).toBeVisible();
-  }
-
   await page.waitForSelector('span[title="Humphrey Curtis"]');
 
-  if (checkForGhostLoader) {
-    await expect(page.locator('ghost-loader').first()).not.toBeVisible();
-    await expect(page.locator('.custom-loading-content')).not.toBeVisible();
-  }
-
   await expect(page.getByRole('cell', { name: 'Ethel Price' })).not.toBeVisible();
   await expect(page.getByRole('cell', { name: 'Beryl Rice' })).not.toBeVisible();
 

src/app/paging/mock-server-results-service.ts

@@ -18,9 +18,12 @@ export class MockServerResultsService {
    * @returns An observable containing the employee data
    */
   public getResults(page: Page): Observable<PagedData<Employee>> {
-    return of(companyData)
-      .pipe(map(d => this.getPagedData(page)))
-      .pipe(delay(1500 * Math.random()));
+    return (
+      of(companyData)
+        .pipe(map(d => this.getPagedData(page)))
+        // 1 ms in e2e requires the app to recalculate, but it is too fast for e2e to notice.
+        .pipe(delay(window.navigator.webdriver ? 1 : 1500 * Math.random()))
+    );
   }
 
   /**