Rename private[chisel3] SourceInfo$Intf to SourceInfoIntf (#5033)

This works around an issue in IntelliJ around using the macro to
materialize SourceInfo.

Keep empty SourceInfo$Intf for binary compatibility.

Author: jackkoenig

core/src/main/scala-2/chisel3/experimental/SourceInfoIntf.scala

@@ -18,6 +18,11 @@ import scala.language.experimental.macros
 import scala.reflect.macros.blackbox.Context
 import chisel3.internal.sourceinfo.SourceInfoMacro
 
-private[chisel3] trait SourceInfo$Intf { self: SourceInfo.type =>
+// Kept for binary compatibility, probably could be waived instead but just in case.
+private[chisel3] trait SourceInfo$Intf
+
+// Technically this should be called "SourceInfo$Intf" but that causes issues for IntelliJ so we
+// omit the '$'.
+private[chisel3] trait SourceInfoIntf extends SourceInfo$Intf { self: SourceInfo.type =>
   implicit def materialize: SourceInfo = macro SourceInfoMacro.generate_source_info
 }

core/src/main/scala-3/chisel3/experimental/SourceInfoIntf.scala

@@ -14,6 +14,8 @@
 
 package chisel3.experimental
 
-private[chisel3] trait SourceInfo$Intf { self: SourceInfo.type =>
+// Technically this should be called "SourceInfo$Intf" but that causes issues for IntelliJ so we
+// omit the '$'.
+private[chisel3] trait SourceInfoIntf { self: SourceInfo.type =>
   implicit def materialize: SourceInfo = UnlocatableSourceInfo
 }

core/src/main/scala/chisel3/experimental/SourceInfo.scala

@@ -50,7 +50,7 @@ case class SourceLine(filename: String, line: Int, col: Int) extends SourceInfo
   }
 }
 
-object SourceInfo extends SourceInfo$Intf {
+object SourceInfo extends SourceInfoIntf {
 
   /** Returns the best guess at the first stack frame that belongs to user code.
     */