Skip to content

Commit 9f2f19c

Browse files
committed
Code review updates
Format code
1 parent 30d797f commit 9f2f19c

File tree

9 files changed

+9
-11
lines changed

9 files changed

+9
-11
lines changed

core/src/main/scala-2/chisel3/experimental/dataview/ChiselSubtypeOf.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import scala.reflect.macros.blackbox.Context
2727
*/
2828
sealed trait ChiselSubtypeOf[A, B]
2929

30-
3130
// return an empty tree here instead of a quasiquote for scala3 compatibility
3231
object ChiselSubtypeOf {
3332
// TODO return an empty tree here instead of a quasiquote for scala3 compatibility

core/src/main/scala-2/chisel3/experimental/hierarchy/core/Hierarchy.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ import _root_.firrtl.annotations.IsModule
77
import scala.reflect.runtime.universe.TypeTag
88

99
trait Hierarchy[+A] extends HierarchyImpl[A] {
10-
/** Determine whether underlying proto is of type provided.
10+
11+
/** Determine whether underlying proto is of type provided.
1112
*
1213
* @note IMPORTANT: this function requires summoning a TypeTag[B], which will fail if B is an inner class.
1314
* @note IMPORTANT: this function IGNORES type parameters, akin to normal type erasure.

core/src/main/scala-3/chisel3/Aggregate.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,7 @@ sealed class Vec[T <: Data] private[chisel3] (gen: => T, length: Int)
5252

5353
override def toString: String = super[VecImpl].toString
5454

55-
def apply(p: UInt)(using sourceInfo: SourceInfo): T = do_apply(p)
56-
def do_apply(p: UInt)(using sourceInfo: SourceInfo): T = _applyImpl(p)
55+
def apply(p: UInt)(using sourceInfo: SourceInfo): T = _applyImpl(p)
5756

5857
/** A reduce operation in a tree like structure instead of sequentially
5958
* @example An adder tree

core/src/main/scala-3/chisel3/Disable.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
package chisel3
44

55
import chisel3.internal._
6-
import chisel3.experimental.{OpaqueType, SourceInfo}
7-
import scala.collection.immutable.ListMap
6+
import chisel3.experimental.SourceInfo
87

98
/** API for handling disabling of simulation constructs
109
*

core/src/main/scala-3/chisel3/Module.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ object Module extends ObjectModuleImpl with SourceInfoDoc {
1515
*/
1616
// TODO(adkian-sifive) the callsite here explicitly passes
1717
// sourceInfo so it cannot be a contextual parameter
18-
def apply[T <: BaseModule](bc: => T): T = _applyImpl(bc)
18+
def apply[T <: BaseModule](bc: => T): T = _applyImpl(bc)
1919
def do_apply[T <: BaseModule](bc: => T)(implicit sourceInfo: SourceInfo): T = apply(bc)
2020
}
2121

core/src/main/scala-3/chisel3/VerificationStatement.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,4 +55,3 @@ object cover extends VerifPrintMacrosDoc {
5555

5656
type SourceLineInfo = (String, Int)
5757
}
58-
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
package chisel3.experimental
22

3-
trait Markers
3+
trait Markers

core/src/main/scala-3/chisel3/experimental/hierarchy/core/Hierarchy.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import chisel3.experimental.BaseModule
66
import _root_.firrtl.annotations.IsModule
77

88
trait Hierarchy[+A] extends HierarchyImpl[A] {
9-
/** Determine whether underlying proto is of type provided.
9+
10+
/** Determine whether underlying proto is of type provided.
1011
*
1112
* @note IMPORTANT: this function requires summoning a TypeTag[B], which will fail if B is an inner class.
1213
* @note IMPORTANT: this function IGNORES type parameters, akin to normal type erasure.

core/src/main/scala/chisel3/ChiselEnumImpl.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ private[chisel3] abstract class EnumTypeImpl(private[chisel3] val factory: Chise
228228
// value U is not a member of Char.
229229
// An extension method was tried,
230230
// but could not be fully constructed:
231-
//
231+
//
232232
// chisel3.fromLongToLiteral(c.toChar)
233233
// r := c.toChar.U
234234
}

0 commit comments

Comments
 (0)