Skip to content

Commit ef43571

Browse files
authored
Fix chisel-plugin artifact publishing (#4648)
* Switch back to plugin cross versions rather than normal scala cross versions. * Switch to Java 11 for publishing instead of Java 21 so that we can publish the plugin for Scala versions < 2.13.11.
1 parent 8a1f1b6 commit ef43571

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ jobs:
8383
- name: Setup Scala
8484
uses: VirtusLab/scala-cli-setup@v1
8585
with:
86-
jvm: adoptium:21
86+
jvm: temurin:11
8787
apps: sbt
8888
- name: Publish
8989
run: ./mill -i io.kipp.mill.ci.release.ReleaseModule/publishAll

CONTRIBUTING.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,20 @@ You can install it as described on the Chisel [installation instructions](https:
2929
Developers should read the Mill documentation to understand the basic commands and use.
3030

3131
The main dependencies for development are the JDK and git.
32-
Any JDK 8 or newer will work for most development, but note that developing the CIRCT Panama bindings requires Java 21.
32+
Any JDK 11 or newer will work for most development, but note that developing the CIRCT Panama bindings requires Java 21.
3333
[Coursier](https://get-coursier.io)'s command-line is useful for hot swapping JDKs.
34-
For example:
34+
For example, the following swap the JDK in your shell to the latest release of GraalVM Java 21:
3535

3636
```sh
3737
eval $(cs java --jvm graalvm-java21 --env)
3838
```
3939

40-
This will swap the JDK in your shell to the latest release of GraalVM Java 21.
40+
While the CIRCT Panama bindings require Java 21, publishing the Chisel plugin for versions < 2.13.11 requires Java 11.
41+
To switch the JDK in your shell to the latest patch release of Temurin Java 11:
42+
43+
```sh
44+
eval $(cs java --jvm temurin:11 --env)
45+
```
4146

4247
### Useful commands
4348

plugin/package.mill

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import $file.release
1010

1111
object `package` extends RootModule {
1212
// https://github.com/com-lihaoyi/mill/issues/3693
13-
object cross extends Cross[Plugin](v.scalaCrossVersions)
13+
object cross extends Cross[Plugin](v.pluginScalaCrossVersions)
1414
}
1515

1616
trait Plugin extends CrossSbtModule with ScalafmtModule with release.ChiselPublishModule {

0 commit comments

Comments
 (0)