Assume lat/lon/alt = 0 means no GPS location is available.

As some gateways leave these fields blank (0), this would constantly
overwrite a manual set gateway location in LoRa Server.

Closes #126.

Author: brocaar

internal/backend/semtechudp/backend_test.go

@@ -208,17 +208,17 @@ func (ts *BackendTestSuite) TestPushData() {
 		UplinkFrames  []gw.UplinkFrame
 	}{
 		{
-			Name: "stats",
+			Name: "stats with location",
 			GatewayPacket: packets.PushDataPacket{
 				ProtocolVersion: packets.ProtocolVersion2,
 				RandomToken:     1234,
 				GatewayMAC:      [8]byte{1, 2, 3, 4, 5, 6, 7, 8},
 				Payload: packets.PushDataPayload{
 					Stat: &packets.Stat{
 						Time: packets.ExpandedTime(now.UTC()),
-						Lati: &latitude,
-						Long: &longitude,
-						Alti: &altitude,
+						Lati: latitude,
+						Long: longitude,
+						Alti: altitude,
 						RXNb: 1,
 						RXOK: 2,
 						RXFW: 3,
@@ -243,6 +243,33 @@ func (ts *BackendTestSuite) TestPushData() {
 				TxPacketsEmitted:    5,
 			},
 		},
+		{
+			Name: "stats without location",
+			GatewayPacket: packets.PushDataPacket{
+				ProtocolVersion: packets.ProtocolVersion2,
+				RandomToken:     1234,
+				GatewayMAC:      [8]byte{1, 2, 3, 4, 5, 6, 7, 8},
+				Payload: packets.PushDataPayload{
+					Stat: &packets.Stat{
+						Time: packets.ExpandedTime(now.UTC()),
+						RXNb: 1,
+						RXOK: 2,
+						RXFW: 3,
+						ACKR: 33.3,
+						DWNb: 4,
+						TXNb: 5,
+					},
+				},
+			},
+			Stats: &gw.GatewayStats{
+				GatewayId:           []byte{1, 2, 3, 4, 5, 6, 7, 8},
+				Time:                nowPB,
+				RxPacketsReceived:   1,
+				RxPacketsReceivedOk: 2,
+				TxPacketsReceived:   4,
+				TxPacketsEmitted:    5,
+			},
+		},
 		{
 			Name: "rxpk",
 			GatewayPacket: packets.PushDataPacket{

internal/backend/semtechudp/packets/push_data.go

@@ -66,11 +66,11 @@ func (p PushDataPacket) GetGatewayStats() (*gw.GatewayStats, error) {
 	stats.Time = ts
 
 	// location
-	if p.Payload.Stat.Lati != nil && p.Payload.Stat.Long != nil && p.Payload.Stat.Alti != nil {
+	if p.Payload.Stat.Lati != 0 && p.Payload.Stat.Long != 0 && p.Payload.Stat.Alti != 0 {
 		stats.Location = &common.Location{
-			Latitude:  *p.Payload.Stat.Lati,
-			Longitude: *p.Payload.Stat.Long,
-			Altitude:  float64(*p.Payload.Stat.Alti),
+			Latitude:  p.Payload.Stat.Lati,
+			Longitude: p.Payload.Stat.Long,
+			Altitude:  float64(p.Payload.Stat.Alti),
 			Source:    common.LocationSource_GPS,
 		}
 	}
@@ -241,9 +241,9 @@ type PushDataPayload struct {
 // Stat contains the status of the gateway.
 type Stat struct {
 	Time ExpandedTime `json:"time"` // UTC 'system' time of the gateway, ISO 8601 'expanded' format (e.g 2014-01-12 08:59:28 GMT)
-	Lati *float64     `json:"lati"` // GPS latitude of the gateway in degree (float, N is +)
-	Long *float64     `json:"long"` // GPS latitude of the gateway in degree (float, E is +)
-	Alti *int32       `json:"alti"` // GPS altitude of the gateway in meter RX (integer)
+	Lati float64      `json:"lati"` // GPS latitude of the gateway in degree (float, N is +)
+	Long float64      `json:"long"` // GPS latitude of the gateway in degree (float, E is +)
+	Alti int32        `json:"alti"` // GPS altitude of the gateway in meter RX (integer)
 	RXNb uint32       `json:"rxnb"` // Number of radio packets received (unsigned integer)
 	RXOK uint32       `json:"rxok"` // Number of radio packets received with a valid PHY CRC
 	RXFW uint32       `json:"rxfw"` // Number of radio packets forwarded (unsigned integer)

internal/backend/semtechudp/packets/push_data_test.go

@@ -74,9 +74,9 @@ func TestGetGatewayStats(t *testing.T) {
 				Payload: PushDataPayload{
 					Stat: &Stat{
 						Time: ecNow,
-						Long: &long,
-						Lati: &lat,
-						Alti: &alti,
+						Long: long,
+						Lati: lat,
+						Alti: alti,
 						RXNb: 1,
 						RXOK: 2,
 						RXFW: 3,