Fix cargo clippy feedback.

Author: brocaar

src/backend/semtech_udp/structs.rs

@@ -677,11 +677,10 @@ impl PullResp {
                             timestamp.copy_from_slice(&tx_info.context[0..4]);
                             let mut timestamp = u32::from_be_bytes(timestamp);
 
-                            let delay = v
+                            let delay = *v
                                 .delay
                                 .as_ref()
-                                .ok_or_else(|| anyhow!("delay is missing"))?
-                                .clone();
+                                .ok_or_else(|| anyhow!("delay is missing"))?;
                             let delay: Duration = delay.try_into()?;
                             timestamp += delay.as_micros() as u32;
                             Some(timestamp)
@@ -690,11 +689,10 @@ impl PullResp {
                     },
                     tmms: match timing_params {
                         gw::timing::Parameters::GpsEpoch(v) => {
-                            let gps_time = v
+                            let gps_time = *v
                                 .time_since_gps_epoch
                                 .as_ref()
-                                .ok_or_else(|| anyhow!("time_since_gps_epoch is missing"))?
-                                .clone();
+                                .ok_or_else(|| anyhow!("time_since_gps_epoch is missing"))?;
                             let gps_time: Duration = gps_time.try_into()?;
                             Some(gps_time.as_millis() as u64)
                         }

src/commands.rs

@@ -119,7 +119,7 @@ mod test {
 
         tokio::time::sleep(tokio::time::Duration::from_millis(100)).await;
 
-        assert_eq!(false, fs::exists(&temp_file).unwrap());
+        assert!(!fs::exists(&temp_file).unwrap());
     }
 
     #[tokio::test]

tests/concentratord_test.rs

@@ -50,12 +50,10 @@ async fn end_to_end() {
     tokio::spawn({
         async move {
             loop {
-                match eventloop.poll().await {
-                    Ok(v) => match v {
-                        Event::Incoming(Incoming::Publish(p)) => mqtt_tx.send(p).await.unwrap(),
-                        _ => {}
-                    },
-                    Err(_) => {}
+                if let Ok(v) = eventloop.poll().await {
+                    if let Event::Incoming(Incoming::Publish(p)) = v {
+                        mqtt_tx.send(p).await.unwrap()
+                    }
                 }
             }
         }

tests/semtech_udp_test.rs

@@ -56,12 +56,10 @@ async fn end_to_end() {
     tokio::spawn({
         async move {
             loop {
-                match eventloop.poll().await {
-                    Ok(v) => match v {
-                        Event::Incoming(Incoming::Publish(p)) => mqtt_tx.send(p).await.unwrap(),
-                        _ => {}
-                    },
-                    Err(_) => {}
+                if let Ok(v) = eventloop.poll().await {
+                    if let Event::Incoming(Incoming::Publish(p)) = v {
+                        mqtt_tx.send(p).await.unwrap()
+                    }
                 }
             }
         }
@@ -139,7 +137,7 @@ async fn end_to_end() {
         .unwrap()
         .with_timezone(&Utc);
     let mut b = vec![2, 0, 1, 0, 1, 2, 3, 4, 5, 6, 7, 8];
-    b.extend_from_slice(&mut pl_b.as_bytes());
+    b.extend_from_slice(pl_b.as_bytes());
     socket.send(&b).await.unwrap();
 
     // PUSH_ACK
@@ -171,7 +169,7 @@ async fn end_to_end() {
             }),
             rx_info: Some(gw::UplinkRxInfo {
                 gateway_id: "0102030405060708".into(),
-                gw_time: Some(pbjson_types::Timestamp::from(ts.clone())),
+                gw_time: Some(pbjson_types::Timestamp::from(ts)),
                 rssi: -35,
                 snr: 5.1,
                 channel: 2,
@@ -272,7 +270,7 @@ async fn end_to_end() {
             }
         }"#;
     let mut b = vec![2, 0, 1, 0, 1, 2, 3, 4, 5, 6, 7, 8];
-    b.extend_from_slice(&mut pl_b.as_bytes());
+    b.extend_from_slice(pl_b.as_bytes());
     socket.send(&b).await.unwrap();
 
     // PUSH_ACK