Merge pull request #2 from chiru-labs/tea/allow-empty-param

Allow empty arg to be passed to getPublicKeysFromScan

Author: ethtea

README.md

@@ -57,6 +57,8 @@ This package exposes 2 functions for each chip manufacturer:
 
 ### `getPublicKeysFromScan`
 
+This function takes in a single object as the argument with the following parameters:
+
 | Parameter | Type | Description | Required |
 | ------------- | ------------- | ------------- | ------------- |
 | rpId | string | string representing the domain the scan is being called on. For example a workflow hosted on azuki.com would pass in `azuki.com`. Defaults to `URL.hostname` | No |
@@ -77,6 +79,8 @@ Promise<{
 
 ### `getSignatureFromScan`
 
+This function takes in a single object as the argument with the following parameters:
+
 | Parameter | Type | Description | Required |
 | ------------- | ------------- | ------------- | ------------- |
 | rpId | string | string representing the domain the scan is being called on. For example a workflow hosted on azuki.com would pass in `azuki.com`. Defaults to `URL.hostname` | No |

package.json

@@ -1,6 +1,6 @@
 {
   "name": "pbt-chip-client",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "description": "Javascript library to make it easy to integrate with PBT for browsers",
   "scripts": {
     "pre-commit": "lint-staged",

src/kong/index.ts

@@ -234,7 +234,9 @@ export const getSignatureFromScan = async ({
   throw new Error("Error in signing, try again.");
 };
 
-export const getPublicKeysFromScan = async ({ rpId }: { rpId?: string }) => {
+export const getPublicKeysFromScan = async ({
+  rpId,
+}: { rpId?: string } = {}) => {
   if (!IS_BROWSER) {
     console.warn("This function is only available in a browser environment.");
 

test/kong/index.test.ts

@@ -55,4 +55,19 @@ describe("Kong chip", () => {
       );
     }
   });
+
+  it("getPublicKeysFromScan without explicit rpId", async () => {
+    const result = await getPublicKeysFromScan();
+
+    if (result) {
+      const { primaryPublicKeyHash, primaryPublicKeyRaw } = result;
+
+      expect(primaryPublicKeyHash).toEqual(
+        "0x844821a2bad46a9ed8f65761debc79af0c7f0cf4af0a4f81e97a12afe0affb0d"
+      );
+      expect(primaryPublicKeyRaw).toEqual(
+        "786463333238333762323161626438396561343133616333646132303563343531663235346233363162623438353134"
+      );
+    }
+  });
 });