feat: split lua into own files (#619)

* add

* Delete test.py

* feat: split lua codes into own file

Author: baseplate-admin

src/backend/app/guards/rate_limit.py

@@ -4,25 +4,7 @@
 from starlette.requests import HTTPConnection
 
 from app.deps import RedisDep
-
-LUA_RATELIMIT = """
-local key = KEYS[1]
-local now = tonumber(ARGV[1])
-local window = tonumber(ARGV[2])
-local limit = tonumber(ARGV[3])
-local clear_before = now - window
-
-redis.call('ZREMRANGEBYSCORE', key, 0, clear_before)
-local amount = redis.call('ZCARD', key)
-
-if amount < limit then
-    redis.call('ZADD', key, now, now)
-    redis.call('EXPIRE', key, window)
-    return 0
-else
-    return 1
-end
-"""
+from app.lua import rate_limit
 
 
 async def rate_limiter_guard(request: HTTPConnection, redis_client: RedisDep):
@@ -41,7 +23,7 @@ async def rate_limiter_guard(request: HTTPConnection, redis_client: RedisDep):
         key = f"rl:{user_id}:{endpoint.__name__}:{window}"
 
         is_limited = await redis_client.eval(
-            LUA_RATELIMIT, 1, key, str(now), str(window), str(limit)
+            rate_limit.code, 1, key, str(now), str(window), str(limit)
         )  # type: ignore[misc]
 
         if is_limited:

src/backend/app/lua/__init__.py

@@ -0,0 +1,34 @@
+from pathlib import Path
+from typing import Final
+
+BASE_DIR: Final[Path] = Path(__file__).parent
+
+
+class LuaModule:
+    """Typed representation of a loaded Lua file."""
+
+    __slots__ = ("__file__", "code")
+
+    def __init__(self, file: Path, code: str) -> None:
+        self.__file__: str = str(file)
+        self.code: str = code
+
+    def __repr__(self) -> str:
+        return f"<LuaModule file={self.__file__!r}>"
+
+
+def _load_lua_file(path: Path) -> LuaModule:
+    return LuaModule(path, path.read_text(encoding="utf-8"))
+
+
+# Load modules and export to globals
+_modules: dict[str, LuaModule] = {
+    file.stem: _load_lua_file(file) for file in BASE_DIR.glob("*.lua")
+}
+
+globals().update(_modules)
+
+
+def get(name: str) -> LuaModule:
+    """Type-safe access to Lua modules."""
+    return _modules[name]

src/backend/app/lua/__init__.pyi

@@ -0,0 +1,10 @@
+class LuaModule:
+    __file__: str
+    code: str
+
+json_remove_file_by_key: LuaModule
+json_remove_upload_by_key: LuaModule
+json_update_uploaded_bytes_by_key: LuaModule
+rate_limit: LuaModule
+
+__all__: list[str]

src/backend/app/lua/json_remove_file_by_key.lua

@@ -0,0 +1,12 @@
+local raw = redis.call('JSON.GET', KEYS[1], '$.files')
+if not raw then return nil end
+local outer = cjson.decode(raw)
+local files = outer[1]
+for i, f in ipairs(files) do
+    if f['key'] == ARGV[1] then
+        local removed = cjson.encode(f)
+        redis.call('JSON.DEL', KEYS[1], '$.files[' .. (i-1) .. ']')
+        return removed
+    end
+end
+return nil

src/backend/app/lua/json_remove_upload_by_key.lua

@@ -0,0 +1,11 @@
+local raw = redis.call('JSON.GET', KEYS[1], '$.active_uploads')
+if not raw then return nil end
+local outer = cjson.decode(raw)
+local uploads = outer[1]
+for i, u in ipairs(uploads) do
+    if u['upload_key'] == ARGV[1] then
+        redis.call('JSON.DEL', KEYS[1], '$.active_uploads[' .. (i-1) .. ']')
+        return 1
+    end
+end
+return nil

src/backend/app/lua/json_update_uploaded_bytes_by_key.lua

@@ -0,0 +1,11 @@
+local raw = redis.call('JSON.GET', KEYS[1], '$.active_uploads')
+if not raw then return nil end
+local outer = cjson.decode(raw)
+local uploads = outer[1]
+for i, u in ipairs(uploads) do
+    if u['upload_key'] == ARGV[1] then
+        redis.call('JSON.SET', KEYS[1], '$.active_uploads[' .. (i-1) .. '].uploaded_bytes', ARGV[2])
+        return 1
+    end
+end
+return nil

src/backend/app/lua/rate_limit.lua

@@ -0,0 +1,16 @@
+local key = KEYS[1]
+local now = tonumber(ARGV[1])
+local window = tonumber(ARGV[2])
+local limit = tonumber(ARGV[3])
+local clear_before = now - window
+
+redis.call('ZREMRANGEBYSCORE', key, 0, clear_before)
+local amount = redis.call('ZCARD', key)
+
+if amount < limit then
+    redis.call('ZADD', key, now, now)
+    redis.call('EXPIRE', key, window)
+    return 0
+else
+    return 1
+end

src/backend/app/states/room.py

@@ -4,6 +4,11 @@
 import uuid
 from datetime import datetime, timedelta, timezone
 
+from app.lua import (
+    json_remove_file_by_key,
+    json_remove_upload_by_key,
+    json_update_uploaded_bytes_by_key,
+)
 from app.schemas.reverse import (
     ActiveUpload,
     AddHostOut,
@@ -199,21 +204,7 @@ async def remove_file(cls, room_id: str, file_key: str) -> RoomFileEntry | None:
         """
         key = _room_key(room_id)
         client = cls._client()
-        script = """
-        local raw = redis.call('JSON.GET', KEYS[1], '$.files')
-        if not raw then return nil end
-        local outer = cjson.decode(raw)
-        local files = outer[1]
-        for i, f in ipairs(files) do
-            if f['key'] == ARGV[1] then
-                local removed = cjson.encode(f)
-                redis.call('JSON.DEL', KEYS[1], '$.files[' .. (i-1) .. ']')
-                return removed
-            end
-        end
-        return nil
-        """
-        result = await client.eval(script, 1, key, file_key)  # type: ignore[misc]
+        result = await client.eval(json_remove_file_by_key.code, 1, key, file_key)  # type: ignore[misc]
         if result is None:
             return None
 
@@ -260,38 +251,14 @@ async def update_active_upload(
         cls, room_id: str, upload_key: str, uploaded_bytes: int
     ) -> None:
         key = _room_key(room_id)
-        script = """
-        local raw = redis.call('JSON.GET', KEYS[1], '$.active_uploads')
-        if not raw then return nil end
-        local outer = cjson.decode(raw)
-        local uploads = outer[1]
-        for i, u in ipairs(uploads) do
-            if u['upload_key'] == ARGV[1] then
-                redis.call('JSON.SET', KEYS[1], '$.active_uploads[' .. (i-1) .. '].uploaded_bytes', ARGV[2])
-                return 1
-            end
-        end
-        return nil
-        """
-        await cls._client().eval(script, 1, key, upload_key, uploaded_bytes)  # type:ignore[misc]
+        await cls._client().eval(
+            json_update_uploaded_bytes_by_key.code, 1, key, upload_key, uploaded_bytes
+        )  # type:ignore[misc]
 
     @classmethod
     async def remove_active_upload(cls, room_id: str, upload_key: str) -> None:
         key = _room_key(room_id)
-        script = """
-        local raw = redis.call('JSON.GET', KEYS[1], '$.active_uploads')
-        if not raw then return nil end
-        local outer = cjson.decode(raw)
-        local uploads = outer[1]
-        for i, u in ipairs(uploads) do
-            if u['upload_key'] == ARGV[1] then
-                redis.call('JSON.DEL', KEYS[1], '$.active_uploads[' .. (i-1) .. ']')
-                return 1
-            end
-        end
-        return nil
-        """
-        await cls._client().eval(script, 1, key, upload_key)  # type:ignore[misc]
+        await cls._client().eval(json_remove_upload_by_key.code, 1, key, upload_key)  # type:ignore[misc]
 
     @classmethod
     async def client_online(cls, room_id: str, client_id: str, is_host: bool) -> None: