fix lint and revert jdk changes

Author: chitralverma

.github/workflows/pr-lint.yml

@@ -19,7 +19,7 @@ jobs:
       - name: Set up JDK
         uses: actions/setup-java@v4
         with:
-          java-version: "11"
+          java-version: "8"
           distribution: 'zulu'
           cache: 'sbt'
 

.github/workflows/release.yml

@@ -23,7 +23,7 @@ jobs:
       - name: Set up JDK
         uses: actions/setup-java@v4
         with:
-          java-version: "11"
+          java-version: "8"
           distribution: "zulu"
           cache: "sbt"
 
@@ -89,7 +89,7 @@ jobs:
       - name: Set up JDK
         uses: actions/setup-java@v4
         with:
-          java-version: "11"
+          java-version: "8"
           distribution: "zulu"
           cache: "sbt"
 
@@ -125,7 +125,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        java: ["11", "17", "21"]
+        java: ["8", "11", "17", "21"]
         os: ["ubuntu-latest", "windows-latest", "macos-latest"]
 
     steps:
@@ -172,7 +172,7 @@ jobs:
       - name: Set up JDK
         uses: actions/setup-java@v4
         with:
-          java-version: "11"
+          java-version: "8"
           distribution: "zulu"
           cache: "sbt"
 

README.md

@@ -39,7 +39,7 @@ The project is mainly divided into 2 submodules,
 
 ## Compatibility
 
-- JDK version `>=11`
+- JDK version `>=8`
 - Scala version `2.12.x`, `2.13.x` and `3.3.x`. Default is `2.13.x`
 - Rust version `>=1.58`
 
@@ -49,7 +49,7 @@ The project is mainly divided into 2 submodules,
 
 The following tooling is required to start building `scala-polars`,
 
-- JDK 11+ ([OpenJDK](https://openjdk.org/projects/jdk/)
+- JDK 8+ ([OpenJDK](https://openjdk.org/projects/jdk/)
   or [Oracle Java SE](https://www.oracle.com/java/technologies/javase/))
 - [Rust](https://www.rust-lang.org/tools/install) (cargo, rustc etc.)
 - [sbt](https://www.scala-sbt.org/index.html)

native/src/internal_jni/expr/literal.rs

@@ -69,8 +69,7 @@ pub fn fromDate(mut env: JNIEnv, _: JClass, value: JString) -> jlong {
 
     let date = NaiveDate::parse_from_str(string_value.as_str(), "%Y-%m-%d")
         .context(format!(
-            "Failed to parse value `{}` as date with format `%Y-%m-%d`",
-            string_value
+            "Failed to parse value `{string_value}` as date with format `%Y-%m-%d`"
         ))
         .unwrap_or_throw(&mut env);
 
@@ -88,8 +87,7 @@ pub fn fromTime(mut env: JNIEnv, _: JClass, value: JString) -> jlong {
 
     let time = NaiveTime::parse_from_str(string_value.as_str(), "%H:%M:%S%.f")
         .context(format!(
-            "Failed to parse value `{}` as time with format `%H:%M:%S%.f`",
-            string_value
+            "Failed to parse value `{string_value}` as time with format `%H:%M:%S%.f`"
         ))
         .unwrap_or_throw(&mut env);
 
@@ -110,8 +108,7 @@ pub fn fromDateTime(mut env: JNIEnv, _: JClass, value: JString) -> jlong {
 
     let datetime = NaiveDateTime::parse_from_str(string_value.as_str(), "%FT%T%.f")
         .context(format!(
-            "Failed to parse value `{}` as datetime with format `%FT%T%.f`",
-            string_value
+            "Failed to parse value `{string_value}` as datetime with format `%FT%T%.f`"
         ))
         .unwrap_or_throw(&mut env);
 

native/src/internal_jni/frame.rs

@@ -26,7 +26,7 @@ pub unsafe fn schemaString(mut env: JNIEnv, _: JClass, df_ptr: *mut DataFrame) -
 #[jni_fn("org.polars.scala.polars.internal.jni.data_frame$")]
 pub unsafe fn show(_: JNIEnv, _: JClass, df_ptr: *mut DataFrame) {
     let df = &mut *df_ptr;
-    println!("{:?}", df)
+    println!("{df:?}")
 }
 
 #[jni_fn("org.polars.scala.polars.internal.jni.data_frame$")]

native/src/internal_jni/row.rs

@@ -91,7 +91,7 @@ impl<'a> RowIterator<'a> {
         }
     }
 
-    pub fn advance(&mut self) -> Option<Vec<AnyValue>> {
+    pub fn advance(&mut self) -> Option<Vec<AnyValue<'_>>> {
         if self.start < self.end {
             let start_index = self.start * self.width;
             let end_index = (self.start + 1) * self.width;

native/src/internal_jni/series.rs

@@ -137,8 +137,7 @@ pub unsafe fn new_date_series(
         .map(|s| {
             let lit = s.as_str();
             NaiveDate::parse_from_str(lit, "%Y-%m-%d").context(format!(
-                "Failed to parse value `{}` as date with format `%Y-%m-%d`",
-                lit
+                "Failed to parse value `{lit}` as date with format `%Y-%m-%d`"
             ))
         })
         .collect::<Result<Vec<NaiveDate>, Error>>()
@@ -174,8 +173,7 @@ pub unsafe fn new_time_series(
         .map(|s| {
             let lit = s.as_str();
             NaiveTime::parse_from_str(lit, "%H:%M:%S%.f").context(format!(
-                "Failed to parse value `{}` as time with format `%H:%M:%S.f`",
-                lit
+                "Failed to parse value `{lit}` as time with format `%H:%M:%S.f`"
             ))
         })
         .collect::<Result<Vec<NaiveTime>, Error>>()
@@ -211,8 +209,7 @@ pub unsafe fn new_datetime_series(
         .map(|s| {
             let lit = s.as_str();
             NaiveDateTime::parse_from_str(lit, "%FT%T%.f").context(format!(
-                "Failed to parse value `{}` as datetime with format `%FT%T%.f`",
-                lit
+                "Failed to parse value `{lit}` as datetime with format `%FT%T%.f`"
             ))
         })
         .collect::<Result<Vec<NaiveDateTime>, Error>>()
@@ -282,5 +279,5 @@ pub unsafe fn new_struct_series(
 #[jni_fn("org.polars.scala.polars.internal.jni.series$")]
 pub unsafe fn show(_: JNIEnv, _: JClass, series_ptr: *mut Series) {
     let series = &*series_ptr;
-    println!("{:?}", series)
+    println!("{series:?}")
 }

project/GeneralSettings.scala

@@ -39,8 +39,8 @@ object GeneralSettings {
       "-language:postfixOps",
       "-unchecked",
       "-Xfatal-warnings"
-    ) ++ (if (priorTo213(scalaVersion.value)) Seq("-target:jvm-11")
-          else Seq("-release", "11")),
+    ) ++ (if (priorTo213(scalaVersion.value)) Seq("-target:jvm-1.8")
+          else Seq("-release", "8")),
     fork := true,
     turbo := true,
     assembly / assemblyMergeStrategy := {

project/plugins.sbt

@@ -1,6 +1,6 @@
 addSbtPlugin("com.github.sbt" % "sbt-jni" % "1.7.0")
 
-addSbtPlugin("com.github.sbt" % "sbt-java-formatter" % "0.10.0")
+addSbtPlugin("com.github.sbt" % "sbt-java-formatter" % "0.9.0")
 
 addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.4")