Skip to content

Commit bb22d16

Browse files
committed
rename manager to start
1 parent f2bb6b9 commit bb22d16

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

Sources/FoundationEssentials/ProgressManager/Subprogress.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public struct Subprogress: ~Copyable, Sendable {
3535
/// Instantiates a ProgressManager which is a child to the parent from which `self` is returned.
3636
/// - Parameter totalCount: Total count of returned child `ProgressManager` instance.
3737
/// - Returns: A `ProgressManager` instance.
38-
public consuming func manager(totalCount: Int?) -> ProgressManager {
38+
public consuming func start(totalCount: Int?) -> ProgressManager {
3939
isInitializedToProgressReporter = true
4040

4141
let childManager = ProgressManager(total: totalCount, ghostReporter: ghostReporter, interopObservation: observation)

Tests/FoundationEssentialsTests/ProgressManager/ProgressManagerTests.swift

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import XCTest
2121
class TestProgressManager: XCTestCase {
2222
/// MARK: Helper methods that report progress
2323
func doBasicOperationV1(reportTo subprogress: consuming Subprogress) async {
24-
let manager = subprogress.manager(totalCount: 8)
24+
let manager = subprogress.start(totalCount: 8)
2525
for i in 1...8 {
2626
manager.complete(count: 1)
2727
XCTAssertEqual(manager.completedCount, i)
@@ -30,7 +30,7 @@ class TestProgressManager: XCTestCase {
3030
}
3131

3232
func doBasicOperationV2(reportTo subprogress: consuming Subprogress) async {
33-
let manager = subprogress.manager(totalCount: 7)
33+
let manager = subprogress.start(totalCount: 7)
3434
for i in 1...7 {
3535
manager.complete(count: 1)
3636
XCTAssertEqual(manager.completedCount, i)
@@ -39,7 +39,7 @@ class TestProgressManager: XCTestCase {
3939
}
4040

4141
func doBasicOperationV3(reportTo subprogress: consuming Subprogress) async {
42-
let manager = subprogress.manager(totalCount: 11)
42+
let manager = subprogress.start(totalCount: 11)
4343
for i in 1...11 {
4444
manager.complete(count: 1)
4545
XCTAssertEqual(manager.completedCount, i)
@@ -95,7 +95,7 @@ class TestProgressManager: XCTestCase {
9595
XCTAssertFalse(overall.isFinished)
9696

9797
let progress1 = overall.subprogress(assigningCount: 2)
98-
let manager1 = progress1.manager(totalCount: 1)
98+
let manager1 = progress1.start(totalCount: 1)
9999

100100
manager1.complete(count: 1)
101101
XCTAssertEqual(manager1.totalCount, 1)
@@ -125,7 +125,7 @@ class TestProgressManager: XCTestCase {
125125
overall.complete(count: 5)
126126

127127
let progress1 = overall.subprogress(assigningCount: 8)
128-
let manager1 = progress1.manager(totalCount: 1)
128+
let manager1 = progress1.start(totalCount: 1)
129129
manager1.complete(count: 1)
130130

131131
XCTAssertEqual(overall.completedCount, 13)
@@ -181,11 +181,11 @@ class TestProgressManager: XCTestCase {
181181
let overall = ProgressManager(totalCount: 2)
182182

183183
let progress1 = overall.subprogress(assigningCount: 1)
184-
let manager1 = progress1.manager(totalCount: 5)
184+
let manager1 = progress1.start(totalCount: 5)
185185
manager1.complete(count: 5)
186186

187187
let progress2 = overall.subprogress(assigningCount: 1)
188-
let manager2 = progress2.manager(totalCount: 5)
188+
let manager2 = progress2.start(totalCount: 5)
189189
manager2.withProperties { properties in
190190
properties.totalFileCount = 10
191191
}
@@ -216,10 +216,10 @@ class TestProgressManager: XCTestCase {
216216
XCTAssertEqual(overall.fractionCompleted, 0.0)
217217

218218
let child1 = overall.subprogress(assigningCount: 100)
219-
let manager1 = child1.manager(totalCount: 100)
219+
let manager1 = child1.start(totalCount: 100)
220220

221221
let grandchild1 = manager1.subprogress(assigningCount: 100)
222-
let grandchildManager1 = grandchild1.manager(totalCount: 100)
222+
let grandchildManager1 = grandchild1.start(totalCount: 100)
223223

224224
XCTAssertEqual(overall.fractionCompleted, 0.0)
225225

@@ -241,16 +241,16 @@ class TestProgressManager: XCTestCase {
241241
XCTAssertEqual(overall.fractionCompleted, 0.0)
242242

243243
let child1 = overall.subprogress(assigningCount: 100)
244-
let manager1 = child1.manager(totalCount: 100)
244+
let manager1 = child1.start(totalCount: 100)
245245

246246
let grandchild1 = manager1.subprogress(assigningCount: 100)
247-
let grandchildManager1 = grandchild1.manager(totalCount: 100)
247+
let grandchildManager1 = grandchild1.start(totalCount: 100)
248248

249249
XCTAssertEqual(overall.fractionCompleted, 0.0)
250250

251251

252252
let greatGrandchild1 = grandchildManager1.subprogress(assigningCount: 100)
253-
let greatGrandchildManager1 = greatGrandchild1.manager(totalCount: 100)
253+
let greatGrandchildManager1 = greatGrandchild1.start(totalCount: 100)
254254

255255
greatGrandchildManager1.complete(count: 50)
256256
XCTAssertEqual(overall.fractionCompleted, 0.5)
@@ -268,7 +268,7 @@ class TestProgressManager: XCTestCase {
268268
/// Unit tests for propagation of type-safe metadata in ProgressManager tree.
269269
class TestProgressManagerAdditionalProperties: XCTestCase {
270270
func doFileOperation(reportTo subprogress: consuming Subprogress) async {
271-
let manager = subprogress.manager(totalCount: 100)
271+
let manager = subprogress.start(totalCount: 100)
272272
manager.withProperties { properties in
273273
properties.totalFileCount = 100
274274
}
@@ -312,7 +312,7 @@ class TestProgressManagerAdditionalProperties: XCTestCase {
312312
let overall = ProgressManager(totalCount: 2)
313313

314314
let progress1 = overall.subprogress(assigningCount: 1)
315-
let manager1 = progress1.manager(totalCount: 10)
315+
let manager1 = progress1.start(totalCount: 10)
316316
manager1.withProperties { properties in
317317
properties.totalFileCount = 10
318318
properties.completedFileCount = 0
@@ -336,15 +336,15 @@ class TestProgressManagerAdditionalProperties: XCTestCase {
336336
let overall = ProgressManager(totalCount: 2)
337337

338338
let progress1 = overall.subprogress(assigningCount: 1)
339-
let manager1 = progress1.manager(totalCount: 10)
339+
let manager1 = progress1.start(totalCount: 10)
340340

341341
manager1.withProperties { properties in
342342
properties.totalFileCount = 11
343343
properties.completedFileCount = 0
344344
}
345345

346346
let progress2 = overall.subprogress(assigningCount: 1)
347-
let manager2 = progress2.manager(totalCount: 10)
347+
let manager2 = progress2.start(totalCount: 10)
348348

349349
manager2.withProperties { properties in
350350
properties.totalFileCount = 9
@@ -377,11 +377,11 @@ class TestProgressManagerAdditionalProperties: XCTestCase {
377377
let overall = ProgressManager(totalCount: 1)
378378

379379
let progress1 = overall.subprogress(assigningCount: 1)
380-
let manager1 = progress1.manager(totalCount: 5)
380+
let manager1 = progress1.start(totalCount: 5)
381381

382382

383383
let childProgress1 = manager1.subprogress(assigningCount: 3)
384-
let childManager1 = childProgress1.manager(totalCount: nil)
384+
let childManager1 = childProgress1.start(totalCount: nil)
385385
childManager1.withProperties { properties in
386386
properties.totalFileCount += 10
387387
}
@@ -391,7 +391,7 @@ class TestProgressManagerAdditionalProperties: XCTestCase {
391391
XCTAssertEqual(preTotalFileValues, [0, 0, 10])
392392

393393
let childProgress2 = manager1.subprogress(assigningCount: 2)
394-
let childManager2 = childProgress2.manager(totalCount: nil)
394+
let childManager2 = childProgress2.start(totalCount: nil)
395395
childManager2.withProperties { properties in
396396
properties.totalFileCount += 10
397397
}
@@ -425,7 +425,7 @@ class TestProgressManagerInterop: XCTestCase {
425425
}
426426

427427
func doSomethingWithReporter(subprogress: consuming Subprogress?) async {
428-
let manager = subprogress?.manager(totalCount: 4)
428+
let manager = subprogress?.start(totalCount: 4)
429429
manager?.complete(count: 2)
430430
manager?.complete(count: 2)
431431
}
@@ -543,7 +543,7 @@ class TestProgressManagerInterop: XCTestCase {
543543
}
544544

545545
func receiveProgress(progress: consuming Subprogress) {
546-
let _ = progress.manager(totalCount: 5)
546+
let _ = progress.start(totalCount: 5)
547547
}
548548

549549
func testInteropProgressManagerParentProgressChildConsistency() async throws {

0 commit comments

Comments
 (0)