Skip to content

Commit 8d677f7

Browse files
committed
chore: update path glob pattern for e2e test execution triggers
* Added test/** directory to the glob pattern for running e2e tests * Fixed pattern for Go files from ***/*.go to **/*.go for proper glob matching * Ensures e2e tests are triggered when relevant test files are modified Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
1 parent b8674ce commit 8d677f7

File tree

4 files changed

+17
-6
lines changed

4 files changed

+17
-6
lines changed

.tekton/e2e-label.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ metadata:
88
pipelinesascode.tekton.dev/cancel-in-progress: "true"
99
pipelinesascode.tekton.dev/on-event: "pull_request"
1010
pipelinesascode.tekton.dev/on-target-branch: "main"
11-
pipelinesascode.tekton.dev/on-path-change: "[***/*.go, .github/workflows/*l]"
11+
pipelinesascode.tekton.dev/on-path-change: "[**/*.go, .github/workflows/*l, test/**]"
1212
spec:
1313
pipelineSpec:
1414
tasks:

docs/content/docs/guide/cli.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,9 @@ internet connection. In this scenario, it will set up a forwarding URL on
128128
will not prompt you unless you explicitly specify the `--force-gosmee` flag
129129
(which can be useful if you are running [OpenShift Local](https://developers.redhat.com/products/openshift-local/overview) for instance).
130130

131+
gosmee is by no means to be used in production, but it can be useful for
132+
testing.
133+
131134
{{< /details >}}
132135

133136
{{< details "tkn pac bootstrap github-app" >}}
@@ -164,7 +167,8 @@ questions if you want to configure a webhook for your provider of choice.
164167
`tkn pac delete repo` -- will delete a Pipelines-as-Code Repository definition.
165168

166169
You can specify the flag `--cascade` to optionally delete the attached secrets
167-
(ie: webhook or provider secret) to the Pipelines-as-Code Repository definition.
170+
(i.e. webhook or provider secret) to the Pipelines-as-Code Repository
171+
definition.
168172

169173
{{< /details >}}
170174

docs/content/docs/install/getting-started.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ not running on OpenShift.
6666

6767
This is not required, but considering the need to have GitHub reach our
6868
Pipelines-as-Code controller from the internet, using `gosmee` is the most
69-
straightforward way to do it.
69+
straightforward way to do it. Note that while gosmee provides let you getting
70+
started quickly, it is not intended for production use.
7071

7172
```console
7273
Pipelines-as-Code does not install an Ingress object to allow the controller to be accessed from the internet.

docs/content/docs/install/installation.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,15 @@ You can use following command to update the envs on the controller
140140

141141
## Proxy service for PAC controller
142142

143-
Pipelines-as-Code requires an externally accessible URL to receive events from Git providers.
144-
If you're developing locally (such as on kind or Minikube) or don't want to set up an ingress on your cluster,
145-
you can also use a proxy service to expose the `pipelines-as-code-controller` service and allow it to receive events.
143+
Pipelines-as-Code requires an externally accessible URL to receive events from
144+
Git providers. If you're developing locally (such as on kind or Minikube) or
145+
don't want to set up an ingress on your cluster, you can also use a proxy
146+
service to expose the `pipelines-as-code-controller` service and allow it to
147+
receive events.
148+
149+
This is useful for testing and development purposes, but not recommended for
150+
production, since gosmee and the platform running `hook.pipelinesascode.com`
151+
have no support or security guarantees.
146152

147153
### Proxying with hook.pipelinesascode.com
148154

0 commit comments

Comments
 (0)