chore: Separate CI log formatting

* Extracted log formatting logic into a reusable `output_logs`
  function in `gh-workflow-ci.sh`.
* Added a distinct step in the e2e GitHub Actions workflow to display
fmatted logs using `snazy` or a Python fallback.
* This change aimed to improve CI log visibility directly within the
  GitHub UI after log collection completed.
* Updated script command-line handling and help text to reflect the
  new function.

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

Author: chmouel

.github/workflows/e2e.yaml

@@ -165,6 +165,10 @@ jobs:
         run: |
           ./hack/gh-workflow-ci.sh collect_logs
 
+      - name: Show controllers/watcher logs with Snazy
+        run: |
+          ./hack/gh-workflow-ci output-logs
+
       - name: Upload artifacts
         if: ${{ always() }}
         uses: actions/upload-artifact@v4

hack/gh-workflow-ci.sh

@@ -91,6 +91,16 @@ run_e2e_tests() {
   make test-e2e GO_TEST_FLAGS="-run \"$(echo "${tests[*]}" | sed 's/ /|/g')\""
 }
 
+output_logs() {
+  if command -v "snazy" >/dev/null 2>&1; then
+    snazy --skip-line-regexp="^(Reconcile (succeeded|error)|Updating webhook)" /tmp/logs/pac-pods.log
+  else
+    # snazy for the poors
+    python -c "import sys,json,datetime; [print(f'• { (lambda t: datetime.datetime.fromisoformat(t.rstrip(\"Z\")).strftime(\"%H:%M:%S\") if isinstance(t,str) else datetime.datetime.fromtimestamp(t).strftime(\"%H:%M:%S\"))(json.loads(l.strip())[\"ts\"] )} {json.loads(l.strip()).get(\"msg\",\"\")}') if l.strip().startswith('{') else print(l.strip()) for l in sys.stdin]" \
+      </tmp/logs/pac-pods.log
+  fi
+}
+
 collect_logs() {
   # Read from environment variables
   local test_gitea_smee_url="${TEST_GITEA_SMEEURL}"
@@ -100,14 +110,6 @@ collect_logs() {
   # Output logs to stdout so we can see via the web interface directly
   kubectl logs -n pipelines-as-code -l app.kubernetes.io/part-of=pipelines-as-code \
     --all-containers=true --tail=1000 >/tmp/logs/pac-pods.log
-  if command -v "snazy" >/dev/null 2>&1; then
-    snazy --skip-line-regexp="^(Reconcile (succeeded|error)|Updating webhook)" /tmp/logs/pac-pods.log
-  else
-    # snazy for the poors
-    python -c "import sys,json,datetime; [print(f'• { (lambda t: datetime.datetime.fromisoformat(t.rstrip(\"Z\")).strftime(\"%H:%M:%S\") if isinstance(t,str) else datetime.datetime.fromtimestamp(t).strftime(\"%H:%M:%S\"))(json.loads(l.strip())[\"ts\"] )} {json.loads(l.strip()).get(\"msg\",\"\")}') if l.strip().startswith('{') else print(l.strip()) for l in sys.stdin]" \
-      </tmp/logs/pac-pods.log
-  fi
-
   kind export logs /tmp/logs
   [[ -d /tmp/gosmee-replay ]] && cp -a /tmp/gosmee-replay /tmp/logs/
 
@@ -168,6 +170,10 @@ help() {
   collect_logs
     Collect logs from the cluster
     Required env vars: TEST_GITEA_SMEEURL, TEST_GITHUB_SECOND_SMEE_URL
+
+  output_logs
+    Will output logs using snazzy formatting when available or otherwise through a simple
+    python formatter. This makes debugging easier from the GitHub Actions interface.
 EOF
 }
 
@@ -184,6 +190,9 @@ run_e2e_tests)
 collect_logs)
   collect_logs
   ;;
+output_logs)
+  output_logs
+  ;;
 help)
   help
   exit 0