fix: GitLab provider getting a URL on same host

Refactored the GitLab provider to correctly handle project IDs and fetch
raw files with our token. We were fetching the URL as is when there are
URLs don't work like GitHub which allows passing a token and getting a
private raw URL directly.

Jira: https://issues.redhat.com/browse/SRVKP-7357
AI-assisted-by: Google Gemini 3
Signed-off-by: Chmouel Boudjnah <[email protected]>

Author: chmouel

pkg/provider/gitlab/task.go

@@ -3,14 +3,17 @@ package gitlab
 import (
 	"context"
 	"fmt"
+	"net/http"
 	"net/url"
 	"regexp"
 
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/params/info"
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/provider"
+	gl "gitlab.com/gitlab-org/api/client-go"
 )
 
 type gitLabInfo struct {
+	Scheme      string
 	Host        string
 	GroupOrUser string
 	Repository  string
@@ -55,6 +58,7 @@ func extractGitLabInfo(gitlabURL string) (*gitLabInfo, error) {
 	}
 
 	return &gitLabInfo{
+		Scheme:      parsedURL.Scheme,
 		Host:        parsedURL.Host,
 		GroupOrUser: groupOrUser,
 		Repository:  repoName,
@@ -65,7 +69,7 @@ func extractGitLabInfo(gitlabURL string) (*gitLabInfo, error) {
 
 // GetTaskURI if we are getting a URL from the same URL where the provider is,
 // it means we can try to get the file with the provider token.
-func (v *Provider) GetTaskURI(ctx context.Context, event *info.Event, uri string) (bool, string, error) {
+func (v *Provider) GetTaskURI(_ context.Context, event *info.Event, uri string) (bool, string, error) {
 	if ret := provider.CompareHostOfURLS(uri, event.URL); !ret {
 		return false, "", nil
 	}
@@ -74,13 +78,37 @@ func (v *Provider) GetTaskURI(ctx context.Context, event *info.Event, uri string
 		return false, "", err
 	}
 
-	nEvent := info.NewEvent()
-	nEvent.Organization = extracted.GroupOrUser
-	nEvent.Repository = extracted.Repository
-	nEvent.BaseBranch = extracted.Revision
-	ret, err := v.GetFileInsideRepo(ctx, nEvent, extracted.FilePath, extracted.Revision)
+	// Use the existing client if available, otherwise create a temporary one.
+	// We avoid storing it to prevent side effects on the provider's state.
+	client := v.gitlabClient
+	if client == nil {
+		baseURL := fmt.Sprintf("%s://%s", extracted.Scheme, extracted.Host)
+		var clientErr error
+		client, clientErr = gl.NewClient(event.Provider.Token, gl.WithHTTPClient(http.DefaultClient), gl.WithBaseURL(baseURL))
+		if clientErr != nil {
+			return false, "", fmt.Errorf("failed to create gitlab client: %w", clientErr)
+		}
+	}
+
+	// Construct the project slug for the remote repository
+	projectSlug := extracted.GroupOrUser + "/" + extracted.Repository
+
+	// Get the project ID for the remote repository
+	project, _, err := client.Projects.GetProject(projectSlug, &gl.GetProjectOptions{})
 	if err != nil {
-		return false, "", err
+		return false, "", fmt.Errorf("failed to get project ID for %s: %w", projectSlug, err)
+	}
+
+	// Fetch the file from the remote repository
+	opt := &gl.GetRawFileOptions{
+		Ref: gl.Ptr(extracted.Revision),
+	}
+	file, resp, err := client.RepositoryFiles.GetRawFile(project.ID, extracted.FilePath, opt)
+	if err != nil {
+		return false, "", fmt.Errorf("failed to get file %s from remote repository: %w", extracted.FilePath, err)
+	}
+	if resp != nil && resp.StatusCode == http.StatusNotFound {
+		return false, "", nil
 	}
-	return true, ret, nil
+	return true, string(file), nil
 }

pkg/provider/gitlab/task_test.go

@@ -1,8 +1,15 @@
 package gitlab
 
 import (
+	"context"
+	"fmt"
+	"net/http"
+	"net/http/httptest"
+	"net/url"
 	"testing"
 
+	"github.com/openshift-pipelines/pipelines-as-code/pkg/params/info"
+	gl "gitlab.com/gitlab-org/api/client-go"
 	"gotest.tools/v3/assert"
 )
 
@@ -16,6 +23,7 @@ func TestExtractGitLabInfo(t *testing.T) {
 			name: "custom host",
 			url:  "https://gitlab.chmouel.com/group/subgroup/repo/-/blob/main/README.md?ref_type=heads",
 			expected: &gitLabInfo{
+				Scheme:      "https",
 				Host:        "gitlab.chmouel.com",
 				GroupOrUser: "group/subgroup",
 				Repository:  "repo",
@@ -27,6 +35,7 @@ func TestExtractGitLabInfo(t *testing.T) {
 			name: "org repo",
 			url:  "https://gitlab.com/org/repo/-/blob/main/README.md",
 			expected: &gitLabInfo{
+				Scheme:      "https",
 				Host:        "gitlab.com",
 				GroupOrUser: "org",
 				Repository:  "repo",
@@ -38,6 +47,7 @@ func TestExtractGitLabInfo(t *testing.T) {
 			name: "long group and subgroups",
 			url:  "https://gitlab.com/gitlab-com/partners/alliance/corp/sandbox/another/foo-foo/-/raw/main/hello.txt?ref_type=heads",
 			expected: &gitLabInfo{
+				Scheme:      "https",
 				Host:        "gitlab.com",
 				GroupOrUser: "gitlab-com/partners/alliance/corp/sandbox/another",
 				Repository:  "foo-foo",
@@ -55,3 +65,59 @@ func TestExtractGitLabInfo(t *testing.T) {
 		})
 	}
 }
+
+func TestGetTaskURI(t *testing.T) {
+	ctx := context.Background()
+
+	// Expected project and raw file content
+	projectID := 12345
+	projectSlug := "chmouel/dazgo"
+	repoName := "dazgo"
+	groupOrUser := "chmouel"
+	revision := "main"
+	filePath := "task.yaml"
+	expectedContent := "apiVersion: tekton.dev/v1beta1\nkind: Pipeline\nmetadata:\n  name: test-pipeline\nspec:\n  tasks:\n    - name: echo-task\n      taskSpec:\n        steps:\n          - name: echo\n            image: ubuntu\n            script: |\n              echo \"Hello from remote pipeline!\"\n"
+
+	// Set up a mock HTTP server that GetTaskURI will connect to
+	mux := http.NewServeMux()
+
+	// Mock the GetProject API call
+	mux.HandleFunc(fmt.Sprintf("/api/v4/projects/%s", gl.PathEscape(projectSlug)), func(w http.ResponseWriter, _ *http.Request) {
+		fmt.Fprintf(w, `{"id": %d, "path_with_namespace": "%s"}`, projectID, projectSlug)
+	})
+
+	// Mock the GetRawFile API call
+	mux.HandleFunc(fmt.Sprintf("/api/v4/projects/%d/repository/files/%s/raw", projectID, gl.PathEscape(filePath)), func(w http.ResponseWriter, r *http.Request) {
+		assert.Equal(t, "token", r.Header.Get("Private-Token"), "Expected Private-Token header to be 'token'")
+		assert.Equal(t, revision, r.URL.Query().Get("ref"), "Expected 'ref' query parameter to be 'main'")
+		fmt.Fprint(w, expectedContent)
+	})
+
+	// Start the test server
+	server := httptest.NewServer(mux)
+	defer server.Close()
+
+	// Create a GitLab provider (GetTaskURI creates its own client internally)
+	v := &Provider{}
+
+	// Create an info.Event with the provider token
+	// The URL must match the test server's host so GetTaskURI proceeds
+	event := info.NewEvent()
+	event.URL = server.URL
+	event.Provider = &info.Provider{
+		Token: "token",
+	}
+
+	// Parse the server URL to get the host for constructing the remote pipeline URL
+	serverURL, err := url.Parse(server.URL)
+	assert.NilError(t, err)
+
+	// The remote pipeline URL - use the test server's scheme and host
+	remotePipelineURL := fmt.Sprintf("%s://%s/%s/%s/-/raw/%s/%s", serverURL.Scheme, serverURL.Host, groupOrUser, repoName, revision, filePath)
+
+	// Call GetTaskURI
+	found, content, err := v.GetTaskURI(ctx, event, remotePipelineURL)
+	assert.NilError(t, err)
+	assert.Assert(t, found, "Expected remote pipeline to be found")
+	assert.Equal(t, expectedContent, content, "Returned content mismatch")
+}