Remove field notification emails from autoupdate

Author: chmst

administrator/components/com_joomlaupdate/config.xml

@@ -121,12 +121,5 @@
 			class="alert alert-info w-100"
 			showon="updatesource!:default[OR]minimum_stability!:4"
 		/>
-		<field
-			name="automated_updates_email"
-			type="text"
-			label="COM_JOOMLAUPDATE_CONFIG_AUTOUPDATE_UPDATE_EMAIL_LABEL"
-			description="COM_JOOMLAUPDATE_CONFIG_AUTOUPDATE_UPDATE_EMAIL_DESCRIPTION"
-			showon="updatesource:default[AND]minimum_stability:4[AND]autoupdate:1"
-		/>
 	</fieldset>
 </config>

administrator/components/com_joomlaupdate/src/Model/NotificationModel.php

@@ -19,7 +19,6 @@
 use Joomla\CMS\Table\Asset;
 use Joomla\CMS\Uri\Uri;
 use Joomla\CMS\Version;
-use Joomla\Database\ParameterType;
 use Joomla\Registry\Registry;
 
 // phpcs:disable PSR1.Files.SideEffects
@@ -48,19 +47,8 @@ public function sendNotification($type, $oldVersion): void
     {
         $params = ComponentHelper::getParams('com_joomlaupdate');
 
-        // Load the parameters.
-        $specificEmail = $params->get('automated_updates_email');
-
-        // Let's find out the email addresses to notify
-        $superUsers = [];
-
-        if (!empty($specificEmail)) {
-            $superUsers = $this->getSuperUsers($specificEmail);
-        }
-
-        if (empty($superUsers)) {
-            $superUsers = $this->getSuperUsers();
-        }
+        // Send a notification to all super users
+        $superUsers = $this->getSuperUsers();
 
         if (empty($superUsers)) {
             throw new \RuntimeException();
@@ -105,22 +93,6 @@ public function sendNotification($type, $oldVersion): void
     private function getSuperUsers($email = null): array
     {
         $db     = $this->getDatabase();
-        $emails = [];
-
-        // Convert the email list to an array
-        if (!empty($email)) {
-            $temp = explode(',', $email);
-
-            foreach ($temp as $entry) {
-                if (!MailHelper::isEmailAddress(trim($entry))) {
-                    continue;
-                }
-
-                $emails[] = trim($entry);
-            }
-
-            $emails = array_unique($emails);
-        }
 
         // Get a list of groups which have Super User privileges
         $ret = [];
@@ -144,10 +116,10 @@ private function getSuperUsers($email = null): array
             if (empty($groups)) {
                 return $ret;
             }
-        } catch (\Exception $exc) {
+        } catch (\Exception $exc)  {
             return $ret;
         }
-
+ 
         // Get the user IDs of users belonging to the SA groups
         try {
             $query = $db->getQuery(true)
@@ -174,11 +146,6 @@ private function getSuperUsers($email = null): array
                 ->where($db->quoteName('block') . ' = 0')
                 ->where($db->quoteName('sendEmail') . ' = 1');
 
-            if (!empty($emails)) {
-                $lowerCaseEmails = array_map('strtolower', $emails);
-                $query->whereIn('LOWER(' . $db->quoteName('email') . ')', $lowerCaseEmails, ParameterType::STRING);
-            }
-
             $ret = $db->setQuery($query)->loadObjectList();
         } catch (\Exception) {
             return $ret;

administrator/language/en-GB/com_joomlaupdate.ini

@@ -16,8 +16,6 @@ COM_JOOMLAUPDATE_CONFIG_AUTOMATED_UPDATES_DISABLED_LABEL="<span class=\"fa-fw me
 COM_JOOMLAUPDATE_CONFIG_AUTOMATED_UPDATES_LABEL="Automated Updates"
 COM_JOOMLAUPDATE_CONFIG_AUTOUPDATE_DESC="Automatically update Joomla to the latest version when it is available."
 COM_JOOMLAUPDATE_CONFIG_AUTOUPDATE_LABEL="Automated Update"
-COM_JOOMLAUPDATE_CONFIG_AUTOUPDATE_UPDATE_EMAIL_DESCRIPTION="A comma separated list of the email addresses which will receive the update notification emails. The addresses in the list MUST belong to existing users of your site who have the Super User privilege. If none of the listed emails belongs to Super Users, or if it's left blank, all Super Users of this site will receive the update notification email."
-COM_JOOMLAUPDATE_CONFIG_AUTOUPDATE_UPDATE_EMAIL_LABEL="Super User Emails"
 COM_JOOMLAUPDATE_CONFIG_BACKUPCHECK_DESC="Shows the checkbox to confirm you have taken a backup and you're ready to update in the final step before the update is actually applied."
 COM_JOOMLAUPDATE_CONFIG_BACKUPCHECK_LABEL="Confirm Backup Checkbox"
 COM_JOOMLAUPDATE_CONFIG_CUSTOMURL_LABEL="Custom URL"