Fix filtering active users, use superusers as fallback, change description

Author: chmst

administrator/components/com_joomlaupdate/src/Model/NotificationModel.php

@@ -49,15 +49,12 @@ public function sendNotification($type, $oldVersion): void
         $params = ComponentHelper::getParams('com_joomlaupdate');
 
         // User groups from input field
-        $emailGroups = $params->get('automated_updates_email_groups');
+        $emailGroups = $params->get('automated_updates_email_groups', $this->getSuperUserGroups(), 'array');
 
         if (!\is_array($emailGroups)) {
             $emailGroups = ArrayHelper::toInteger(explode(',', $emailGroups));
         }
 
-        // Add Super User Groups
-        $emailGroups = array_merge($emailGroups, $this->getSuperUserGroups());
-
         // Get all users in these groups who can receive emails
         $emailReceivers = $this->getEmailReceivers($emailGroups);
 
@@ -114,11 +111,12 @@ private function getEmailReceivers($emailGroups): array
             ->getMVCFactory()->createModel('Users', 'Administrator');
 
         $usersModel->setState('filter.groups', $emailGroups);
-        $usersModel->setState('filter.block', (int) 0);
+        $usersModel->setState('filter.state', (int) 0); // Only enabled users
 
         $usersInGroup = $usersModel->getItems();
 
         if (empty($usersInGroup)) {
+            // Cannot happen, as at least one super user must exist in the system
             return [];
         }
 

administrator/language/en-GB/com_joomlaupdate.ini

@@ -16,7 +16,7 @@ COM_JOOMLAUPDATE_CONFIG_AUTOMATED_UPDATES_DISABLED_LABEL="<span class=\"fa-fw me
 COM_JOOMLAUPDATE_CONFIG_AUTOMATED_UPDATES_LABEL="Automated Updates"
 COM_JOOMLAUPDATE_CONFIG_AUTOUPDATE_DESC="Automatically update Joomla to the latest version when it is available."
 COM_JOOMLAUPDATE_CONFIG_AUTOUPDATE_LABEL="Automated Update"
-COM_JOOMLAUPDATE_CONFIG_AUTOUPDATE_UPDATE_EMAIL_DESCRIPTION="All Super Users and all users in the selected groups will receive the emails if they have the receive system emails option enabled in their user profile."
+COM_JOOMLAUPDATE_CONFIG_AUTOUPDATE_UPDATE_EMAIL_DESCRIPTION="All users in the selected groups will receive the emails if they have the receive system emails option enabled in their user profile. If no users are found, all super users will receive the emails."
 COM_JOOMLAUPDATE_CONFIG_AUTOUPDATE_UPDATE_EMAIL_LABEL="Send Email to User Groups"
 COM_JOOMLAUPDATE_CONFIG_BACKUPCHECK_DESC="Shows the checkbox to confirm you have taken a backup and you're ready to update in the final step before the update is actually applied."
 COM_JOOMLAUPDATE_CONFIG_BACKUPCHECK_LABEL="Confirm Backup Checkbox"