[5.4] Stats plugin accessibility (joomla#45736)

Signed-off-by: BrianTeeman <[email protected]>

Author: brianteeman

build/media_source/plg_system_stats/js/stats-message.es6.js

@@ -25,15 +25,6 @@ Joomla = window.Joomla || {};
   const initStatsEvents = (callback) => {
     const messageContainer = document.getElementById('system-message-container');
     const joomlaAlert = messageContainer.querySelector('.js-pstats-alert');
-    const detailsContainer = messageContainer.querySelector('#js-pstats-data-details');
-
-    // Show details about the information being sent
-    document.addEventListener('click', (event) => {
-      if (event.target.classList.contains('js-pstats-btn-details')) {
-        event.preventDefault();
-        detailsContainer.classList.toggle('d-none');
-      }
-    });
 
     // Always allow
     document.addEventListener('click', (event) => {

build/media_source/plg_system_stats/js/stats.es6.js

@@ -7,33 +7,16 @@
   'use strict';
 
   // Selectors used by this script
-  const statsDataTogglerId = 'js-pstats-data-details-toggler';
-  const statsDataDetailsId = 'js-pstats-data-details';
   const resetId = 'js-pstats-reset-uid';
   const uniqueIdFieldId = 'jform_params_unique_id';
 
-  const onToggle = (event) => {
-    event.preventDefault();
-    const element = document.getElementById(statsDataDetailsId);
-
-    if (element) {
-      element.classList.toggle('d-none');
-    }
-  };
-
   const onReset = (event) => {
     event.preventDefault();
     document.getElementById(uniqueIdFieldId).value = '';
     Joomla.submitbutton('plugin.apply');
   };
 
   const onBoot = () => {
-    // Toggle stats details
-    const toggler = document.getElementById(statsDataTogglerId);
-    if (toggler) {
-      toggler.addEventListener('click', onToggle);
-    }
-
     // Reset the unique id
     const reset = document.getElementById(resetId);
     if (reset) {

build/media_source/system/js/core.es6.js

@@ -53,6 +53,8 @@ const DefaultAllowlist = {
   select: ['name'],
   textarea: ['name'],
   option: ['value', 'selected'],
+  details: ['open'],
+  summary: [],
 };
 
 // Only define the Joomla namespace if not defined.

plugins/system/stats/layouts/field/data.php

@@ -50,6 +50,10 @@
  */
 ?>
 <?php if (count($statsData)) : ?>
-    <a href="#" id="js-pstats-data-details-toggler"><?php echo Text::_('PLG_SYSTEM_STATS_MSG_WHAT_DATA_WILL_BE_SENT'); ?></a>
-    <?php echo $field->render('stats', compact('statsData')); ?>
+    <details>
+        <summary>
+            <?php echo Text::_('PLG_SYSTEM_STATS_MSG_WHAT_DATA_WILL_BE_SENT'); ?>
+        </summary>
+        <?php echo $field->render('stats', compact('statsData')); ?>
+    </details>
 <?php endif; ?>

plugins/system/stats/layouts/message.php

@@ -31,12 +31,12 @@
             <p>
                 <?php echo Text::_('PLG_SYSTEM_STATS_MSG_JOOMLA_WANTS_TO_SEND_DATA'); ?>
             </p>
-            <p>
-                <a href="#" class="js-pstats-btn-details alert-link"><?php echo Text::_('PLG_SYSTEM_STATS_MSG_WHAT_DATA_WILL_BE_SENT'); ?></a>
-            </p>
-            <?php
-                echo $plugin->render('stats', compact('statsData'));
-            ?>
+            <details>
+                <summary>
+                    <?php echo Text::_('PLG_SYSTEM_STATS_MSG_WHAT_DATA_WILL_BE_SENT'); ?>
+                </summary>
+                <?php echo $plugin->render('stats', compact('statsData')); ?>
+            </details>
             <p class="fw-bold"><?php echo Text::_('PLG_SYSTEM_STATS_MSG_ALLOW_SENDING_DATA'); ?></p>
             <p class="actions">
                 <button type="button" class="btn btn-primary js-pstats-btn-allow-never"><?php echo Text::_('PLG_SYSTEM_STATS_BTN_NEVER_SEND'); ?></button>

plugins/system/stats/layouts/stats.php

@@ -22,7 +22,7 @@
 
 $versionFields = ['php_version', 'db_version', 'cms_version'];
 ?>
-<table class="table mb-3 d-none" id="js-pstats-data-details">
+<table class="table mb-3">
     <caption class="visually-hidden">
         <?php echo Text::_('PLG_SYSTEM_STATS_STATISTICS'); ?>
     </caption>