Skip to content

Commit e5c91e0

Browse files
authored
[4.4] translation description text static error pages (joomla#42030)
* move meta declaration for better upmerge (conflicts joomla#41935) * same help link element * check if valid ref * check if valid elements * add descText1 * update static error pages * use early return
1 parent 06e4116 commit e5c91e0

File tree

4 files changed

+16
-15
lines changed

4 files changed

+16
-15
lines changed

build/warning_page/template.js

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ var errorLocale = window.errorLocale || null;
55

66
if (errorLocale) {
77
var header = document.getElementById('headerText');
8+
var desc1 = document.getElementById('descText1');
9+
var helpLink = document.getElementById('linkHelp');
810

911
// Create links for all the languages
1012
Object.keys(errorLocale).forEach(function(key) {
@@ -18,18 +20,19 @@ var errorLocale = window.errorLocale || null;
1820
}
1921

2022
document.getElementById('translatedLanguagesSelect').addEventListener('change', function(e) {
21-
var ref = e.target.value, helpLink, meta;
23+
var ref = e.target.value;
2224

23-
if (ref) {
24-
header.innerHTML = errorLocale[ref].header;
25+
if (!ref) {
26+
return;
2527
}
2628

27-
helpLink = document.getElementById('linkHelp');
28-
if (helpLink) {
29+
if (header && desc1 && helpLink) {
30+
header.innerHTML = errorLocale[ref].header;
31+
desc1.innerHTML = errorLocale[ref].text1;
2932
helpLink.innerText = errorLocale[ref]['help-url-text'];
3033
}
3134

32-
meta = document.querySelector('[http-equiv="Content-Language"]');
35+
var meta = document.querySelector('[http-equiv="Content-Language"]');
3336
if (meta) {
3437
meta.setAttribute('content', ref);
3538
}
@@ -46,15 +49,13 @@ var errorLocale = window.errorLocale || null;
4649
document.querySelector('#translatedLanguagesSelect option[value="' + key + '"]').setAttribute('selected', 'selected');
4750

4851
// Append the translated strings
49-
header.innerHTML = errorLocale[key].header;
50-
51-
var helpLink = document.getElementById('linkHelp'), meta;
52-
53-
if (helpLink) {
52+
if (header && desc1 && helpLink) {
53+
header.innerHTML = errorLocale[key].header;
54+
desc1.innerHTML = errorLocale[key].text1;
5455
helpLink.innerText = errorLocale[key]['help-url-text'];
5556
}
5657

57-
meta = document.querySelector('[http-equiv="Content-Language"]');
58+
var meta = document.querySelector('[http-equiv="Content-Language"]');
5859
if (meta) {
5960
meta.setAttribute('content', key);
6061
}

templates/system/build_incomplete.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ <h1 id="headerText">Environment Setup Incomplete</h1><!-- Sets the page header,
3333
</div>
3434
</div>
3535
</div>
36-
<script>var errorLocale=window.errorLocale||null;(function(e,n){"use strict";if(n){var s=e.getElementById("headerText");Object.keys(n).forEach(function(t){var l=e.getElementById("translatedLanguagesSelect"),a=e.createElement("option");a.text=n[t].language,a.value=t,t==="en-GB"&&a.setAttribute("selected","selected"),e.getElementById("translatedLanguagesSelect").addEventListener("change",function(u){var i=u.target.value,g,r;i&&(s.innerHTML=n[i].header),g=e.getElementById("linkHelp"),g&&(g.innerText=n[i]["help-url-text"]),r=e.querySelector('[http-equiv="Content-Language"]'),r&&r.setAttribute("content",i)}),l.appendChild(a)}),Object.keys(n).forEach(function(t){if(navigator.language===t){e.querySelector('#translatedLanguagesSelect option[value="en-GB"]').removeAttribute("selected"),e.querySelector('#translatedLanguagesSelect option[value="'+t+'"]').setAttribute("selected","selected"),s.innerHTML=n[t].header;var l=e.getElementById("linkHelp"),a;l&&(l.innerText=n[t]["help-url-text"]),a=e.querySelector('[http-equiv="Content-Language"]'),a&&a.setAttribute("content",t)}})}})(document,errorLocale);
36+
<script>var errorLocale=window.errorLocale||null;(function(t,e){"use strict";if(e){var i=t.getElementById("headerText"),l=t.getElementById("descText1"),g=t.getElementById("linkHelp");Object.keys(e).forEach(function(n){var u=t.getElementById("translatedLanguagesSelect"),r=t.createElement("option");r.text=e[n].language,r.value=n,n==="en-GB"&&r.setAttribute("selected","selected"),t.getElementById("translatedLanguagesSelect").addEventListener("change",function(v){var a=v.target.value;if(a){i&&l&&g&&(i.innerHTML=e[a].header,l.innerHTML=e[a].text1,g.innerText=e[a]["help-url-text"]);var s=t.querySelector('[http-equiv="Content-Language"]');s&&s.setAttribute("content",a)}}),u.appendChild(r)}),Object.keys(e).forEach(function(n){if(navigator.language===n){t.querySelector('#translatedLanguagesSelect option[value="en-GB"]').removeAttribute("selected"),t.querySelector('#translatedLanguagesSelect option[value="'+n+'"]').setAttribute("selected","selected"),i&&l&&g&&(i.innerHTML=e[n].header,l.innerHTML=e[n].text1,g.innerText=e[n]["help-url-text"]);var u=t.querySelector('[http-equiv="Content-Language"]');u&&u.setAttribute("content",n)}})}})(document,errorLocale);
3737
</script><!-- Sets the script, IMPORTANT DO NOT REMOVE -->
3838
</body>
3939
</html>

templates/system/fatal-error.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ <h1 id="headerText">Sorry, there was a problem we could not recover from.</h1><!
3333
</div>
3434
</div>
3535
</div>
36-
<script>var errorLocale=window.errorLocale||null;(function(e,n){"use strict";if(n){var s=e.getElementById("headerText");Object.keys(n).forEach(function(t){var l=e.getElementById("translatedLanguagesSelect"),a=e.createElement("option");a.text=n[t].language,a.value=t,t==="en-GB"&&a.setAttribute("selected","selected"),e.getElementById("translatedLanguagesSelect").addEventListener("change",function(u){var i=u.target.value,g,r;i&&(s.innerHTML=n[i].header),g=e.getElementById("linkHelp"),g&&(g.innerText=n[i]["help-url-text"]),r=e.querySelector('[http-equiv="Content-Language"]'),r&&r.setAttribute("content",i)}),l.appendChild(a)}),Object.keys(n).forEach(function(t){if(navigator.language===t){e.querySelector('#translatedLanguagesSelect option[value="en-GB"]').removeAttribute("selected"),e.querySelector('#translatedLanguagesSelect option[value="'+t+'"]').setAttribute("selected","selected"),s.innerHTML=n[t].header;var l=e.getElementById("linkHelp"),a;l&&(l.innerText=n[t]["help-url-text"]),a=e.querySelector('[http-equiv="Content-Language"]'),a&&a.setAttribute("content",t)}})}})(document,errorLocale);
36+
<script>var errorLocale=window.errorLocale||null;(function(t,e){"use strict";if(e){var i=t.getElementById("headerText"),l=t.getElementById("descText1"),g=t.getElementById("linkHelp");Object.keys(e).forEach(function(n){var u=t.getElementById("translatedLanguagesSelect"),r=t.createElement("option");r.text=e[n].language,r.value=n,n==="en-GB"&&r.setAttribute("selected","selected"),t.getElementById("translatedLanguagesSelect").addEventListener("change",function(v){var a=v.target.value;if(a){i&&l&&g&&(i.innerHTML=e[a].header,l.innerHTML=e[a].text1,g.innerText=e[a]["help-url-text"]);var s=t.querySelector('[http-equiv="Content-Language"]');s&&s.setAttribute("content",a)}}),u.appendChild(r)}),Object.keys(e).forEach(function(n){if(navigator.language===n){t.querySelector('#translatedLanguagesSelect option[value="en-GB"]').removeAttribute("selected"),t.querySelector('#translatedLanguagesSelect option[value="'+n+'"]').setAttribute("selected","selected"),i&&l&&g&&(i.innerHTML=e[n].header,l.innerHTML=e[n].text1,g.innerText=e[n]["help-url-text"]);var u=t.querySelector('[http-equiv="Content-Language"]');u&&u.setAttribute("content",n)}})}})(document,errorLocale);
3737
</script><!-- Sets the script, IMPORTANT DO NOT REMOVE -->
3838
</body>
3939
</html>

templates/system/incompatible.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ <h1 id="headerText">Sorry, your PHP version is not supported</h1><!-- Sets the p
3333
</div>
3434
</div>
3535
</div>
36-
<script>var errorLocale=window.errorLocale||null;(function(e,n){"use strict";if(n){var s=e.getElementById("headerText");Object.keys(n).forEach(function(t){var l=e.getElementById("translatedLanguagesSelect"),a=e.createElement("option");a.text=n[t].language,a.value=t,t==="en-GB"&&a.setAttribute("selected","selected"),e.getElementById("translatedLanguagesSelect").addEventListener("change",function(u){var i=u.target.value,g,r;i&&(s.innerHTML=n[i].header),g=e.getElementById("linkHelp"),g&&(g.innerText=n[i]["help-url-text"]),r=e.querySelector('[http-equiv="Content-Language"]'),r&&r.setAttribute("content",i)}),l.appendChild(a)}),Object.keys(n).forEach(function(t){if(navigator.language===t){e.querySelector('#translatedLanguagesSelect option[value="en-GB"]').removeAttribute("selected"),e.querySelector('#translatedLanguagesSelect option[value="'+t+'"]').setAttribute("selected","selected"),s.innerHTML=n[t].header;var l=e.getElementById("linkHelp"),a;l&&(l.innerText=n[t]["help-url-text"]),a=e.querySelector('[http-equiv="Content-Language"]'),a&&a.setAttribute("content",t)}})}})(document,errorLocale);
36+
<script>var errorLocale=window.errorLocale||null;(function(t,e){"use strict";if(e){var i=t.getElementById("headerText"),l=t.getElementById("descText1"),g=t.getElementById("linkHelp");Object.keys(e).forEach(function(n){var u=t.getElementById("translatedLanguagesSelect"),r=t.createElement("option");r.text=e[n].language,r.value=n,n==="en-GB"&&r.setAttribute("selected","selected"),t.getElementById("translatedLanguagesSelect").addEventListener("change",function(v){var a=v.target.value;if(a){i&&l&&g&&(i.innerHTML=e[a].header,l.innerHTML=e[a].text1,g.innerText=e[a]["help-url-text"]);var s=t.querySelector('[http-equiv="Content-Language"]');s&&s.setAttribute("content",a)}}),u.appendChild(r)}),Object.keys(e).forEach(function(n){if(navigator.language===n){t.querySelector('#translatedLanguagesSelect option[value="en-GB"]').removeAttribute("selected"),t.querySelector('#translatedLanguagesSelect option[value="'+n+'"]').setAttribute("selected","selected"),i&&l&&g&&(i.innerHTML=e[n].header,l.innerHTML=e[n].text1,g.innerText=e[n]["help-url-text"]);var u=t.querySelector('[http-equiv="Content-Language"]');u&&u.setAttribute("content",n)}})}})(document,errorLocale);
3737
</script><!-- Sets the script, IMPORTANT DO NOT REMOVE -->
3838
</body>
3939
</html>

0 commit comments

Comments
 (0)