Fix StandardRB linting issues

- Auto-corrected Ruby style issues
- Applied standardrb --fix

[Automated daily update]

Author: github-actions[bot]

app/models/assessments/slide_assessment.rb

@@ -66,7 +66,6 @@ def required_runout_length
     )
   end
 
-
   sig { returns(T::Boolean) }
   def meets_wall_height_requirements?
     return false unless slide_platform_height.present? &&

spec/controllers/guides_controller_spec.rb

@@ -7,29 +7,29 @@
       controller = GuidesController.new
       test_guides = [{title: "Test Guide", path: "test"}]
       allow(controller).to receive(:collect_guides).and_return(test_guides)
-      
+
       # Simulate what the index action does
       controller.index
       expect(controller.instance_variable_get(:@guides)).to eq(test_guides)
     end
   end
-  
+
   describe "#collect_guides" do
     it "collects and sorts guides from metadata files" do
       controller = GuidesController.new
-      
+
       # Mock file system
       allow(Dir).to receive(:glob).and_return([
         "/path/zebra_guide/metadata.json",
         "/path/alpha_guide/metadata.json"
       ])
-      
+
       metadata = {
         "screenshots" => [{"filename" => "test.png", "caption" => "Test"}],
         "updated_at" => "2024-01-15T10:00:00Z"
       }
       allow(File).to receive(:read).and_return(metadata.to_json)
-      
+
       # Mock Pathname operations - first path is zebra, second is alpha
       # But they should be sorted alphabetically after collection
       allow_any_instance_of(Pathname).to receive(:relative_path_from) do |path|
@@ -39,41 +39,41 @@
           instance_double(Pathname, dirname: instance_double(Pathname, to_s: "alpha_guide"))
         end
       end
-      
+
       guides = controller.send(:collect_guides)
       expect(guides.length).to eq(2)
       # After sorting by title, alpha should come first
       expect(guides.first[:title]).to eq("Alpha guide")
       expect(guides.last[:title]).to eq("Zebra guide")
     end
-    
+
     it "returns empty array when no guides exist" do
       controller = GuidesController.new
       allow(Dir).to receive(:glob).and_return([])
-      
+
       guides = controller.send(:collect_guides)
       expect(guides).to eq([])
     end
   end
-  
+
   describe "GET #show" do
     let(:guide_path) { "test_guide" }
-    
+
     before do
       # Skip n_plus_one_detection and stub render/redirect to avoid template rendering issues
       allow(controller).to receive(:n_plus_one_detection).and_yield
       allow(controller).to receive(:render)
       allow(controller).to receive(:redirect_to)
     end
-    
+
     context "when metadata file exists" do
       let(:metadata) do
         {
           "screenshots" => [{"filename" => "test.png", "caption" => "Test"}],
           "updated_at" => "2024-01-15T10:00:00Z"
         }
       end
-      
+
       before do
         metadata_file = instance_double(Pathname)
         allow(metadata_file).to receive(:exist?).and_return(true)
@@ -82,23 +82,23 @@
           instance_double(Pathname, join: metadata_file)
         )
       end
-      
+
       it "assigns guide data when metadata exists" do
-        get :show, params: { path: guide_path }
+        get :show, params: {path: guide_path}
         expect(assigns(:guide_data)).to eq(metadata)
       end
-      
+
       it "assigns guide path" do
-        get :show, params: { path: guide_path }
+        get :show, params: {path: guide_path}
         expect(assigns(:guide_path)).to eq(guide_path)
       end
-      
+
       it "assigns humanized guide title" do
-        get :show, params: { path: guide_path }
+        get :show, params: {path: guide_path}
         expect(assigns(:guide_title)).to eq("Test guide")
       end
     end
-    
+
     context "when metadata file does not exist" do
       before do
         metadata_file = instance_double(Pathname)
@@ -109,21 +109,21 @@
         # Don't stub redirect_to for these tests
         allow(controller).to receive(:render)
       end
-      
+
       it "redirects to guides path when metadata doesn't exist" do
         allow(controller).to receive(:redirect_to).and_call_original
-        get :show, params: { path: guide_path }
+        get :show, params: {path: guide_path}
         expect(response).to redirect_to(guides_path)
       end
-      
+
       it "sets flash alert when guide not found" do
         allow(controller).to receive(:redirect_to).and_call_original
-        get :show, params: { path: guide_path }
+        get :show, params: {path: guide_path}
         expect(flash[:alert]).to eq(I18n.t("guides.messages.not_found"))
       end
     end
   end
-  
+
   describe "private methods" do
     describe "#guide_screenshots_root" do
       it "returns the correct path" do
@@ -132,17 +132,17 @@
         expect(controller.send(:guide_screenshots_root)).to eq(expected_path)
       end
     end
-    
+
     describe "#humanize_guide_title" do
       it "removes _spec suffix and humanizes" do
         controller = GuidesController.new
         expect(controller.send(:humanize_guide_title, "test_workflow_spec")).to eq("Test workflow")
       end
-      
+
       it "handles nested paths" do
         controller = GuidesController.new
         expect(controller.send(:humanize_guide_title, "features/admin/user_management")).to eq("User management")
       end
     end
   end
-end
+end

spec/models/inspection_spec.rb

@@ -229,8 +229,8 @@
     it "handles end date correctly with DateTime fields" do
       # Date ranges with DateTime columns only include times before midnight of end date + 1
       on_end_early = create(:inspection, inspection_date: Time.zone.local(2024, 1, 30, 23, 59, 59))
-      after_end = create(:inspection, inspection_date: Time.zone.local(2024, 1, 31, 0, 0, 1))
-      
+      create(:inspection, inspection_date: Time.zone.local(2024, 1, 31, 0, 0, 1))
+
       result = Inspection.filter_by_date_range(start_date, end_date)
       expect(result).to include(on_end_early)
       # Note: Rails Date ranges exclude times on the end date itself for DateTime fields

spec/requests/errors_controller_spec.rb

@@ -135,4 +135,4 @@
       end
     end
   end
-end
+end

spec/requests/inspections/inspections_spec.rb

@@ -413,7 +413,7 @@ def mock_failing_update(error_messages = ["Update error"])
 
           inspection.reload
           expect(inspection.unit).to eq(unit1)
-          
+
           # Verify event logging
           event = Event.for_resource(inspection).last
           expect(event.action).to eq("unit_changed")
@@ -424,7 +424,6 @@ def mock_failing_update(error_messages = ["Update error"])
           patch "/inspections/#{inspection.id}/update_unit", params: {unit_id: "invalid"}
           expect_redirect_with_alert(select_unit_inspection_path(inspection), /invalid.*unit/i)
         end
-
       end
     end
 
@@ -495,7 +494,7 @@ def mock_failing_update(error_messages = ["Update error"])
 
     describe "HEAD requests" do
       let(:inspection) { create(:inspection, user: user, unit: unit) }
-      
+
       it "returns 200 OK for HEAD request" do
         head "/inspections/#{inspection.id}"
         expect(response).to have_http_status(:ok)
@@ -505,7 +504,7 @@ def mock_failing_update(error_messages = ["Update error"])
 
     describe "GET /log" do
       let(:inspection) { create(:inspection, user: user, unit: unit) }
-      
+
       before do
         # Create some events for the inspection
         Event.log(
@@ -532,7 +531,6 @@ def mock_failing_update(error_messages = ["Update error"])
       end
     end
 
-
     describe "prefill functionality" do
       let(:previous_inspection) do
         create(:inspection, :completed,
@@ -552,8 +550,8 @@ def mock_failing_update(error_messages = ["Update error"])
 
       describe "translate_field_name" do
         it "translates field names for prefill display" do
-          get "/inspections/#{new_inspection.id}/edit", params: { tab: "inspection" }
-          
+          get "/inspections/#{new_inspection.id}/edit", params: {tab: "inspection"}
+
           expect(response).to have_http_status(:success)
           # The prefilled_fields will be set if there are fields to prefill
           expect(assigns(:prefilled_fields)).to be_an(Array)
@@ -565,9 +563,9 @@ def mock_failing_update(error_messages = ["Update error"])
             containing_wall_height: 100,
             containing_wall_height_comment: "Test comment"
           )
-          
-          get "/inspections/#{new_inspection.id}/edit", params: { tab: "user_height" }
-          
+
+          get "/inspections/#{new_inspection.id}/edit", params: {tab: "user_height"}
+
           expect(response).to have_http_status(:success)
           expect(assigns(:previous_inspection)).to eq(previous_inspection)
           # Prefilled fields would include the ground_clearance fields
@@ -593,7 +591,7 @@ def mock_failing_update(error_messages = ["Update error"])
 
     describe "validate_tab_parameter" do
       let(:inspection) { create(:inspection, user: user, unit: unit) }
-      
+
       it "redirects with invalid tab parameter" do
         get "/inspections/#{inspection.id}/edit", params: {tab: "invalid_tab"}
 
@@ -642,12 +640,12 @@ def mock_failing_update(error_messages = ["Update error"])
 
     describe "calculate_changes" do
       let(:inspection) { create(:inspection, user: user, unit: unit) }
-      
+
       it "tracks changes correctly in update" do
         # Store original values
         original_passed = inspection.passed
-        original_risk = inspection.risk_assessment
-        
+        inspection.risk_assessment
+
         patch "/inspections/#{inspection.id}", params: {
           inspection: {
             passed: !original_passed,
@@ -656,7 +654,7 @@ def mock_failing_update(error_messages = ["Update error"])
         }
 
         expect(response).to redirect_to(inspection_path(inspection))
-        
+
         # Check the event was logged with changed data
         event = Event.for_resource(inspection).last
         expect(event.action).to eq("updated")
@@ -666,8 +664,8 @@ def mock_failing_update(error_messages = ["Update error"])
       end
 
       it "ignores unchanged values" do
-        original_value = inspection.risk_assessment
-        
+        inspection.risk_assessment
+
         patch "/inspections/#{inspection.id}", params: {
           inspection: {
             risk_assessment: "New risk",
@@ -676,7 +674,7 @@ def mock_failing_update(error_messages = ["Update error"])
         }
 
         expect(response).to redirect_to(inspection_path(inspection))
-        
+
         # Check that only changed fields are in changed_data
         event = Event.for_resource(inspection).last
         expect(event.action).to eq("updated")
@@ -712,14 +710,14 @@ def mock_failing_update(error_messages = ["Update error"])
         end
 
         context "in production environment" do
-          before do 
+          before do
             allow(Rails.env).to receive(:local?).and_return(false)
             allow(Rails.logger).to receive(:error)
           end
 
           it "logs error but continues" do
             get "/inspections/#{invalid_complete_inspection.id}"
-            
+
             expect(Rails.logger).to have_received(:error).with(/DATA INTEGRITY ERROR/)
             expect(response).to have_http_status(:success)
           end
@@ -744,7 +742,7 @@ def mock_failing_update(error_messages = ["Update error"])
         get "/inspections/#{inspection.id}.json"
         expect(response).to have_http_status(:success)
         expect(response.content_type).to include("application/json")
-        
+
         json = JSON.parse(response.body)
         expect(json).to be_present
         expect(json).to have_key("complete")

spec/requests/sessions_spec.rb

@@ -144,7 +144,7 @@ def setup_passkey_session
     context "with valid passkey authentication" do
       it "authenticates user and creates session" do
         # Set up session by calling passkey endpoint first
-        challenge = setup_passkey_session
+        setup_passkey_session
 
         # Mock WebAuthn credential
         mock_webauthn_credential = instance_double(

spec/serializers/base_assessment_blueprint_spec.rb

@@ -71,7 +71,7 @@ def self.column_name_syms
 
     it "uses PublicFieldFiltering::EXCLUDED_FIELDS constant" do
       all_excluded_fields = PublicFieldFiltering::EXCLUDED_FIELDS
-      
+
       # Create a class with all excluded fields plus some public ones
       comprehensive_class = Class.new do
         define_singleton_method(:column_name_syms) do
@@ -84,4 +84,4 @@ def self.column_name_syms
       expect(result).to eq(%i[public_field_1 public_field_2])
     end
   end
-end
+end

spec/services/rpii_verification_service_spec.rb

@@ -429,7 +429,7 @@
           id: "12345",
           raw_value: "John Smith (RPII, API)"
         })
-        
+
         result = described_class.send(:parse_inspector_item, item)
 
         expect(result).to eq({
@@ -455,7 +455,7 @@
           id: "unique-id",
           raw_value: "Jane Doe (67890) - RPII"
         })
-        
+
         result = described_class.send(:parse_inspector_item, item)
 
         expect(result).to eq({