(#3622) Skip trace warning when trace not used

This updates the warning that is outputted in non-elevated mode to not
be outputted when the user has not specified `--trace` on the
commandline.

Without this change, any time a use are running in a non-elevated mode,
they will always have the trace warning outputted even when they haven't
used the argument.

(cherry picked from commit 3a0d4b6)

Author: AdmiringWorm

src/chocolatey.console/Program.cs

@@ -150,7 +150,7 @@ private static void Main(string[] args)
                 {
                     Log4NetAppenderConfiguration.EnableTraceLoggingIf(config.Trace, traceAppenderName);
                 }
-                else
+                else if (config.Trace)
                 {
                     var logger = ChocolateyLoggers.Normal;
 

src/chocolatey/GetChocolatey.cs

@@ -449,14 +449,17 @@ private T EnsureOriginalConfiguration<T>(IList<string> args, Func<ChocolateyConf
                 Log4NetAppenderConfiguration.EnableDebugLoggingIf(configuration.Debug, verboseAppenderName, traceAppenderName);
                 Log4NetAppenderConfiguration.EnableVerboseLoggingIf(configuration.Verbose, configuration.Debug, verboseAppenderName);
 
-                var logger = ChocolateyLoggers.Normal;
-
-                if (!configuration.RegularOutput)
+                if (!configuration.Information.IsProcessElevated && configuration.Trace)
                 {
-                    logger = ChocolateyLoggers.LogFileOnly;
-                }
+                    var logger = ChocolateyLoggers.Normal;
+
+                    if (!configuration.RegularOutput)
+                    {
+                        logger = ChocolateyLoggers.LogFileOnly;
+                    }
 
-                "chocolatey".Log().Warn(logger, "Usage of the --trace option is only allowed when running from an elevated session.");
+                    "chocolatey".Log().Warn(logger, "Usage of the --trace option is only allowed when running from an elevated session.");
+                }
             }
             finally
             {