Merge pull request #3846 from AdmiringWorm/fix/null-coalesce-process-output

(maint) Guard against null Data in process output callbacks

Author: corbob

src/chocolatey.tests.integration/scenarios/InstallScenarios.cs

@@ -262,8 +262,8 @@ public void Should_have_a_console_shim_that_is_set_for_non_gui_access()
                     shimfile,
                     "--shimgen-noop",
                     10,
-                    stdOutAction: (s, e) => messages.Add(e.Data),
-                    stdErrAction: (s, e) => messages.Add(e.Data)
+                    stdOutAction: (s, e) => messages.Add(e.Data ?? string.Empty),
+                    stdErrAction: (s, e) => messages.Add(e.Data ?? string.Empty)
                 );
 
                 messages.Should()
@@ -283,8 +283,8 @@ public void Should_have_a_graphical_shim_that_is_set_for_gui_access()
                     shimfile,
                     "--shimgen-noop",
                     10,
-                    stdOutAction: (s, e) => messages.Add(e.Data),
-                    stdErrAction: (s, e) => messages.Add(e.Data)
+                    stdOutAction: (s, e) => messages.Add(e.Data ?? string.Empty),
+                    stdErrAction: (s, e) => messages.Add(e.Data ?? string.Empty)
                 );
 
                 messages.Should()
@@ -3208,8 +3208,8 @@ public void Should_have_a_console_shim_that_is_set_for_non_gui_access()
                     shimfile,
                     "--shimgen-noop",
                     10,
-                    stdOutAction: (s, e) => messages.Add(e.Data),
-                    stdErrAction: (s, e) => messages.Add(e.Data)
+                    stdOutAction: (s, e) => messages.Add(e.Data ?? string.Empty),
+                    stdErrAction: (s, e) => messages.Add(e.Data ?? string.Empty)
                 );
 
                 messages.Should()
@@ -3229,8 +3229,8 @@ public void Should_have_a_graphical_shim_that_is_set_for_gui_access()
                     shimfile,
                     "--shimgen-noop",
                     10,
-                    stdOutAction: (s, e) => messages.Add(e.Data),
-                    stdErrAction: (s, e) => messages.Add(e.Data)
+                    stdOutAction: (s, e) => messages.Add(e.Data ?? string.Empty),
+                    stdErrAction: (s, e) => messages.Add(e.Data ?? string.Empty)
                 );
 
                 messages.Should()
@@ -3455,8 +3455,8 @@ public void Should_have_a_console_shim_that_is_set_for_non_gui_access()
                     shimfile,
                     "--shimgen-noop",
                     10,
-                    stdOutAction: (s, e) => messages.Add(e.Data),
-                    stdErrAction: (s, e) => messages.Add(e.Data)
+                    stdOutAction: (s, e) => messages.Add(e.Data ?? string.Empty),
+                    stdErrAction: (s, e) => messages.Add(e.Data ?? string.Empty)
                 );
 
                 messages.Should()
@@ -3476,8 +3476,8 @@ public void Should_have_a_graphical_shim_that_is_set_for_gui_access()
                     shimfile,
                     "--shimgen-noop",
                     10,
-                    stdOutAction: (s, e) => messages.Add(e.Data),
-                    stdErrAction: (s, e) => messages.Add(e.Data)
+                    stdOutAction: (s, e) => messages.Add(e.Data ?? string.Empty),
+                    stdErrAction: (s, e) => messages.Add(e.Data ?? string.Empty)
                 );
 
                 messages.Should()
@@ -4377,8 +4377,8 @@ public void Should_have_a_console_shim_that_is_set_for_non_gui_access()
                     shimfile,
                     "--shimgen-noop",
                     10,
-                    stdOutAction: (s, e) => messages.Add(e.Data),
-                    stdErrAction: (s, e) => messages.Add(e.Data)
+                    stdOutAction: (s, e) => messages.Add(e.Data ?? string.Empty),
+                    stdErrAction: (s, e) => messages.Add(e.Data ?? string.Empty)
                 );
 
                 messages.Should()
@@ -4398,8 +4398,8 @@ public void Should_have_a_graphical_shim_that_is_set_for_gui_access()
                     shimfile,
                     "--shimgen-noop",
                     10,
-                    stdOutAction: (s, e) => messages.Add(e.Data),
-                    stdErrAction: (s, e) => messages.Add(e.Data)
+                    stdOutAction: (s, e) => messages.Add(e.Data ?? string.Empty),
+                    stdErrAction: (s, e) => messages.Add(e.Data ?? string.Empty)
                 );
 
                 messages.Should()