Skip to content

Commit e2abc8f

Browse files
authored
Fix for unattended dashboard install (aws-solutions-library-samples#1328)
1 parent 1781faf commit e2abc8f

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

cfn-templates/cid-cfn.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# https://github.com/aws-samples/aws-cudos-framework-deployment/blob/main/cfn-templates/cid-cfn.yml
22
AWSTemplateFormatVersion: '2010-09-09'
3-
Description: Deployment of Cloud Intelligence Dashboards v4.3.6 - AWS Solution SO9011
3+
Description: Deployment of Cloud Intelligence Dashboards v4.3.7 - AWS Solution SO9011
44
Metadata:
55
AWS::CloudFormation::Interface:
66
ParameterGroups:
@@ -2075,7 +2075,7 @@ Resources:
20752075
SourceBucket: !Ref ReferenceAssetsBucket
20762076
DestinationBucket: !Ref LocalAssetsBucket
20772077
Keys:
2078-
- 'cid-resource-lambda-layer/cid-4.3.6.zip' #replace version here if needed
2078+
- 'cid-resource-lambda-layer/cid-4.3.7.zip' #replace version here if needed
20792079

20802080
CidResourceLambdaLayer:
20812081
Type: AWS::Lambda::LayerVersion
@@ -2090,7 +2090,7 @@ Resources:
20902090
- LambdaLayerBucketPrefixIsManaged
20912091
- !FindInMap [RegionMap, !Ref 'AWS::Region', BucketName]
20922092
- !Sub '${LambdaLayerBucketPrefix}-${AWS::Region}' # Region added for backward compatibility
2093-
S3Key: 'cid-resource-lambda-layer/cid-4.3.6.zip' #replace version here if needed
2093+
S3Key: 'cid-resource-lambda-layer/cid-4.3.7.zip' #replace version here if needed
20942094
CompatibleRuntimes:
20952095
- python3.10
20962096
- python3.11

cid/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
__version__ = '4.3.6'
1+
__version__ = '4.3.7'
22

cid/common.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -408,6 +408,8 @@ def get_template_parameters(self, parameters: dict, param_prefix: str='', others
408408
params[key] = get_parameters().get(prefix + key)
409409
if isinstance(params[key], str):
410410
params[key] = params[key].split(',')
411+
elif not utils.isatty():
412+
params[key] = "'{}'"
411413
else:
412414
if 'query' not in value:
413415
raise CidCritical(f'Failed fetching parameter {prefix}{key}: parameter with type Athena must have query value.')

0 commit comments

Comments
 (0)