fix async rendering

yoshuawuyts · yoshuawuyts · commit afd1c185a7e1 · 2018-04-04T17:13:44.000+02:00
diff --git a/example/index.js b/example/index.js
@@ -1,6 +1,7 @@
-var split = require('split-require')
+// var split = require('split-require')
 var css = require('sheetify')
 var choo = require('../')
+var html = require('choo/html')
 
 css('todomvc-common/base.css')
 css('todomvc-app-css/index.css')
@@ -16,6 +17,12 @@ app.route('#active', require('./views/main'))
 app.route('#completed', require('./views/main'))
 app.route('*', require('./views/main'))
 
-app.experimentalAsyncRoute('/async', () => split('./views/main.js'))
+app.experimentalAsyncRoute('/async', () => Promise.resolve(function (state, emit) {
+  return html`
+    <body>
+      Async rendering.
+    </body>
+  `
+}))
 
 module.exports = app.mount('body')
diff --git a/index.js b/index.js
@@ -83,9 +83,9 @@ Choo.prototype.route = function (route, handler) {
 }
 
 // Register a route to be loaded asynchronously.
-Choo.prototype.experimentalAsyncRoute = function (route, load) {
+Choo.prototype.experimentalAsyncRoute = function (route, loader) {
   assert.equal(typeof route, 'string', 'choo.asyncRoute: asyncRoute should be type string')
-  assert.equal(typeof handler, 'function', 'choo.asyncRoute: route should be type function')
+  assert.equal(typeof loader, 'function', 'choo.asyncRoute: loader should be type function')
 
   var IDLE = 0
   var LOADING = 1
@@ -104,7 +104,7 @@ Choo.prototype.experimentalAsyncRoute = function (route, load) {
       renderRoute = state.route
       loadingState = LOADING
 
-      var p = load(onload)
+      var p = loader(onload)
       assert(p && p.then, 'choo.asyncRoute: async route should return a Promise')
       p.then(onload.bind(null, null), onload)
       return self._asyncProxy
