clang-tidy analysis did not contain vf_*.h header files (danmar#7361)

Author: firewave

.clang-tidy

@@ -70,7 +70,8 @@ Checks: >
         -readability-suspicious-call-argument,
         -readability-uppercase-literal-suffix
 WarningsAsErrors: '*'
-HeaderFilterRegex: '(cli|gui|lib|oss-fuzz|test|triage)\/[a-z]+\.h'
+HeaderFilterRegex: '(cli|gui|lib|oss-fuzz|test|triage)\/[a-z_]+\.h'
+ExcludeHeaderFilterRegex: 'ui_.*.h'
 CheckOptions:
   - key:             misc-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic
     value:           '1'

cmake/clang_tidy.cmake

@@ -25,8 +25,12 @@ if(RUN_CLANG_TIDY_NAMES)
         endif()
         message(STATUS "NPROC=${NPROC}")
 
+        # TODO: exclude moc_*.cpp
+        # TODO: exclude mocs_compilation.cpp
         # disable all compiler warnings since we are just interested in the tidy ones
-        add_custom_target(run-clang-tidy ${Python_EXECUTABLE} ${RUN_CLANG_TIDY} -p=${CMAKE_BINARY_DIR} -j ${NPROC} -quiet)
+        add_custom_target(run-clang-tidy
+                ${Python_EXECUTABLE} ${RUN_CLANG_TIDY} -p=${CMAKE_BINARY_DIR} -j ${NPROC} -quiet
+                USES_TERMINAL)
         if(BUILD_GUI)
             add_dependencies(run-clang-tidy gui-build-deps)
             if(BUILD_TRIAGE)

lib/vf_common.h

@@ -40,11 +40,11 @@ namespace ValueFlow
 {
     bool getMinMaxValues(const ValueType* vt, const Platform& platform, MathLib::bigint& minValue, MathLib::bigint& maxValue);
 
-    MathLib::bigint truncateIntValue(MathLib::bigint value, size_t value_size, const ValueType::Sign dst_sign);
+    MathLib::bigint truncateIntValue(MathLib::bigint value, size_t value_size, ValueType::Sign dst_sign);
 
     Token * valueFlowSetConstantValue(Token *tok, const Settings &settings);
 
-    Value castValue(Value value, const ValueType::Sign sign, nonneg int bit);
+    Value castValue(Value value, ValueType::Sign sign, nonneg int bit);
 
     std::string debugString(const Value& v);