(build) disable netcoreapp3.1 test of some msbuild tests for now

Author: arturcic

.github/workflows/ci.yml

@@ -159,7 +159,7 @@ jobs:
         dotnet-version: '6.0.x'
         include-prerelease: true
     -
-      name: '[Build]'
+      name: '[Unit Test]'
       shell: pwsh
       run: dotnet run/build.dll --target=Test --dotnet_target=${{ matrix.targetFramework }}
 

build/build/Tasks/Test/UnitTest.cs

@@ -87,9 +87,14 @@ private static void TestProjectForTarget(BuildContext context, FilePath project,
             Exclude = new List<string> { "[GitVersion*.Tests]*", "[GitTools.Testing]*" }
         };
 
+        if (string.Equals(framework, Constants.CoreFxVersion31))
+        {
+            settings.Filter = $"TestCategory!={Constants.NoNetCoreApp31}";
+        }
+
         if (string.Equals(framework, Constants.FullFxVersion48))
         {
-            settings.Filter = context.IsRunningOnUnix() ? "TestCategory!=NoMono" : "TestCategory!=NoNet48";
+            settings.Filter = context.IsRunningOnUnix() ? $"TestCategory!={Constants.NoMono}" : $"TestCategory!={Constants.NoNet48}";
         }
 
         context.DotNetCoreTest(project.FullPath, settings, coverletSettings);

build/common/Utilities/Constants.cs

@@ -13,6 +13,11 @@ public class Constants
     public const string NetVersion60 = "net6.0";
     public const string CoreFxVersion31 = "netcoreapp3.1";
     public const string FullFxVersion48 = "net48";
+
+    public const string NoMono = "NoMono";
+    public const string NoNet48 = "NoNet48";
+    public const string NoNetCoreApp31 = "NoNetCoreApp31";
+
     public static readonly string[] VersionsToBuild = { Version60, Version50, Version31 };
     public static readonly Architecture[] ArchToBuild = { Architecture.Amd64, Architecture.Arm64 };
     public static readonly string[] DistrosToSkip = { Alpine312, Alpine313, Alpine314, Centos7 };

src/GitVersion.Core.Tests/Helpers/TestBase.cs

@@ -11,6 +11,7 @@ public class TestBase
     protected const string NoMonoDescription = "Won't run on Mono due to source information not being available for ShouldMatchApproved.";
     protected const string NoMono = "NoMono";
     protected const string NoNet48 = "NoNet48";
+    protected const string NoNetCoreApp31 = "NoNetCoreApp31";
     public const string MainBranch = "main";
 
     protected static IServiceProvider ConfigureServices(Action<IServiceCollection> overrideServices = null)

src/GitVersion.MsBuild.Tests/Tasks/GenerateGitVersionInformationTest.cs

@@ -50,6 +50,7 @@ public void GenerateGitVersionInformationTaskShouldCreateFileInBuildServer()
     }
 
     [Test]
+    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuild()
@@ -77,6 +78,7 @@ public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuild(
     }
 
     [Test]
+    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void GenerateGitVersionInformationTaskShouldCreateFileWhenRunWithMsBuildInBuildServer()

src/GitVersion.MsBuild.Tests/Tasks/GetVersionTaskTests.cs

@@ -61,6 +61,7 @@ public void GetVersionTaskShouldReturnVersionOutputVariablesForBuildServer()
     [TestCase(nameof(VersionVariables.Patch), "4")]
     [TestCase(nameof(VersionVariables.MajorMinorPatch), "1.2.4")]
     [TestCase(nameof(VersionVariables.FullSemVer), "1.2.4+1")]
+    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void GetVersionTaskShouldReturnVersionOutputVariablesWhenRunWithMsBuild(string outputProperty, string version)
@@ -82,6 +83,7 @@ public void GetVersionTaskShouldReturnVersionOutputVariablesWhenRunWithMsBuild(s
     [TestCase(nameof(VersionVariables.Patch), "1")]
     [TestCase(nameof(VersionVariables.MajorMinorPatch), "1.0.1")]
     [TestCase(nameof(VersionVariables.FullSemVer), "1.0.1+1")]
+    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void GetVersionTaskShouldReturnVersionOutputVariablesWhenRunWithMsBuildInBuildServer(string outputProperty, string version)

src/GitVersion.MsBuild.Tests/Tasks/UpdateAssemblyInfoTaskTest.cs

@@ -41,6 +41,7 @@ public void UpdateAssemblyInfoTaskShouldCreateFileInBuildServer()
     }
 
     [Test]
+    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void UpdateAssemblyInfoTaskShouldCreateFileWhenRunWithMsBuild()
@@ -64,6 +65,7 @@ public void UpdateAssemblyInfoTaskShouldCreateFileWhenRunWithMsBuild()
     }
 
     [Test]
+    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void UpdateAssemblyInfoTaskShouldCreateFileWhenRunWithMsBuildInBuildServer()

src/GitVersion.MsBuild.Tests/Tasks/WriteVersionInfoTest.cs

@@ -93,6 +93,7 @@ public void WriteVersionInfoTaskShouldLogOutputVariablesToBuildOutputInGitHubAct
     }
 
     [Test]
+    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void WriteVersionInfoTaskShouldNotLogOutputVariablesToBuildOutputWhenRunWithMsBuild()
@@ -110,6 +111,7 @@ public void WriteVersionInfoTaskShouldNotLogOutputVariablesToBuildOutputWhenRunW
     }
 
     [Test]
+    [Category(NoNetCoreApp31)]
     [Category(NoNet48)]
     [Category(NoMono)]
     public void WriteVersionInfoTaskShouldLogOutputVariablesToBuildOutputWhenRunWithMsBuildInAzurePipeline()