Add valueResult unconditionally and more testing

Author: thorin8k

src/rule.js

@@ -231,9 +231,7 @@ class Rule extends EventEmitter {
           .then((evaluationResult) => {
             const passes = evaluationResult.result
             condition.factResult = evaluationResult.leftHandSideValue
-            if (typeof condition.value === 'object' && condition.value !== null) {
-              condition.value.factResult = evaluationResult.rightHandSideValue
-            }
+            condition.valueResult = evaluationResult.rightHandSideValue
             condition.result = passes
             return passes
           })

test/acceptance/acceptance.js

@@ -36,13 +36,15 @@ describe('Acceptance', () => {
       path: '$.values',
       value: 2,
       factResult: [2],
+      valueResult: 2,
       result: true
     },
     {
       fact: 'low-priority',
       operator: 'in',
       value: [2],
       factResult: 2,
+      valueResult: [2],
       result: true
     }
     ],
@@ -169,7 +171,8 @@ describe('Acceptance', () => {
             },
             path: '$.values',
             result: true,
-            value: 2
+            value: 2,
+            valueResult: 2
           },
           {
             fact: 'low-priority',
@@ -178,6 +181,9 @@ describe('Acceptance', () => {
             result: true,
             value: [
               2
+            ],
+            valueResult: [
+              2
             ]
           }
         ],
@@ -202,6 +208,7 @@ describe('Acceptance', () => {
             factResult: [
               2
             ],
+            valueResult: 2,
             operator: 'containsDivisibleValuesOf',
             params: {
               factParam: 1
@@ -210,7 +217,6 @@ describe('Acceptance', () => {
             result: true,
             value: {
               fact: 'rule-created-fact',
-              factResult: 2,
               path: '$.array'
             }
           }

types/index.d.ts

@@ -192,6 +192,7 @@ interface BooleanConditionResultProperties {
 
 interface ConditionResultProperties extends BooleanConditionResultProperties {
   factResult?: unknown
+  valueResult?: unknown
 }
 
 interface ConditionProperties {