Tons of minor Codacy fixes

#1886 #1887

Author: chrisblakley

Nebula-Child/assets/scss/critical.scss

@@ -1,6 +1,6 @@
 //Import partials
-@import $parent_partials_directory + '/variables';
-@import 'variables'; //Child theme variables
-@import $parent_partials_directory + '/mixins';
+@import $parent_partials_directory + "/variables";
+@import "variables"; //Child theme variables
+@import $parent_partials_directory + "/mixins";
 
 //Add critical above-the-fold styles in this file.

Nebula-Child/assets/scss/style.scss

@@ -13,17 +13,17 @@
 */
 
 //Import Nebula partials
-@import $parent_partials_directory + '/variables';
-@import 'variables'; //Child theme variables
-@import $parent_partials_directory + '/functions';
-@import $parent_partials_directory + '/mixins';
-@import $parent_partials_directory + '/helpers';
-@import $parent_partials_directory + '/animations';
-@import '../critical'; //Child theme critical styles
+@import $parent_partials_directory + "/variables";
+@import "variables"; //Child theme variables
+@import $parent_partials_directory + "/functions";
+@import $parent_partials_directory + "/mixins";
+@import $parent_partials_directory + "/helpers";
+@import $parent_partials_directory + "/animations";
+@import "../critical"; //Child theme critical styles
 
 //Import child theme partials
-@import 'utilities';
-@import 'typography';
-@import 'header';
-@import 'sidebar';
-@import 'footer';
+@import "utilities";
+@import "typography";
+@import "header";
+@import "sidebar";
+@import "footer";

Nebula-Child/resources/sw.js

@@ -1,6 +1,6 @@
 //BEGIN automated edits. These will be automatically overwritten.
 var THEME_NAME = 'nebula-child';
-var NEBULA_VERSION = 'v6.12.1.0001'; //Wednesday, May 1, 2019 11:20:03 AM
+var NEBULA_VERSION = 'v6.12.1.5244'; //Wednesday, May 1, 2019 10:57:42 PM
 var OFFLINE_URL = 'https://gearside.com/nebula/offline/';
 var OFFLINE_IMG = 'https://gearside.com/nebula/wp-content/themes/Nebula-master/assets/img/offline.svg';
 var OFFLINE_GA_DIMENSION = 'cd2';
@@ -10,7 +10,7 @@ var HOME_URL = 'https://gearside.com/nebula/';
 var START_URL = 'https://gearside.com/nebula/?utm_source=pwa';
 //END automated edits
 
-importScripts('https://storage.googleapis.com/workbox-cdn/releases/4.3.0/workbox-sw.js'); //https://developers.google.com/web/tools/workbox/guides/get-started
+importScripts('https://storage.googleapis.com/workbox-cdn/releases/4.3.1/workbox-sw.js'); //https://developers.google.com/web/tools/workbox/guides/get-started
 workbox.setConfig({debug: false}); //https://developers.google.com/web/tools/workbox/guides/troubleshoot-and-debug
 
 //@todo "Nebula" 0: If ?debug is present in the URL on load, dump the entire cache and unregister (or update) the SW completely

Nebula-Child/style.css

@@ -107,7 +107,7 @@ jQuery(window).on('load', function(){
 		}, 1000, 'nebula options filter history api');
 
 		//Prevent the form from submitting if pressing enter after searching
-		if ( e.type == 'keydown' && e.keyCode == 13 ){
+		if ( e.type === 'keydown' && e.keyCode === 13 ){
 			e.preventDefault();
 			return false;
 		}
@@ -674,7 +674,7 @@ function checkDependents(inputObject){
 					}
 				});
 
-				if ( dependentsChecked == totalDependents ){
+				if ( dependentsChecked === totalDependents ){
 					oThis.removeClass('inactive').find('.dependent-note').addClass('hidden');
 				}
 			});
@@ -694,7 +694,7 @@ function checkDependents(inputObject){
 					}
 				});
 
-				if ( dependentsUnchecked == totalDependents ){
+				if ( dependentsUnchecked === totalDependents ){
 					oThis.addClass('inactive').find('.dependent-note').removeClass('hidden');
 				}
 			});
@@ -969,7 +969,7 @@ function debounce(callback, wait, uniqueID, immediate){
 	}
 
 	if ( !uniqueID ){
-		uniqueID = "Don't call this twice without a uniqueID";
+		uniqueID = 'Do not call this twice without a uniqueID';
 	}
 
 	var context = this, args = arguments;

assets/css/admin.css

@@ -1,7 +1,7 @@
-@import 'variables';
-@import 'functions';
-@import 'mixins';
-@import 'helpers';
+@import "variables";
+@import "functions";
+@import "mixins";
+@import "helpers";
 
 $admin_media_queries: (
 	widescreen: "(max-width: 1800px) and (min-width: 1500px)",
@@ -21,7 +21,7 @@ $admin_media_queries: (
 
 //Lighten the primary color if too dark for WordPress menu backgrounds
 $admin_hover_color: lighten($primary_color, 22%);
-@if high-contrast-color($primary_color) == '#000' {
+@if high-contrast-color($primary_color) == "#000" {
 	$admin_hover_color: $primary_color;
 }
 
@@ -210,7 +210,7 @@ td.column-title strong, td.plugin-title strong {font-size: 12px !important;}
 .widefat .column-wpseo-focuskw {width: 100px; font-size: 10px !important; background: #fafafa;}
 
 #dashboard_right_now a[href$="options-reading.php"] {color: $danger_color !important; font-weight: 700;
-	&:before {content: '!'; background: $danger_color; color: #fff; padding: 0 7px; margin-right: 5px;}
+	&:before {content: "!"; background: $danger_color; color: #fff; padding: 0 7px; margin-right: 5px;}
 }
 
 ul.admin-menu-tree-page-tree .admin-menu-tree-page-expand {width: 19px; height: 20px;}
@@ -337,7 +337,7 @@ body.appearance_page_nebula_options {background-color: #f1f1f1;}
 
 	input[type=checkbox] {height: 0; width: 0; visibility: hidden; display: none;
 		+ label {display: flex; position: relative; align-items: center; cursor: pointer; text-indent: 50px; width: 38px; white-space: nowrap; padding: 0.5rem 0; font-size: 1rem; line-height: 1; background: #ddd; border-radius: 1.25rem; margin: 0 15px 0 0; overflow: visible;
-			&:after {content: ''; position: absolute; top: 6px; left: 5px; width: 1rem; height: 1rem; background: #fff; border-radius: 50%; transition: 0.25s;
+			&:after {content: ""; position: absolute; top: 6px; left: 5px; width: 1rem; height: 1rem; background: #fff; border-radius: 50%; transition: 0.25s;
 				&:after {width: 1rem;}
 			}
 		}