Mobile autocomplete fix, TinyMCE with Bootstrap Reboot CSS, other minor edits...

Author: Chris Blakley

Nebula-Child/style.css

@@ -233,7 +233,7 @@ function nebulaBatteryData(battery){
 		'battery_mode': nebula.user.client.device.battery.mode,
 		'battery_percentage': nebula.user.client.device.battery.percentage,
 	});
-	jQuery(document).trigger('batteryChange');
+	nebula.dom.document.trigger('batteryChange');
 }
 
 //Detect Network Connection
@@ -288,7 +288,7 @@ function facebookConnect(){
 				xfbml: true
 			});
 
-			jQuery(document).trigger('fbinit');
+			nebula.dom.document.trigger('fbinit');
 		};
 	} else {
 		jQuery('.facebook-connect').remove();
@@ -748,8 +748,8 @@ function isInView(element){
 	var elementTop = element.offset().top;
 	var elementBottom = element.offset().top+element.innerHeight();
 
-	var windowTop = jQuery(document).scrollTop();
-	var windowBottom = jQuery(document).scrollTop()+jQuery(window).height();
+	var windowTop = nebula.dom.document.scrollTop();
+	var windowBottom = nebula.dom.document.scrollTop()+nebula.dom.window.height();
 
 	if ( !nebula.dom.body.hasClass('page-visibility-hidden') && ((elementTop >= windowTop && elementTop < windowBottom) || (elementBottom >= windowTop && elementBottom < windowBottom) || (elementTop < windowTop && elementBottom > windowBottom)) ){
 		return true;
@@ -867,7 +867,7 @@ function hubspot(mode, type, email, properties, callback){ //@todo "Nebula" 0: U
 					nebula.user.vid = response.vid;
 					nv('send', {'hubspot_vid': response.vid});
 				}
-				jQuery(document).trigger('nebula_hubspot_sent');
+				nebula.dom.document.trigger('nebula_hubspot_sent');
 
 				if ( callback ){
 					callback(response);
@@ -931,7 +931,7 @@ function initAutocompleteSearch(){
 		jQuery('.nebula-search-iconable').removeClass('searching').removeClass('autocompleted');
 	});
 
-	jQuery("input#s, input.search").on('keypress paste', function(e){
+	jQuery("input#s, input.search").on('keyup paste', function(e){
 		if ( !jQuery(this).hasClass('no-autocomplete') && jQuery.trim(jQuery(this).val()).length && searchTriggerOnlyChars(e) ){
 			autocompleteSearch(jQuery(this));
 		}
@@ -949,7 +949,7 @@ function autocompleteSearch(element, types){
 		return false;
 	}
 
-	jQuery(document).trigger('nebula_autocomplete_search_start', element);
+	nebula.dom.document.trigger('nebula_autocomplete_search_start', element);
 	nebulaTimer('autocompleteSearch', 'start');
 	nebulaTimer('autocompleteResponse', 'start');
 
@@ -981,18 +981,18 @@ function autocompleteSearch(element, types){
 						types: JSON.stringify(types)
 					},
 					success: function(data){
-						jQuery(document).trigger('nebula_autocomplete_search_success', data);
+						nebula.dom.document.trigger('nebula_autocomplete_search_success', data);
 						ga('set', gaCustomMetrics['autocompleteSearches'], 1);
 						ga('set', gaCustomDimensions['timestamp'], localTimestamp());
 						if ( data ){
-							jQuery(document).trigger('nebula_autocomplete_search_results', data);
+							nebula.dom.document.trigger('nebula_autocomplete_search_results', data);
 							nebulaPrerender(data[0].link);
 							jQuery.each(data, function(index, value){
 								value.label = value.label.replace(/&#038;/g, "\&");
 							});
 							noSearchResults = '';
 						} else {
-							jQuery(document).trigger('nebula_autocomplete_search_no_results');
+							nebula.dom.document.trigger('nebula_autocomplete_search_no_results');
 							noSearchResults = ' (No Results)';
 						}
 						debounce(function(){
@@ -1004,7 +1004,7 @@ function autocompleteSearch(element, types){
 						element.parents('form').removeClass('searching').addClass('autocompleted');
 					},
 					error: function(XMLHttpRequest, textStatus, errorThrown){
-						jQuery(document).trigger('nebula_autocomplete_search_error', request.term);
+						nebula.dom.document.trigger('nebula_autocomplete_search_error', request.term);
 						ga('set', gaCustomDimensions['timestamp'], localTimestamp());
 						debounce(function(){
 							ga('send', 'event', 'Internal Search', 'Autcomplete Error', request.term);
@@ -1019,7 +1019,7 @@ function autocompleteSearch(element, types){
 				event.preventDefault(); //Prevent input value from changing.
 			},
 			select: function(event, ui){
-				jQuery(document).trigger('nebula_autocomplete_search_selected', ui);
+				nebula.dom.document.trigger('nebula_autocomplete_search_selected', ui);
 				ga('set', gaCustomMetrics['autocompleteSearchClicks'], 1);
 				ga('set', gaCustomDimensions['timestamp'], localTimestamp());
 				ga('send', 'event', 'Internal Search', 'Autocomplete Click', ui.item.label);
@@ -1916,7 +1916,7 @@ function conditionalJSLoading(){
 			jQuery.getScript('https://www.google.com/jsapi?key=' + nebula.site.options.nebula_google_browser_api_key, function(){
 			    google.load('maps', '3', {
 			        callback: function(){
-			        	jQuery(document).trigger('nebula_google_maps_api_loaded');
+			        	nebula.dom.document.trigger('nebula_google_maps_api_loaded');
 			        }
 			    });
 			}).fail(function(){
@@ -1942,7 +1942,7 @@ function conditionalJSLoading(){
         jQuery.getScript(nebula.site.resources.js.datatables).done(function(){
             nebulaLoadCSS(nebula.site.resources.css.datatables);
 			dataTablesActions(); //Once loaded, call the DataTables actions. This can be called or overwritten in child.js (or elsewhere)
-			jQuery(document).trigger('nebula_datatables_loaded'); //This event can be listened for in child.js (or elsewhere) for when DataTables has finished loading.
+			nebula.dom.document.trigger('nebula_datatables_loaded'); //This event can be listened for in child.js (or elsewhere) for when DataTables has finished loading.
         }).fail(function(){
             ga('set', gaCustomDimensions['timestamp'], localTimestamp());
             ga('send', 'event', 'Error', 'JS Error', 'jquery.dataTables.min.js could not be loaded', {'nonInteraction': true});
@@ -2464,7 +2464,7 @@ function nebulaScrollTo(element, milliseconds, offset, onlyWhenBelow){
 		var willScroll = true;
 		if ( onlyWhenBelow ){
 			var elementTop = element.offset().top-offset;
-			var viewportTop = jQuery(document).scrollTop();
+			var viewportTop = nebula.dom.document.scrollTop();
 			if ( viewportTop-elementTop <= 0 ){
 				willScroll = false;
 			}
@@ -3203,7 +3203,7 @@ function onYouTubeIframeAPIReady(e){
 		}
 	});
 
-	jQuery(document).trigger('nebula_youtube_players_created');
+	nebula.dom.document.trigger('nebula_youtube_players_created');
 	pauseFlag = false;
 }
 function onPlayerError(e){
@@ -3339,7 +3339,7 @@ function nebulaVimeoTracking(){
 			    players.vimeo[id].addEvent('finish', vimeoFinish);
 			    players.vimeo[id].addEvent('playProgress', vimeoPlayProgress);
 
-			    jQuery(document).trigger('nebula_vimeo_players_created', id);
+			    nebula.dom.document.trigger('nebula_vimeo_players_created', id);
 			});
 		});
 

assets/css/pre.css

@@ -104,6 +104,8 @@ body:not(.wp-admin) {
 	.filtered {display: none;}
 }
 
+.sticky {position: sticky; top: 0;} //Sticky requires a top value. Default is set to 0 here.
+
 .aligncenter, .align-center {display: block; margin: 0 auto;}
 .alignleft, .align-left {float: left;}
 .alignright, .align-right {float: right;}

assets/css/tinymce.css

@@ -4,7 +4,7 @@
 	Description: Nebula is a springboard WordPress theme framework for developers. Like other WordPress startup themes, it has custom functionality built-in (like shortcodes, styles, and JS/PHP functions), but unlike other themes Nebula is not meant for the end-user.
 	Author: Pinckney Hugo Group
 	Author URI: http://www.pinckneyhugo.com
-	Version: 4.11.13
+	Version: 4.11.14
 	License: GNU General Public License v2.0 or later
 	License URI: http://www.gnu.org/licenses/gpl-2.0.html
 	Tags: one-column, two-columns, three-columns, four-columns, left-sidebar, right-sidebar, threaded-comments, theme-options, sticky-post, post-formats, microformats, full-width-template, front-page-post-form, flexible-header, featured-images, featured-image-header, editor-style, custom-menu, custom-colors, accessibility-ready

assets/js/main.js

@@ -1,8 +1,10 @@
+//Bootstrap Reboot is applied to the TinyMCE editor first.
+
 @import 'variables';
 @import 'mixins';
 @import 'helpers'; //Requires mixins
 
-body#tinymce.wp-editor {background: $background_color; color: #292b2c;
+body#tinymce.wp-editor {background: $background_color; font-size: 16px; padding: 20px !important;
 	a {color: $primary_color; text-decoration: none;
 		&:hover {color: $secondary_color;}
 	}

assets/scss/partials/_helpers.scss

@@ -1,5 +1,5 @@
 {
-"version": "4.11.13",
+"version": "4.11.14",
 "details_url": "https://github.com/chrisblakley/Nebula/commits/master",
 "download_url": "https://github.com/chrisblakley/Nebula/archive/master.zip"
 }

assets/scss/style.scss

@@ -29,6 +29,10 @@ public function hooks(){
 				$this->UsersHooks(); // Register Users hooks
 			}
 
+			//Enable editor style for the TinyMCE WYSIWYG editor.
+            add_editor_style(nebula()->bootstrap('reboot'));
+            add_editor_style('assets/css/tinymce.css');
+
             //Force expire query transients when posts/pages are saved.
             add_action('save_post', array($this, 'clear_transients'));
 
@@ -142,9 +146,6 @@ public function hooks(){
 
             add_action('manage_media_custom_column', array($this, 'muc_value'), 10, 2);
 
-            //Enable editor style for the TinyMCE WYSIWYG editor.
-            add_editor_style('assets/css/tinymce.css');
-
             //Enable All Settings page for only Developers who are Admins
             if ( nebula()->is_dev(true) && current_user_can('manage_options') ){
                 add_action('admin_menu', array($this, 'all_settings_link'));
@@ -262,13 +263,15 @@ public function admin_bar_menus($wp_admin_bar){
             ));
 
             //Theme template file
-			$wp_admin_bar->add_node(array(
-                'parent' => $node_id,
-                'id' => 'nebula-template',
-                'title' => '<i class="nebula-admin-fa fa fa-fw fa-object-group" style="font-family: \'FontAwesome\'; color: #a0a5aa; color: rgba(240, 245, 250, .6); margin-right: 5px;"></i> Template: ' . basename($GLOBALS['current_theme_template']) . ' <span class="nebula-admin-light" style="font-size: 10px; color: #a0a5aa; color: rgba(240, 245, 250, .6);">(' . dirname($GLOBALS['current_theme_template']) . ')</span>',
-                'href' => get_edit_post_link(),
-                'meta' => array('target' => '_blank')
-            ));
+            if ( !empty($GLOBALS['current_theme_template']) ){
+				$wp_admin_bar->add_node(array(
+	                'parent' => $node_id,
+	                'id' => 'nebula-template',
+	                'title' => '<i class="nebula-admin-fa fa fa-fw fa-object-group" style="font-family: \'FontAwesome\'; color: #a0a5aa; color: rgba(240, 245, 250, .6); margin-right: 5px;"></i> Template: ' . basename($GLOBALS['current_theme_template']) . ' <span class="nebula-admin-light" style="font-size: 10px; color: #a0a5aa; color: rgba(240, 245, 250, .6);">(' . dirname($GLOBALS['current_theme_template']) . ')</span>',
+	                'href' => get_edit_post_link(),
+	                'meta' => array('target' => '_blank')
+	            ));
+            }
 
             if ( !empty($post_type_object) ){
                 //Ancestor pages

assets/scss/tinymce.scss

@@ -119,29 +119,41 @@ public function twitter_url($username=false){
             return false;
         }
 
-        //Register the requested version of Bootstrap.
-        public function bootstrap_version($lang=false){
+        //Register or return the requested Bootstrap file.
+        public function bootstrap($file=false){
             if ( nebula()->option('bootstrap_version') === 'bootstrap3' ){
                 //Bootstrap 3 (IE8+ Support)
-                if ( $lang === 'css' ){
+                if ( $file === 'css' ){
                     return wp_register_style('nebula-bootstrap', 'https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/3.3.7/css/bootstrap.min.css', null, '3.3.7', 'all');
-                } elseif ( $lang === 'js' ){
+                } elseif ( $file === 'js' ){
                     return nebula_register_script('nebula-bootstrap', 'https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/3.3.7/js/bootstrap.min.js', 'defer', null, '3.3.7', true);
+                } elseif ( $file === 'reboot' ){
+	            	return false;
+	            } else {
+	                return 'v3';
                 }
             } elseif ( nebula()->option('bootstrap_version') === 'bootstrap4a5' ){
                 //Bootstrap 4 alpha 5 (IE9+ Support)
-                if ( $lang === 'css' ){
+                if ( $file === 'css' ){
                     return wp_register_style('nebula-bootstrap', 'https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-alpha.5/css/bootstrap.min.css', null, '4.0.0a5', 'all');
-                } elseif ( $lang === 'js' ){
+                } elseif ( $file === 'js' ){
                     return nebula()->register_script('nebula-bootstrap', 'https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-alpha.5/js/bootstrap.min.js', 'defer', null, '4.0.0a5', true);
+                } elseif ( $file === 'reboot' ){
+	            	return 'https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-alpha.5/css/bootstrap-reboot.min.css';
+	            } else {
+	                return 'v4a5';
                 }
             }
 
             //Latest (IE10+)
-            if ( $lang === 'css' ){
+            if ( $file === 'css' ){
                 return wp_register_style('nebula-bootstrap', 'https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-alpha.6/css/bootstrap.min.css', null, '4.0.0a6', 'all');
-            } elseif ( $lang === 'js' ){
+            } elseif ( $file === 'js' ){
                 return nebula()->register_script('nebula-bootstrap', 'https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-alpha.6/js/bootstrap.min.js', 'defer', null, '4.0.0a6', true);
+            } elseif ( $file === 'reboot' ){
+	            return 'https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.0.0-alpha.6/css/bootstrap-reboot.min.css';
+	        } else {
+                return 'latest';
             }
         }