Form flow bugfixes, more Codacy improvements

I've enabled some new Codacy patterns, so expect some additional commits focused on minor pattern fixes. #1884

Author: chrisblakley

Nebula-Child/resources/sw.js

@@ -1,6 +1,6 @@
 //BEGIN automated edits. These will be automatically overwritten.
 var THEME_NAME = 'nebula-child';
-var NEBULA_VERSION = 'v6.11.30.4061'; //Tuesday, April 30, 2019 10:46:48 AM
+var NEBULA_VERSION = 'v6.11.30.8837'; //Tuesday, April 30, 2019 9:12:33 PM
 var OFFLINE_URL = 'https://gearside.com/nebula/offline/';
 var OFFLINE_IMG = 'https://gearside.com/nebula/wp-content/themes/Nebula-master/assets/img/offline.svg';
 var OFFLINE_GA_DIMENSION = 'cd2';

Nebula-Child/style.css

@@ -508,7 +508,7 @@ function nebulaUniqueSlugChecker(){
                         allowTabChar(this);
                     }
                 }
-            })
+            });
         }
         return this;
     }
@@ -519,8 +519,8 @@ function keywordSearch(container, parent, value, filteredClass){
 	if ( !filteredClass ){
 		var filteredClass = 'filtereditem';
 	}
-	jQuery(container).find("*:not(:Contains(" + value + "))").closest(parent).addClass(filteredClass);
-	jQuery(container).find("*:Contains(" + value + ")").closest(parent).removeClass(filteredClass);
+	jQuery(container).find('*:not(:Contains(' + value + '))').closest(parent).addClass(filteredClass);
+	jQuery(container).find('*:Contains(' + value + ')').closest(parent).removeClass(filteredClass);
 }
 
 /*==========================
@@ -603,8 +603,8 @@ function removeQueryParameter(keys, sourceURL){
 }
 
 //Custom CSS expression for a case-insensitive contains(). Source: https://css-tricks.com/snippets/jquery/make-jquery-contains-case-insensitive/
-//Call it with :Contains() - Ex: ...find("*:Contains(" + jQuery('.something').val() + ")")... -or- use the nebula function: keywordSearch(container, parent, value);
-jQuery.expr[":"].Contains=function(e,n,t){return(e.textContent||e.innerText||"").toUpperCase().indexOf(t[3].toUpperCase())>=0};
+//Call it with :Contains() - Ex: ...find('*:Contains(' + jQuery('.something').val() + ')')... -or- use the nebula function: keywordSearch(container, parent, value);
+jQuery.expr[':'].Contains=function(e,n,t){return(e.textContent||e.innerText||'').toUpperCase().indexOf(t[3].toUpperCase())>=0};
 
 
 //Nebula Options Functions
@@ -952,7 +952,7 @@ function performanceMetrics(){
 					'duration': windowLoaded,
 					'elapsed': windowLoaded
 				}
-			}
+			};
 
 			console.groupCollapsed('Performance');
 			console.table(jQuery.extend(nebula.site.timings, clientTimings));

assets/css/admin.css

@@ -2160,17 +2160,17 @@ function cf7Functions(){
 
 			//Form starts
 			if ( typeof formStarted[formID] === 'undefined' || !formStarted[formID] ){
-				thisEvent.label = 'Began filling out form ID: ' + thisEvent.formID + ' (' + thisEvent.Field + ')';
+				thisEvent.label = 'Began filling out form ID: ' + thisEvent.formID + ' (' + thisEvent.field + ')';
 
 				ga('set', nebula.analytics.metrics.formStarts, 1);
 				nebula.dom.document.trigger('nebula_event', thisEvent);
 				ga('send', 'event', thisEvent.category, thisEvent.action, thisEvent.label);
 				nv('identify', {'form_contacted': 'CF7 (' + thisEvent.formID + ') Started'}, false);
-				nv('event', 'Contact Form (' + thisEvent.formID + ') Started (' + thisEvent.Field + ')');
+				nv('event', 'Contact Form (' + thisEvent.formID + ') Started (' + thisEvent.field + ')');
 				formStarted[formID] = true;
 			}
 
-			updateFormFlow(thisEvent.formID, thisEvent.Field, thisEvent.fieldInfo);
+			updateFormFlow(thisEvent.formID, thisEvent.field, thisEvent.fieldInfo);
 
 			//Track each individual field focuses
 			if ( !jQuery(this).is('button') ){
@@ -2365,11 +2365,15 @@ function updateFormFlow(formID, field, info){
 	if ( !info ){
 		info = '';
 	} else {
+		if ( info.length > 25 ){
+			info = info.substring(0, 25) + '...'; //Truncate long info text
+		}
+
 		info = ' (' + info + ')';
 	}
 
 	if ( !formFlow[formID] ){
-		formFlow[formID] = field + info;
+		formFlow[formID] = formID + ': ' + field + info; //Start a new form flow string beginning with the form ID
 	} else {
 		formFlow[formID] += ' > ' + field + info;
 	}

assets/css/critical.css

@@ -4,7 +4,7 @@
 	Description: Nebula is a springboard WordPress theme framework for developers. Like other WordPress startup themes, it has custom functionality built-in (like shortcodes, styles, and JS/PHP functions), but unlike other themes Nebula is not meant for the end-user.
 	Author: Pinckney Hugo Group
 	Author URI: http://www.pinckneyhugo.com
-	Version: 6.11.30.4493
+	Version: 6.11.30.8838
 	License: GNU General Public License v2.0 or later
 	License URI: http://www.gnu.org/licenses/gpl-2.0.html
 	Tags: one-column, two-columns, three-columns, four-columns, left-sidebar, right-sidebar, threaded-comments, theme-options, sticky-post, post-formats, microformats, full-width-template, front-page-post-form, flexible-header, featured-images, featured-image-header, editor-style, custom-menu, custom-colors, accessibility-ready

assets/css/login.css

@@ -1,5 +1,5 @@
 {
-	"version": "6.11.30.4061",
+	"version": "6.11.30.6321",
 	"details_url": "https://github.com/chrisblakley/Nebula/commits/master",
 	"download_url": "https://github.com/chrisblakley/Nebula/archive/master.zip"
 }