login test: Add happy-path test for AddAccountPage

Author: chrisbobbe

test/api/route/route_checks.dart

@@ -1,12 +1,18 @@
 import 'package:checks/checks.dart';
 import 'package:zulip/api/route/messages.dart';
+import 'package:zulip/api/route/realm.dart';
 import 'package:zulip/api/route/saved_snippets.dart';
 
 extension SendMessageResultChecks on Subject<SendMessageResult> {
   Subject<int> get id => has((e) => e.id, 'id');
 }
+
 extension CreateSavedSnippetResultChecks on Subject<CreateSavedSnippetResult> {
   Subject<int> get savedSnippetId => has((e) => e.savedSnippetId, 'savedSnippetId');
 }
 
+extension GetServerSettingsResultChecks on Subject<GetServerSettingsResult> {
+  Subject<Uri> get realmUrl => has((e) => e.realmUrl, 'realmUrl');
+}
+
 // TODO add similar extensions for other classes in api/route/*.dart

test/widgets/checks.dart

@@ -1,5 +1,6 @@
 import 'package:checks/checks.dart';
 import 'package:flutter/widgets.dart';
+import 'package:zulip/api/route/realm.dart';
 
 import 'package:zulip/model/emoji.dart';
 import 'package:zulip/model/narrow.dart';
@@ -8,6 +9,7 @@ import 'package:zulip/widgets/compose_box.dart';
 import 'package:zulip/widgets/content.dart';
 import 'package:zulip/widgets/emoji.dart';
 import 'package:zulip/widgets/emoji_reaction.dart';
+import 'package:zulip/widgets/login.dart';
 import 'package:zulip/widgets/message_list.dart';
 import 'package:zulip/widgets/page.dart';
 import 'package:zulip/widgets/profile.dart';
@@ -74,6 +76,10 @@ extension AccountRouteChecks<T> on Subject<AccountRoute<T>> {
   Subject<int> get accountId => has((x) => x.accountId, 'accountId');
 }
 
+extension LoginPageChecks on Subject<LoginPage> {
+  Subject<GetServerSettingsResult> get serverSettings => has((x) => x.serverSettings, 'serverSettings');
+}
+
 extension ProfilePageChecks on Subject<ProfilePage> {
   Subject<int> get userId => has((x) => x.userId, 'userId');
 }

test/widgets/login_test.dart

@@ -17,6 +17,7 @@ import 'package:zulip/widgets/login.dart';
 import 'package:zulip/widgets/page.dart';
 
 import '../api/fake_api.dart';
+import '../api/route/route_checks.dart';
 import '../example_data.dart' as eg;
 import '../model/binding.dart';
 import '../stdlib_checks.dart';
@@ -65,7 +66,61 @@ void main() {
     expectErrorFromText('[email protected]', ServerUrlValidationError.noUseEmail);
   });
 
-  // TODO test AddAccountPage
+  group('AddAccountPage', () {
+    late FakeApiConnection connection;
+    List<Route<dynamic>> pushedRoutes = [];
+    List<Route<dynamic>> poppedRoutes = [];
+
+    List<Route<dynamic>> takePushedRoutes() {
+      final routes = pushedRoutes.toList();
+      pushedRoutes.clear();
+      return routes;
+    }
+
+    Future<void> prepare(WidgetTester tester) async {
+      addTearDown(testBinding.reset);
+
+      pushedRoutes = [];
+      poppedRoutes = [];
+      final testNavObserver = TestNavigatorObserver();
+      testNavObserver.onPushed = (route, prevRoute) => pushedRoutes.add(route);
+      testNavObserver.onPopped = (route, prevRoute) => poppedRoutes.add(route);
+      testNavObserver.onReplaced = (route, prevRoute) {
+        poppedRoutes.add(prevRoute!);
+        pushedRoutes.add(route!);
+      };
+
+      await tester.pumpWidget(ZulipApp(navigatorObservers: [testNavObserver]));
+      await tester.pump();
+      check(takePushedRoutes()).single.isA<WidgetRoute>().page.isA<ChooseAccountPage>();
+      await tester.tap(find.text('Add an account'));
+      check(takePushedRoutes()).single.isA<WidgetRoute>().page.isA<AddAccountPage>();
+      await testNavObserver.pumpPastTransition(tester);
+    }
+
+    Future<void> attempt(WidgetTester tester,
+        Uri realmUrl, Map<String, Object?> responseJson) async {
+      await tester.enterText(find.byType(TextField), realmUrl.toString());
+      testBinding.globalStore.useCachedApiConnections = true;
+      connection = testBinding.globalStore.apiConnection(
+        realmUrl: realmUrl,
+        zulipFeatureLevel: null);
+      connection.prepare(json: responseJson);
+      await tester.tap(find.text('Continue'));
+      await tester.pump(Duration.zero);
+    }
+
+    testWidgets('happy path', (tester) async {
+      await prepare(tester);
+
+      final serverSettings = eg.serverSettings();
+
+      await attempt(tester, serverSettings.realmUrl, serverSettings.toJson());
+      checkNoDialog(tester);
+      check(takePushedRoutes()).single.isA<WidgetRoute>().page.isA<LoginPage>()
+        .serverSettings.realmUrl.equals(serverSettings.realmUrl);
+    });
+  });
 
   group('LoginPage', () {
     late FakeApiConnection connection;