autocomplete [nfc]: Renames/doc changes for explicitness about lowercase

Author: chrisbobbe

lib/model/autocomplete.dart

@@ -602,9 +602,9 @@ class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery,
   static int compareByAlphabeticalOrder(User userA, User userB,
       {required PerAccountStore store}) {
     final userAName = store.autocompleteViewManager.autocompleteDataCache
-      .normalizedNameForUser(userA);
+      .lowercaseNameForUser(userA);
     final userBName = store.autocompleteViewManager.autocompleteDataCache
-      .normalizedNameForUser(userB);
+      .lowercaseNameForUser(userB);
     return userAName.compareTo(userBName); // TODO(i18n): add locale-aware sorting
   }
 
@@ -698,9 +698,12 @@ abstract class AutocompleteQuery {
 
   late final List<String> _lowercaseWords;
 
-  /// Whether all of this query's words have matches in [words] that appear in order.
+  /// Whether all of this query's words have matches in [words],
+  /// case-insensitively, that appear in order.
   ///
   /// A "match" means the word in [words] starts with the query word.
+  ///
+  /// [words] must all be lowercased.
   bool _testContainsQueryWords(List<String> words) {
     // TODO(#237) test with diacritics stripped, where appropriate
     int wordsIndex = 0;
@@ -774,7 +777,7 @@ class MentionAutocompleteQuery extends ComposeAutocompleteQuery {
   }
 
   bool _testName(User user, AutocompleteDataCache cache) {
-    return _testContainsQueryWords(cache.nameWordsForUser(user));
+    return _testContainsQueryWords(cache.lowercaseNameWordsForUser(user));
   }
 
   /// A measure of a wildcard result's quality in the context of the query,
@@ -825,22 +828,22 @@ extension WildcardMentionOptionExtension on WildcardMentionOption {
 ///
 /// An instance of this class is managed by [AutocompleteViewManager].
 class AutocompleteDataCache {
-  final Map<int, String> _normalizedNamesByUser = {};
+  final Map<int, String> _lowercaseNamesByUser = {};
 
   /// The lowercase `fullName` of [user].
-  String normalizedNameForUser(User user) {
-    return _normalizedNamesByUser[user.userId] ??= user.fullName.toLowerCase();
+  String lowercaseNameForUser(User user) {
+    return _lowercaseNamesByUser[user.userId] ??= user.fullName.toLowerCase();
   }
 
-  final Map<int, List<String>> _nameWordsByUser = {};
+  final Map<int, List<String>> _lowercaseNameWordsByUser = {};
 
-  List<String> nameWordsForUser(User user) {
-    return _nameWordsByUser[user.userId] ??= normalizedNameForUser(user).split(' ');
+  List<String> lowercaseNameWordsForUser(User user) {
+    return _lowercaseNameWordsByUser[user.userId] ??= lowercaseNameForUser(user).split(' ');
   }
 
   void invalidateUser(int userId) {
-    _normalizedNamesByUser.remove(userId);
-    _nameWordsByUser.remove(userId);
+    _lowercaseNamesByUser.remove(userId);
+    _lowercaseNameWordsByUser.remove(userId);
   }
 }