Skip to content

Commit 2b4ef42

Browse files
committed
new_dm_sheet test: Add a test user with a diacritic in their name
1 parent 691513c commit 2b4ef42

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

test/widgets/new_dm_sheet_test.dart

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,14 +120,15 @@ void main() {
120120
eg.user(fullName: 'Alice Anderson'),
121121
eg.user(fullName: 'Bob Brown'),
122122
eg.user(fullName: 'Charlie Carter'),
123+
eg.user(fullName: 'Édith Piaf'),
123124
];
124125

125126
testWidgets('shows full list initially', (tester) async {
126127
await setupSheet(tester, users: testUsers);
127128
check(findText(includePlaceholders: false, 'Alice Anderson')).findsOne();
128129
check(findText(includePlaceholders: false, 'Bob Brown')).findsOne();
129130
check(findText(includePlaceholders: false, 'Charlie Carter')).findsOne();
130-
check(find.byIcon(ZulipIcons.check_circle_unchecked)).findsExactly(3);
131+
check(find.byIcon(ZulipIcons.check_circle_unchecked)).findsExactly(testUsers.length);
131132
check(find.byIcon(ZulipIcons.check_circle_checked)).findsNothing();
132133
});
133134

@@ -146,7 +147,7 @@ void main() {
146147
await setupSheet(tester, users: [...testUsers, deactivatedUser]);
147148
check(findText(includePlaceholders: false, 'Impostor Charlie')).findsNothing();
148149
check(findText(includePlaceholders: false, 'Charlie Carter')).findsOne();
149-
check(find.byIcon(ZulipIcons.check_circle_unchecked)).findsExactly(3);
150+
check(find.byIcon(ZulipIcons.check_circle_unchecked)).findsExactly(testUsers.length);
150151

151152
// … and after a query that would match their name.
152153
await tester.enterText(find.byType(TextField), 'Charlie');
@@ -164,7 +165,7 @@ void main() {
164165
check(findText(includePlaceholders: false, 'Someone Muted')).findsNothing();
165166
check(findText(includePlaceholders: false, 'Muted user')).findsNothing();
166167
check(findText(includePlaceholders: false, 'Alice Anderson')).findsOne();
167-
check(find.byIcon(ZulipIcons.check_circle_unchecked)).findsExactly(3);
168+
check(find.byIcon(ZulipIcons.check_circle_unchecked)).findsExactly(testUsers.length);
168169

169170
// … and after a query. One which matches both the user's actual name and
170171
// the replacement text "Muted user", for good measure.

0 commit comments

Comments
 (0)