Skip to content

Commit 6896eeb

Browse files
committed
analyze: Fix new lints on latest Flutter main
`flutter analyze` has started giving the following, which breaks CI: info • Unnecessary comparison to a boolean literal • lib/api/model/events.dart:1177:10 • no_literal_bool_comparisons info • Unnecessary comparison to a boolean literal • lib/model/channel.dart:158:13 • no_literal_bool_comparisons Fixed.
1 parent 2b0944f commit 6896eeb

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

lib/api/model/events.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1172,10 +1172,8 @@ class UpdateMessageFlagsRemoveEvent extends UpdateMessageFlagsEvent {
11721172
factory UpdateMessageFlagsRemoveEvent.fromJson(Map<String, dynamic> json) {
11731173
final result = _$UpdateMessageFlagsRemoveEventFromJson(json);
11741174
// Crunchy-shell validation
1175-
if (
1176-
result.flag == MessageFlag.read
1177-
&& true // (we assume `event_types` has `message` and `update_message_flags`)
1178-
) {
1175+
// (we assume `event_types` has `message` and `update_message_flags`)
1176+
if (result.flag == MessageFlag.read) {
11791177
result.messageDetails as Map<int, UpdateMessageFlagsMessageDetail>;
11801178
}
11811179
return result;

lib/model/channel.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,8 @@ mixin ChannelStore on UserStore {
153153
case ChannelPostPolicy.any: return true;
154154
case ChannelPostPolicy.fullMembers: {
155155
if (!role.isAtLeast(UserRole.member)) return false;
156-
return role == UserRole.member
157-
? hasPassedWaitingPeriod(user, byDate: byDate)
158-
: true;
156+
return role != UserRole.member
157+
|| hasPassedWaitingPeriod(user, byDate: byDate);
159158
}
160159
case ChannelPostPolicy.moderators: return role.isAtLeast(UserRole.moderator);
161160
case ChannelPostPolicy.administrators: return role.isAtLeast(UserRole.administrator);

0 commit comments

Comments
 (0)