Skip to content

Commit 6d55b2c

Browse files
chrisbobbegnprice
authored andcommitted
emoji [nfc]: Use EmojiWidget in emoji picker and autocomplete
1 parent e137566 commit 6d55b2c

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

lib/widgets/autocomplete.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -370,13 +370,13 @@ class _EmojiAutocompleteItem extends StatelessWidget {
370370
final designVariables = DesignVariables.of(context);
371371
final candidate = option.candidate;
372372

373-
// TODO deduplicate this logic with [EmojiPickerListEntry]
374373
final emojiDisplay = candidate.emojiDisplay.resolve(store.userSettings);
375374
final Widget? glyph = switch (emojiDisplay) {
376-
ImageEmojiDisplay() =>
377-
ImageEmojiWidget(size: _size, emojiDisplay: emojiDisplay),
378-
UnicodeEmojiDisplay() =>
379-
UnicodeEmojiWidget(size: _size, emojiDisplay: emojiDisplay),
375+
ImageEmojiDisplay() || UnicodeEmojiDisplay() => EmojiWidget(
376+
emojiDisplay: emojiDisplay,
377+
squareDimension: _size,
378+
imagePlaceholderStyle: EmojiImagePlaceholderStyle.square,
379+
),
380380
TextEmojiDisplay() => null, // The text is already shown separately.
381381
};
382382

lib/widgets/emoji_reaction.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -555,13 +555,13 @@ class EmojiPickerListEntry extends StatelessWidget {
555555
final store = PerAccountStoreWidget.of(context);
556556
final designVariables = DesignVariables.of(context);
557557

558-
// TODO deduplicate this logic with [_EmojiAutocompleteItem]
559558
final emojiDisplay = emoji.emojiDisplay.resolve(store.userSettings);
560559
final Widget? glyph = switch (emojiDisplay) {
561-
ImageEmojiDisplay() =>
562-
ImageEmojiWidget(size: _emojiSize, emojiDisplay: emojiDisplay),
563-
UnicodeEmojiDisplay() =>
564-
UnicodeEmojiWidget(size: _emojiSize, emojiDisplay: emojiDisplay),
560+
ImageEmojiDisplay() || UnicodeEmojiDisplay() => EmojiWidget(
561+
emojiDisplay: emojiDisplay,
562+
squareDimension: _emojiSize,
563+
imagePlaceholderStyle: EmojiImagePlaceholderStyle.square,
564+
),
565565
TextEmojiDisplay() => null, // The text is already shown separately.
566566
};
567567

0 commit comments

Comments
 (0)