test [nfc]: Inline eg.globalSettings

This isn't really any longer than invoking it, and cuts out a
layer of indirection.

Author: gnprice

test/example_data.dart

@@ -11,7 +11,6 @@ import 'package:zulip/api/route/realm.dart';
 import 'package:zulip/api/route/channels.dart';
 import 'package:zulip/model/database.dart';
 import 'package:zulip/model/narrow.dart';
-import 'package:zulip/model/settings.dart';
 import 'package:zulip/model/store.dart';
 
 import 'model/test_store.dart';
@@ -874,16 +873,6 @@ ChannelUpdateEvent channelUpdateEvent(
 // The entire per-account or global state.
 //
 
-GlobalSettingsData globalSettings({
-  ThemeSetting? themeSetting,
-  BrowserPreference? browserPreference,
-}) {
-  return GlobalSettingsData(
-    themeSetting: themeSetting,
-    browserPreference: browserPreference,
-  );
-}
-
 TestGlobalStore globalStore({
   GlobalSettingsData? globalSettings,
   List<Account> accounts = const [],

test/model/settings_test.dart

@@ -2,6 +2,7 @@ import 'package:checks/checks.dart';
 import 'package:flutter/foundation.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:zulip/model/binding.dart';
+import 'package:zulip/model/database.dart';
 import 'package:zulip/model/settings.dart';
 
 import '../example_data.dart' as eg;
@@ -14,37 +15,37 @@ void main() {
 
   group('getUrlLaunchMode', () {
     testAndroidIos('globalSettings.browserPreference is null; use our per-platform defaults for HTTP links', () {
-      final globalStore = eg.globalStore(globalSettings: eg.globalSettings(
+      final globalStore = eg.globalStore(globalSettings: GlobalSettingsData(
         browserPreference: null));
       check(globalStore).globalSettings.getUrlLaunchMode(httpLink).equals(
         defaultTargetPlatform == TargetPlatform.android
           ? UrlLaunchMode.inAppBrowserView : UrlLaunchMode.externalApplication);
     });
 
     testAndroidIos('globalSettings.browserPreference is null; use our per-platform defaults for non-HTTP links', () {
-      final globalStore = eg.globalStore(globalSettings: eg.globalSettings(
+      final globalStore = eg.globalStore(globalSettings: GlobalSettingsData(
         browserPreference: null));
       check(globalStore).globalSettings.getUrlLaunchMode(nonHttpLink).equals(
         defaultTargetPlatform == TargetPlatform.android
           ? UrlLaunchMode.platformDefault : UrlLaunchMode.externalApplication);
     });
 
     testAndroidIos('globalSettings.browserPreference is inApp; follow the user preference for http links', () {
-      final globalStore = eg.globalStore(globalSettings: eg.globalSettings(
+      final globalStore = eg.globalStore(globalSettings: GlobalSettingsData(
         browserPreference: BrowserPreference.inApp));
       check(globalStore).globalSettings.getUrlLaunchMode(httpLink).equals(
         UrlLaunchMode.inAppBrowserView);
     });
 
     testAndroidIos('globalSettings.browserPreference is inApp; use platform default for non-http links', () {
-      final globalStore = eg.globalStore(globalSettings: eg.globalSettings(
+      final globalStore = eg.globalStore(globalSettings: GlobalSettingsData(
         browserPreference: BrowserPreference.inApp));
       check(globalStore).globalSettings.getUrlLaunchMode(nonHttpLink).equals(
         UrlLaunchMode.platformDefault);
     });
 
     testAndroidIos('globalSettings.browserPreference is external; follow the user preference', () {
-      final globalStore = eg.globalStore(globalSettings: eg.globalSettings(
+      final globalStore = eg.globalStore(globalSettings: GlobalSettingsData(
         browserPreference: BrowserPreference.external));
       check(globalStore).globalSettings.getUrlLaunchMode(httpLink).equals(
         UrlLaunchMode.externalApplication);

test/model/test_store.dart

@@ -138,7 +138,7 @@ class TestGlobalStore extends GlobalStore with _ApiConnectionsMixin, _DatabaseMi
   TestGlobalStore({
     GlobalSettingsData? globalSettings,
     required super.accounts,
-  }) : super(globalSettings: globalSettings ?? eg.globalSettings());
+  }) : super(globalSettings: globalSettings ?? GlobalSettingsData());
 
   final Map<int, InitialSnapshot> _initialSnapshots = {};
 
@@ -202,7 +202,7 @@ class UpdateMachineTestGlobalStore extends GlobalStore with _ApiConnectionsMixin
   UpdateMachineTestGlobalStore({
     GlobalSettingsData? globalSettings,
     required super.accounts,
-  }) : super(globalSettings: globalSettings ?? eg.globalSettings());
+  }) : super(globalSettings: globalSettings ?? GlobalSettingsData());
 
   // [doLoadPerAccount] depends on the cache to prepare the API responses.
   // Calling [clearCachedApiConnections] is permitted, though.

test/widgets/content_test.dart

@@ -8,6 +8,7 @@ import 'package:flutter_test/flutter_test.dart';
 import 'package:url_launcher/url_launcher.dart';
 import 'package:zulip/api/core.dart';
 import 'package:zulip/model/content.dart';
+import 'package:zulip/model/database.dart';
 import 'package:zulip/model/narrow.dart';
 import 'package:zulip/model/settings.dart';
 import 'package:zulip/model/store.dart';
@@ -801,7 +802,7 @@ void main() {
 
     testWidgets('follow browser preference setting to open URL', (tester) async {
       await testBinding.globalStore.updateGlobalSettings(
-        eg.globalSettings(
+        GlobalSettingsData(
           browserPreference: BrowserPreference.inApp).toCompanion(false));
       await prepare(tester,
         '<p><a href="https://example/">hello</a></p>');

test/widgets/settings_test.dart

@@ -2,6 +2,7 @@ import 'package:checks/checks.dart';
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_test/flutter_test.dart';
+import 'package:zulip/model/database.dart';
 import 'package:zulip/model/settings.dart';
 import 'package:zulip/widgets/settings.dart';
 
@@ -51,7 +52,7 @@ void main() {
       debugBrightnessOverride = Brightness.light;
 
       await testBinding.globalStore.updateGlobalSettings(
-        eg.globalSettings(themeSetting: ThemeSetting.light).toCompanion(false));
+        GlobalSettingsData(themeSetting: ThemeSetting.light).toCompanion(false));
       await prepare(tester);
       final element = tester.element(find.byType(SettingsPage));
       check(Theme.of(element)).brightness.equals(Brightness.light);
@@ -101,7 +102,7 @@ void main() {
 
     testWidgets('smoke', (tester) async {
       await testBinding.globalStore.updateGlobalSettings(
-        eg.globalSettings(
+        GlobalSettingsData(
           browserPreference: BrowserPreference.external).toCompanion(false));
       await prepare(tester);
       checkSwitchAndGlobalSettings(tester,