msglist: Set haveNewest from response, like haveOldest

This is NFC with a correctly-behaved server: we set `anchor=newest`,
so the server always sets `found_newest` to true.

Conversely, this will be helpful as we generalize `fetchInitial` to
work with other anchor values; we'll use the `found_newest` value
given by the server, without trying to predict it from the anchor.

The server behavior that makes this effectively NFC isn't quite
explicit in the API docs.  Those say:

  found_newest: boolean

  Whether the server promises that the messages list includes the
  very newest messages matching the narrow (used by clients that
  paginate their requests to decide whether there may be more
  messages to fetch).

  https://zulip.com/api/get-messages#response

But with `anchor=newest`, the response does need to include the very
newest messages in the narrow -- that's the meaning of that `anchor`
value.  So the server is in fact promising the list includes those,
and `found_newest` is therefore required to be true.

(And indeed in practice the server does set `found_newest` to true
when `anchor=newest`; it has specific logic to do so.)

Author: gnprice

lib/model/message_list.dart

@@ -570,7 +570,7 @@ class MessageListView with ChangeNotifier, _MessageSequence {
       // Now [middleMessage] is the last message (the one just added).
     }
     _haveOldest = result.foundOldest;
-    _haveNewest = true; // TODO(#82)
+    _haveNewest = result.foundNewest;
     _setStatus(FetchingStatus.idle, was: FetchingStatus.fetchInitial);
   }
 

test/example_data.dart

@@ -608,6 +608,26 @@ GetMessagesResult newestGetMessagesResult({
   );
 }
 
+/// A GetMessagesResult the server might return on an initial request
+/// when the anchor is in the middle of history (e.g., a /near/ link).
+GetMessagesResult nearGetMessagesResult({
+  required int anchor,
+  bool foundAnchor = true,
+  required bool foundOldest,
+  required bool foundNewest,
+  bool historyLimited = false,
+  required List<Message> messages,
+}) {
+  return GetMessagesResult(
+    anchor: anchor,
+    foundAnchor: foundAnchor,
+    foundOldest: foundOldest,
+    foundNewest: foundNewest,
+    historyLimited: historyLimited,
+    messages: messages,
+  );
+}
+
 /// A GetMessagesResult the server might return when we request older messages.
 GetMessagesResult olderGetMessagesResult({
   required int anchor,

test/model/message_list_test.dart

@@ -26,6 +26,7 @@ import 'recent_senders_test.dart' as recent_senders_test;
 import 'test_store.dart';
 
 const newestResult = eg.newestGetMessagesResult;
+const nearResult = eg.nearGetMessagesResult;
 const olderResult = eg.olderGetMessagesResult;
 
 void main() {
@@ -185,6 +186,24 @@ void main() {
         ..haveNewest.isTrue();
     });
 
+    test('early in history', () async {
+      // For now, this gets a response that isn't realistic for the
+      // request it sends, to simulate when we start sending requests
+      // that would make this response realistic.
+      // TODO(#82): send appropriate fetch request
+      await prepare();
+      connection.prepare(json: nearResult(
+        anchor: 1000, foundOldest: true, foundNewest: false,
+        messages: List.generate(111, (i) => eg.streamMessage(id: 990 + i)),
+      ).toJson());
+      await model.fetchInitial();
+      checkNotifiedOnce();
+      check(model)
+        ..messages.length.equals(111)
+        ..haveOldest.isTrue()
+        ..haveNewest.isFalse();
+    });
+
     test('no messages found', () async {
       await prepare();
       connection.prepare(json: newestResult(
@@ -421,8 +440,20 @@ void main() {
     });
 
     test('while in mid-history', () async {
-    }, skip: true, // TODO(#82): not yet possible to exercise this case
-    );
+      final stream = eg.stream();
+      await prepare(narrow: ChannelNarrow(stream.streamId));
+      connection.prepare(json: nearResult(
+        anchor: 1000, foundOldest: true, foundNewest: false,
+        messages: List.generate(30,
+          (i) => eg.streamMessage(id: 1000 + i, stream: stream))).toJson());
+      await model.fetchInitial();
+      checkNotifiedOnce();
+
+      check(model).messages.length.equals(30);
+      await store.addMessage(eg.streamMessage(stream: stream));
+      checkNotNotified();
+      check(model).messages.length.equals(30);
+    });
 
     test('before fetch', () async {
       final stream = eg.stream();