home [nfc]: Clean up some dead safe-area code from before bottom-tabs

The responsibility for consuming the bottom inset is now external to
all of these *PageBody widgets; it's handled by
Scaffold.bottomNavigationBar. So we don't need to forward a
bottom-inset value down to descendants
(via `SafeArea.bottom: false`), and we don't need to add widgets to
pad the bottom inset; the bottom-inset height in all these places is
zero.

Author: chrisbobbe

lib/widgets/inbox.dart

@@ -160,9 +160,7 @@ class _InboxPageState extends State<InboxPageBody> with PerAccountStoreAwareStat
       sections.add(_StreamSectionData(streamId, countInStream, streamHasMention, topicItems));
     }
 
-    return SafeArea(
-      // Don't pad the bottom here; we want the list content to do that.
-      bottom: false,
+    return SafeArea( // horizontal insets
       child: StickyHeaderListView.builder(
         itemCount: sections.length,
         itemBuilder: (context, index) {

lib/widgets/recent_dm_conversations.dart

@@ -49,9 +49,7 @@ class _RecentDmConversationsPageBodyState extends State<RecentDmConversationsPag
   @override
   Widget build(BuildContext context) {
     final sorted = model!.sorted;
-    return SafeArea(
-      // Don't pad the bottom here; we want the list content to do that.
-      bottom: false,
+    return SafeArea( // horizontal insets
       child: ListView.builder(
         itemCount: sorted.length,
         itemBuilder: (context, index) {

lib/widgets/subscription_list.dart

@@ -94,8 +94,7 @@ class _SubscriptionListPageBodyState extends State<SubscriptionListPageBody> wit
     _sortSubs(pinned);
     _sortSubs(unpinned);
 
-    return SafeArea(
-      // Don't pad the bottom here; we want the list content to do that.
+    return SafeArea( // horizontal insets
       bottom: false,
       child: CustomScrollView(
         slivers: [
@@ -111,9 +110,6 @@ class _SubscriptionListPageBodyState extends State<SubscriptionListPageBody> wit
           ],
 
           // TODO(#188): add button leading to "All Streams" page with ability to subscribe
-
-          // This ensures last item in scrollable can settle in an unobstructed area.
-          const SliverSafeArea(sliver: SliverToBoxAdapter(child: SizedBox.shrink())),
         ]));
   }
 }