autocomplete test [nfc]: Apply ranking in debugCompareUsers

This makes this function better match the end-to-end behavior of our
autocomplete ordering, now that that involves this ranking notion.

Co-authored-by: Chris Bobbe <[email protected]>

Author: gnprice

lib/model/autocomplete.dart

@@ -455,18 +455,23 @@ class MentionAutocompleteView extends AutocompleteView<MentionAutocompleteQuery,
   }
 
   /// Compare the users the same way they would be sorted as
-  /// autocomplete candidates.
+  /// autocomplete candidates, given [query].
+  ///
+  /// The users must both match the query.
   ///
   /// This behaves the same as the comparator used for sorting in
-  /// [_usersByRelevance], but calling this for each comparison would be a bit
-  /// less efficient because some of the logic is independent of the users and
-  /// can be precomputed.
+  /// [_usersByRelevance], combined with the ranking applied at the end
+  /// of [computeResults].
   ///
   /// This is useful for tests in order to distinguish "A comes before B"
   /// from "A ranks equal to B, and the sort happened to put A before B",
   /// particularly because [List.sort] makes no guarantees about the order
   /// of items that compare equal.
   int debugCompareUsers(User userA, User userB) {
+    final rankA = query.testUser(userA, store)!.rank;
+    final rankB = query.testUser(userB, store)!.rank;
+    if (rankA != rankB) return rankA.compareTo(rankB);
+
     return _comparator(store: store, narrow: narrow)(userA, userB);
   }
 

test/model/autocomplete_test.dart

@@ -845,8 +845,10 @@ void main() {
         eg.dmMessage(from: users[4-1], to: [eg.selfUser]),
       ]);
 
-      // Check the ranking of the full list of mentions.
-      // The order should be:
+      // Check the order of a full list of mentions, focusing on relevance.
+      // The bucket-sort-by-rank step has its own tests;
+      // see "MentionAutocompleteQuery ranking.
+      // For this list, the order should be:
       // 1. Wildcards before individual users.
       // 2. Users most recent in the current topic/stream.
       // 3. Users most recent in the DM conversations.