settings test [nfc]: Use globalSettings as variable

This aligns these tests more closely with how we expect most app code
to interact with these settings (using GlobalStoreWidget.settingsOf).

Author: gnprice

test/model/settings_test.dart

@@ -15,39 +15,39 @@ void main() {
 
   group('getUrlLaunchMode', () {
     testAndroidIos('globalSettings.browserPreference is null; use our per-platform defaults for HTTP links', () {
-      final globalStore = eg.globalStore(globalSettings: GlobalSettingsData(
-        browserPreference: null));
-      check(globalStore).settings.getUrlLaunchMode(httpLink).equals(
+      final globalSettings = eg.globalStore(globalSettings: GlobalSettingsData(
+        browserPreference: null)).settings;
+      check(globalSettings).getUrlLaunchMode(httpLink).equals(
         defaultTargetPlatform == TargetPlatform.android
           ? UrlLaunchMode.inAppBrowserView : UrlLaunchMode.externalApplication);
     });
 
     testAndroidIos('globalSettings.browserPreference is null; use our per-platform defaults for non-HTTP links', () {
-      final globalStore = eg.globalStore(globalSettings: GlobalSettingsData(
-        browserPreference: null));
-      check(globalStore).settings.getUrlLaunchMode(nonHttpLink).equals(
+      final globalSettings = eg.globalStore(globalSettings: GlobalSettingsData(
+        browserPreference: null)).settings;
+      check(globalSettings).getUrlLaunchMode(nonHttpLink).equals(
         defaultTargetPlatform == TargetPlatform.android
           ? UrlLaunchMode.platformDefault : UrlLaunchMode.externalApplication);
     });
 
     testAndroidIos('globalSettings.browserPreference is inApp; follow the user preference for http links', () {
-      final globalStore = eg.globalStore(globalSettings: GlobalSettingsData(
-        browserPreference: BrowserPreference.inApp));
-      check(globalStore).settings.getUrlLaunchMode(httpLink).equals(
+      final globalSettings = eg.globalStore(globalSettings: GlobalSettingsData(
+        browserPreference: BrowserPreference.inApp)).settings;
+      check(globalSettings).getUrlLaunchMode(httpLink).equals(
         UrlLaunchMode.inAppBrowserView);
     });
 
     testAndroidIos('globalSettings.browserPreference is inApp; use platform default for non-http links', () {
-      final globalStore = eg.globalStore(globalSettings: GlobalSettingsData(
-        browserPreference: BrowserPreference.inApp));
-      check(globalStore).settings.getUrlLaunchMode(nonHttpLink).equals(
+      final globalSettings = eg.globalStore(globalSettings: GlobalSettingsData(
+        browserPreference: BrowserPreference.inApp)).settings;
+      check(globalSettings).getUrlLaunchMode(nonHttpLink).equals(
         UrlLaunchMode.platformDefault);
     });
 
     testAndroidIos('globalSettings.browserPreference is external; follow the user preference', () {
-      final globalStore = eg.globalStore(globalSettings: GlobalSettingsData(
-        browserPreference: BrowserPreference.external));
-      check(globalStore).settings.getUrlLaunchMode(httpLink).equals(
+      final globalSettings = eg.globalStore(globalSettings: GlobalSettingsData(
+        browserPreference: BrowserPreference.external)).settings;
+      check(globalSettings).getUrlLaunchMode(httpLink).equals(
         UrlLaunchMode.externalApplication);
     });
   });

test/model/store_test.dart

@@ -33,20 +33,20 @@ void main() {
 
   group('GlobalStore.updateGlobalSettings', () {
     test('smoke', () async {
-      final globalStore = eg.globalStore();
-      check(globalStore).settings.themeSetting.equals(null);
+      final globalSettings = eg.globalStore().settings;
+      check(globalSettings).themeSetting.equals(null);
 
-      await globalStore.settings.setThemeSetting(ThemeSetting.dark);
-      check(globalStore).settings.themeSetting.equals(ThemeSetting.dark);
+      await globalSettings.setThemeSetting(ThemeSetting.dark);
+      check(globalSettings).themeSetting.equals(ThemeSetting.dark);
     });
 
     test('should notify listeners', () async {
       int notifyCount = 0;
-      final globalStore = eg.globalStore();
-      globalStore.settings.addListener(() => notifyCount++);
+      final globalSettings = eg.globalStore().settings;
+      globalSettings.addListener(() => notifyCount++);
       check(notifyCount).equals(0);
 
-      await globalStore.settings.setThemeSetting(ThemeSetting.light);
+      await globalSettings.setThemeSetting(ThemeSetting.light);
       check(notifyCount).equals(1);
     });