topic_list: Make rows at least 40px tall, for big-enough touch target

Author: chrisbobbe

lib/widgets/topic_list.dart

@@ -264,43 +264,47 @@ class _TopicItem extends StatelessWidget {
           topic: topic,
           someMessageIdInTopic: maxId),
         splashFactory: NoSplash.splashFactory,
-        child: Padding(padding: EdgeInsetsDirectional.fromSTEB(6, 8, 12, 8),
-          child: Row(
-            spacing: 8,
-            // In the Figma design, the text and icons on the topic item row
-            // are aligned to the start on the cross axis
-            // (i.e., `align-items: flex-start`).  The icons are padded down
-            // 2px relative to the start, to visibly sit on the baseline.
-            // To account for scaled text, we align everything on the row
-            // to [CrossAxisAlignment.center] instead ([Row]'s default),
-            // like we do for the topic items on the inbox page.
-            // TODO(#1528): align to baseline (and therefore to first line of
-            //   topic name), but with adjustment for icons
-            // CZO discussion:
-            //   https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/topic.20list.20item.20alignment/near/2173252
-            children: [
-              // A null [Icon.icon] makes a blank space.
-              _IconMarker(icon: topic.isResolved ? ZulipIcons.check : null),
-              Expanded(child: Opacity(
-                opacity: opacity,
-                child: Text(
-                  style: TextStyle(
-                    fontSize: 17,
-                    height: 20 / 17,
-                    fontStyle: topic.displayName == null ? FontStyle.italic : null,
-                    color: designVariables.textMessage,
-                  ),
-                  maxLines: 3,
-                  overflow: TextOverflow.ellipsis,
-                  topic.unresolve().displayName ?? store.realmEmptyTopicDisplayName))),
-              Opacity(opacity: opacity, child: Row(
-                spacing: 4,
-                children: [
-                  if (hasMention) const _IconMarker(icon: ZulipIcons.at_sign),
-                  if (visibilityIcon != null) _IconMarker(icon: visibilityIcon),
-                  if (unreadCount > 0) _UnreadCountBadge(count: unreadCount),
-                ])),
-            ]))));
+        child: ConstrainedBox(
+          constraints: BoxConstraints(minHeight: 40),
+          child: Padding(
+            padding: EdgeInsetsDirectional.fromSTEB(6, 4, 12, 4),
+            child: Row(
+              spacing: 8,
+              // In the Figma design, the text and icons on the topic item row
+              // are aligned to the start on the cross axis
+              // (i.e., `align-items: flex-start`).  The icons are padded down
+              // 2px relative to the start, to visibly sit on the baseline.
+              // To account for scaled text, we align everything on the row
+              // to [CrossAxisAlignment.center] instead ([Row]'s default),
+              // like we do for the topic items on the inbox page.
+              // TODO(#1528): align to baseline (and therefore to first line of
+              //   topic name), but with adjustment for icons
+              // CZO discussion:
+              //   https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/topic.20list.20item.20alignment/near/2173252
+              children: [
+                // A null [Icon.icon] makes a blank space.
+                _IconMarker(icon: topic.isResolved ? ZulipIcons.check : null),
+                Expanded(child: Opacity(
+                  opacity: opacity,
+                  child: Text(
+                    style: TextStyle(
+                      fontSize: 17,
+                      height: 20 / 17,
+                      fontStyle: topic.displayName == null ? FontStyle.italic : null,
+                      color: designVariables.textMessage,
+                    ),
+                    maxLines: 3,
+                    overflow: TextOverflow.ellipsis,
+                    topic.unresolve().displayName ?? store.realmEmptyTopicDisplayName))),
+                Opacity(opacity: opacity, child: Row(
+                  spacing: 4,
+                  children: [
+                    if (hasMention) const _IconMarker(icon: ZulipIcons.at_sign),
+                    if (visibilityIcon != null) _IconMarker(icon: visibilityIcon),
+                    if (unreadCount > 0) _UnreadCountBadge(count: unreadCount),
+                  ])),
+              ])),
+        )));
   }
 }