db [nfc]: Simplify name and tests of getGlobalSettings

Now that this method no longer has the job of ensuring there's
a record in the table, its name can reflect that simpler role,
replacing "ensureGlobalSettings".  This simpler role also makes
one test case no longer relevant.

Author: gnprice

lib/model/database.dart

@@ -181,8 +181,7 @@ class AppDatabase extends _$AppDatabase {
       });
   }
 
-  // TODO rename ensureGlobalSettings to reflect its reduced role
-  Future<GlobalSettingsData> ensureGlobalSettings() async {
+  Future<GlobalSettingsData> getGlobalSettings() async {
     // The migrations ensure there is a row.
     return await (select(globalSettings)..limit(1)).getSingle();
   }

lib/model/store.dart

@@ -855,7 +855,7 @@ class LiveGlobalStore extends GlobalStore {
   // by doing this loading up front before constructing a [GlobalStore].
   static Future<GlobalStore> load() async {
     final db = AppDatabase(NativeDatabase.createInBackground(await _dbFile()));
-    final globalSettings = await db.ensureGlobalSettings();
+    final globalSettings = await db.getGlobalSettings();
     final accounts = await db.select(db.accounts).get();
     return LiveGlobalStore._(db: db,
       globalSettings: globalSettings,

test/model/database_test.dart

@@ -26,36 +26,25 @@ void main() {
     });
 
     test('initialize GlobalSettings with defaults', () async {
-      check(await database.ensureGlobalSettings()).themeSetting.isNull();
-    });
-
-    test('ensure single GlobalSettings row', () async {
-      final globalSettings = await database.ensureGlobalSettings();
-      check(await database.select(database.globalSettings).get())
-        .single.equals(globalSettings);
-
-      // Subsequent calls to `ensureGlobalSettings` do not insert new rows.
-      check(await database.ensureGlobalSettings()).equals(globalSettings);
-      check(await database.select(database.globalSettings).get())
-        .single.equals(globalSettings);
+      check(await database.getGlobalSettings()).themeSetting.isNull();
     });
 
     test('does not crash if multiple global settings rows', () async {
       await database.into(database.globalSettings)
         .insert(const GlobalSettingsCompanion(themeSetting: Value(ThemeSetting.dark)));
 
       check(await database.select(database.globalSettings).get()).length.equals(2);
-      check(await database.ensureGlobalSettings()).themeSetting.isNull();
+      check(await database.getGlobalSettings()).themeSetting.isNull();
     });
 
     test('GlobalSettings updates work', () async {
-      check(await database.ensureGlobalSettings())
+      check(await database.getGlobalSettings())
         .themeSetting.isNull();
 
       // As in doUpdateGlobalSettings.
       await database.update(database.globalSettings)
         .write(GlobalSettingsCompanion(themeSetting: Value(ThemeSetting.dark)));
-      check(await database.ensureGlobalSettings())
+      check(await database.getGlobalSettings())
         .themeSetting.equals(ThemeSetting.dark);
     });