Skip to content

Commit bead286

Browse files
committed
new_dm_sheet test: Add a test user with a diacritic in their name
1 parent 1af7a25 commit bead286

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

test/widgets/new_dm_sheet_test.dart

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,14 +123,15 @@ void main() {
123123
eg.user(fullName: 'Alice Anderson'),
124124
eg.user(fullName: 'Bob Brown'),
125125
eg.user(fullName: 'Charlie Carter'),
126+
eg.user(fullName: 'Édith Piaf'),
126127
];
127128

128129
testWidgets('shows full list initially', (tester) async {
129130
await setupSheet(tester, selfUser: testUsers[0], users: testUsers);
130131
check(findText(includePlaceholders: false, 'Alice Anderson')).findsOne();
131132
check(findText(includePlaceholders: false, 'Bob Brown')).findsOne();
132133
check(findText(includePlaceholders: false, 'Charlie Carter')).findsOne();
133-
check(find.byIcon(ZulipIcons.check_circle_unchecked)).findsExactly(3);
134+
check(find.byIcon(ZulipIcons.check_circle_unchecked)).findsExactly(testUsers.length);
134135
check(find.byIcon(ZulipIcons.check_circle_checked)).findsNothing();
135136
});
136137

@@ -150,7 +151,7 @@ void main() {
150151
users: [...testUsers, deactivatedUser]);
151152
check(findText(includePlaceholders: false, 'Impostor Charlie')).findsNothing();
152153
check(findText(includePlaceholders: false, 'Charlie Carter')).findsOne();
153-
check(find.byIcon(ZulipIcons.check_circle_unchecked)).findsExactly(3);
154+
check(find.byIcon(ZulipIcons.check_circle_unchecked)).findsExactly(testUsers.length);
154155

155156
// … and after a query that would match their name.
156157
await tester.enterText(find.byType(TextField), 'Charlie');
@@ -168,7 +169,7 @@ void main() {
168169
check(findText(includePlaceholders: false, 'Someone Muted')).findsNothing();
169170
check(findText(includePlaceholders: false, 'Muted user')).findsNothing();
170171
check(findText(includePlaceholders: false, 'Alice Anderson')).findsOne();
171-
check(find.byIcon(ZulipIcons.check_circle_unchecked)).findsExactly(3);
172+
check(find.byIcon(ZulipIcons.check_circle_unchecked)).findsExactly(testUsers.length);
172173

173174
// … and after a query. One which matches both the user's actual name and
174175
// the replacement text "Muted user", for good measure.

0 commit comments

Comments
 (0)